Skip to content

Use 'icon.name' instead of 'iconName' consistently

Melvin Keskin requested to merge melvo/kaidan:refactor/rename-icon-name into master

According to @jbbgameich, icon.name should be used even if Qt Creator shows an error message for it.

On https://api.kde.org/frameworks-api/frameworks-apidocs/frameworks/kirigami/html/classorg_1_1kde_1_1kirigami_1_1Action.html iconName is used as an alias for backward compatibility but to be consistent with https://doc.qt.io/archives/qt-5.10/qml-qtquick-controls2-action.html#icon.name-prop we use the format icon.name.

A short historical explanation: QtQuick controls 2 did not always have an action type, so it was initially provided completely by Kirigami. Now that it exists, Kirigami's type inherits it but keeps compatibilty with existing code using the alias.

Those text snippets were adapted from https://invent.kde.org/kde/kaidan/merge_requests/438#note_23403.

Edited by Melvin Keskin

Merge request reports