Skip to content
  • Nate Graham's avatar
    Re-allow running Kate and KWrite as the actual root user (but still not using sudo) · bf6d5b75
    Nate Graham authored
    Summary:
    The original change (9adcebd3) to prevent sudo usage broke the use case of running KWrite or Kate while logged in as the actual `root` user with a GUI session. This is how the Kali distro is set up by default, so the original change amounted to making Kate and KWrite not launch at all on this KDE distro.
    
    This patch re-enables running as the actual root user, but keeps blocking usage via `sudo` or `kdesu`. There are no negative security implications associated with re-allowing usage via the root user, since if you're running a GUI session, you were already exposed to the original security threat and Kate and KWrite do not increase the attack surface.
    
    I have submitted a similar change for Dolphin that has been accepted (D12795), but @elvisangelaccio wants that to go in at the same time as this, to keep them in sync.
    
    BUG: 387973
    FIXED-IN: 18.08.0
    
    Test Plan:
    - Log in as normal user and run `sudo kate` or `sudo kwrite`: you get an error message.
    - Log in as normal user and run `kdesu kate` or `kdesu kwrite`: you get an error message.
    - Log in as the root user and run Kate or KWrite normally: it works.
    
    Reviewers: #kate, dhaumann, cullmann, #ktexteditor
    
    Reviewed By: #kate, dhaumann, #ktexteditor
    
    Subscribers: kwrite-devel, elvisangelaccio
    
    Tags: #kate
    
    Differential Revision: https://phabricator.kde.org/D13138
    bf6d5b75