1. 16 Aug, 2019 1 commit
    • Daan De Meyer's avatar
      Further cleanup addons CMake scripts. · 58e19566
      Daan De Meyer authored
      - Update CMake minimum required version to CMake 3.1 which is when
      `target_sources` was added.
      - Use `target_sources` even when commands that work on
      sources variables are used. Instead of appending the generated sources
      to an existing sources variable, we store them in a temporary variable
      and immediately add them to the corresponding target with
      `target_sources`.
      - Remove unnecessary dependencies on `kdeinit_kate`.
      - Remove the intermediary katefiletree static library and have the tests
      build the single required source file manually instead which is
      consistent with how the other addons with tests work.
      58e19566
  2. 27 Jul, 2019 1 commit
    • Christoph Cullmann's avatar
      Further clean up addons CMake scripts. · c4cfdf3b
      Christoph Cullmann authored
      Summary:
      - Reduce addon dependencies to the bare minimum required.
      - Move source files out of sessionapplet/engine directory for
        consistency with the other addons.
      - Ensure each addon is built only if all of its dependencies are found.
      - Remove .kateconfig file in close-expect-like addon directory.
      - Remove comments with no added value.
      
      Test Plan: Make sure builds as before with the same (or an extended) set of addons.
      
      Reviewers: #kate, cullmann
      
      Reviewed By: #kate, cullmann
      
      Subscribers: cullmann, kwrite-devel
      
      Tags: #kate
      
      Differential Revision: https://phabricator.kde.org/D22773
      c4cfdf3b
  3. 25 Jul, 2019 1 commit
    • Christoph Cullmann's avatar
      Clean up Kate addons CMake scripts. · 522b9e2a
      Christoph Cullmann authored
      Summary:
      This is the first in a series of revisions modernizing the Kate CMake scripts.
      I'm submitting the changes to the addons directory first as they form a
      nicely separated list of changes.
      
      Note that if https://phabricator.kde.org/D22698 and
      https://phabricator.kde.org/D22699 are merged, most if not all of the
      remaining source lists in the addons directory can be removed in favor of
      working with targets.
      
      List of changes made:
      
      - Standardize style on two spaces and no whitespace between commands and
        arguments.
      - Remove directory commands in favor of target-based commands as
        recommended by modern CMake.
      - Remove usage of `qt5_add_resources` in favor of `CMAKE_AUTORCC` and
        adding .qrc files directly to a target's sources.
      - Remove usage of source lists (where possible) in favor of CMake 3.1's
        `target_sources` command.
      - Remove the CMake binary directory as an include directory from most
        addons.
      - Remove unnecessary comments, CMake project calls, config files, etc
        from addon CMake scripts.
      - Remove `HAVE_CTERMID` from config.h and move the check and
        addition  to compile definitions to the project addon CMake script as its only
        used in the project plugin sources.
      
      Test Plan: Apply changes and verify Kate still builds and works exactly as before.
      
      Reviewers: #kate, cullmann
      
      Reviewed By: #kate, cullmann
      
      Subscribers: cullmann, kossebau, turbov, asturmlechner, kwrite-devel
      
      Tags: #kate
      
      Differential Revision: https://phabricator.kde.org/D22721
      522b9e2a
  4. 17 Oct, 2015 1 commit
  5. 21 May, 2015 2 commits
  6. 20 May, 2015 1 commit