1. 16 Aug, 2019 3 commits
    • Daan De Meyer's avatar
      Clean up main CMake scripts. · a167b312
      Daan De Meyer authored
      - Use target based commands instead of source variables and directory
      based commands.
      - Move `find_package` calls from top level CMake script into kate and
      kwrite subdirectories. This is consistent with the addons where each
      target finds its own required dependencies.
      - Syntax cleanup: Two spaces indentation and, spaces after command
      names and split long commands over multiple lines.
      - Append to `CMAKE_MODULE_PATH` instead of overriding it so that it can
      be overriden manually from the command line by developers if needed.
      - Remove obvious comments.
      - Remove nested `project` calls as they are unnecessary.
      - Rename `kdeinit_kate` to `kate` and `kate` to `kate-bin`.
      - Remove `qt5_add_resources` usage and pass resource files directly to
      `target_sources` instead (thanks to `CMAKE_AUTORC`).
      - Remove unnecessary and transitive dependencies.
      - Exclusively use variables for MacOS bundle strings.
      a167b312
    • Daan De Meyer's avatar
      Refactor config.h handling. · 458e7832
      Daan De Meyer authored
      - Use separate config.h files for kate and kwrite.
      - Add `KWRITE_VERSION` for use in kwrite source code.
      - Use the more widely used .in suffix for config.h templates instead of
      the .cmake suffix which is primarily used by CMake script files.
      - Rename `KActivities_FOUND` define to `KF5Activities_FOUND` so that
      cmakedefine in config.h.in automatically picks it up when
      `KF5Activities_FOUND` is set during CMake's configure stage.
      - Remove config.h include from source files that don't need it.
      458e7832
    • Daan De Meyer's avatar
      Further cleanup addons CMake scripts. · 58e19566
      Daan De Meyer authored
      - Update CMake minimum required version to CMake 3.1 which is when
      `target_sources` was added.
      - Use `target_sources` even when commands that work on
      sources variables are used. Instead of appending the generated sources
      to an existing sources variable, we store them in a temporary variable
      and immediately add them to the corresponding target with
      `target_sources`.
      - Remove unnecessary dependencies on `kdeinit_kate`.
      - Remove the intermediary katefiletree static library and have the tests
      build the single required source file manually instead which is
      consistent with how the other addons with tests work.
      58e19566
  2. 25 Jul, 2019 1 commit
    • Christoph Cullmann's avatar
      Clean up Kate addons CMake scripts. · 522b9e2a
      Christoph Cullmann authored
      Summary:
      This is the first in a series of revisions modernizing the Kate CMake scripts.
      I'm submitting the changes to the addons directory first as they form a
      nicely separated list of changes.
      
      Note that if https://phabricator.kde.org/D22698 and
      https://phabricator.kde.org/D22699 are merged, most if not all of the
      remaining source lists in the addons directory can be removed in favor of
      working with targets.
      
      List of changes made:
      
      - Standardize style on two spaces and no whitespace between commands and
        arguments.
      - Remove directory commands in favor of target-based commands as
        recommended by modern CMake.
      - Remove usage of `qt5_add_resources` in favor of `CMAKE_AUTORCC` and
        adding .qrc files directly to a target's sources.
      - Remove usage of source lists (where possible) in favor of CMake 3.1's
        `target_sources` command.
      - Remove the CMake binary directory as an include directory from most
        addons.
      - Remove unnecessary comments, CMake project calls, config files, etc
        from addon CMake scripts.
      - Remove `HAVE_CTERMID` from config.h and move the check and
        addition  to compile definitions to the project addon CMake script as its only
        used in the project plugin sources.
      
      Test Plan: Apply changes and verify Kate still builds and works exactly as before.
      
      Reviewers: #kate, cullmann
      
      Reviewed By: #kate, cullmann
      
      Subscribers: cullmann, kossebau, turbov, asturmlechner, kwrite-devel
      
      Tags: #kate
      
      Differential Revision: https://phabricator.kde.org/D22721
      522b9e2a
  3. 15 Jul, 2019 1 commit
  4. 08 Apr, 2019 1 commit
  5. 31 Mar, 2019 1 commit
  6. 16 Mar, 2019 2 commits
  7. 27 Feb, 2019 1 commit
  8. 10 Nov, 2018 1 commit
  9. 09 Nov, 2018 1 commit
  10. 26 Sep, 2018 1 commit
  11. 19 Sep, 2018 1 commit
  12. 14 Aug, 2018 1 commit
  13. 06 Aug, 2018 1 commit
  14. 30 Jul, 2018 1 commit
  15. 16 Jul, 2018 2 commits
  16. 11 Jul, 2018 1 commit
  17. 01 Jun, 2018 1 commit
  18. 02 May, 2018 1 commit
  19. 09 Apr, 2018 1 commit
  20. 02 Apr, 2018 1 commit
  21. 19 Mar, 2018 2 commits
  22. 04 Jan, 2018 1 commit
  23. 12 Dec, 2017 1 commit
  24. 04 Dec, 2017 1 commit
  25. 30 Nov, 2017 1 commit
  26. 13 Nov, 2017 2 commits
  27. 17 Jul, 2017 2 commits
  28. 09 Jul, 2017 1 commit
  29. 08 Jun, 2017 1 commit
    • Kevin Funk's avatar
      katemdi: Fix deprecation warnings · d6f63e02
      Kevin Funk authored
      Summary:
      ```
      /home/kfunk/devel/src/kf5/kate/kate/katemdi.cpp:322:5: warning: 'appendTab' is deprecated [-Wdeprecated-declarations]
          appendTab(icon, newId, text);
          ^
      /home/kfunk/devel/install/kf5/include/KF5/KWidgetsAddons/kmultitabbar.h:138:35: note: 'appendTab' has been explicitly marked deprecated here
          KWIDGETSADDONS_DEPRECATED int appendTab(const QPixmap &pic, int id = -1, const QString &text = QString());
      ```                                  ^
      
      The alternative appendTab function is part of KF5 5.13, thus we need a
      version bump.
      
      Reviewers: cullmann
      
      Reviewed By: cullmann
      
      Subscribers: cullmann, kwrite-devel
      
      Differential Revision: https://phabricator.kde.org/D6132
      d6f63e02
  30. 05 Jun, 2017 1 commit
  31. 08 May, 2017 1 commit
  32. 12 Apr, 2017 1 commit
  33. 05 Apr, 2017 1 commit