1. 17 Oct, 2018 1 commit
    • Silas Lenz's avatar
      Open document before using it's checksum to load metainfos · f0f301be
      Silas Lenz authored
      Summary:
      loadMetaInfos tried to use the documents checksum before loading. The empty checksum results in it always failing to load metainfo and returning false, thus not using any of the stored metainfo.
      
      BUG: 384087
      
      Test Plan:
      1. Enable "Keep meta-information past sessions".
      2. Open file (with or without previous bookmarks).
      3. Add or remove a bookmark.
      4. Close and reopen the file (and/or close and reopen Kate).
      5. Previous bookmarks should be reloaded.
      
      Reviewers: #kate, cullmann
      
      Reviewed By: #kate, cullmann
      
      Subscribers: cullmann, ngraham, kwrite-devel
      
      Tags: #kate
      
      Differential Revision: https://phabricator.kde.org/D16259
      f0f301be
  2. 08 Sep, 2018 1 commit
  3. 02 Sep, 2018 1 commit
  4. 01 Aug, 2018 1 commit
    • Heiko Becker's avatar
      Honor BUILD_TESTING · 7a6e7342
      Heiko Becker authored
      Summary:
      Although ecm_optional_add_subdirectory(autotests) allows to skip
      building the autotests with -DBUILD_autotests=FALSE, it doesn't seem
      reasonable to have two options controlling similar behaviour and
      BUILD_TESTING is the de-facto standard for cmake and already used
      when discovering Qt5::Test.
      
      Furthermore it avoids a cmake warning when BUILD_TESTING is set to
      FALSE because Qt5::Test is passed to target_link_libraries but
      isn't a valid target.
      
      Test Plan: Warning disappears and builds successfully
      
      Reviewers: #kate
      
      Subscribers: kwrite-devel
      
      Tags: #kate
      
      Differential Revision: https://phabricator.kde.org/D14538
      7a6e7342
  5. 28 Jul, 2018 1 commit
  6. 16 Jul, 2018 1 commit
    • Nate Graham's avatar
      Bump version on rc file · 22025804
      Nate Graham authored
      Summary: Fix issue introduced with D11785 where the new menu item didn't actually appear for existing user accounts because the version wasn't bumped on the rc file.
      
      Test Plan: Color chooser menu now appears at the top of the Settings menu with my existing user account.
      
      Reviewers: #kate, tfjellstrom, dhaumann, cullmann
      
      Reviewed By: #kate, cullmann
      
      Subscribers: kwrite-devel
      
      Tags: #kate
      
      Differential Revision: https://phabricator.kde.org/D14148
      22025804
  7. 14 Jul, 2018 1 commit
  8. 22 Jun, 2018 1 commit
  9. 19 Jun, 2018 1 commit
  10. 13 Jun, 2018 1 commit
    • Sven Brauch's avatar
      Fix QuickOpen with Qt 5.11 · 291b6899
      Sven Brauch authored
      It remains to be investigated whether this is a regression in Qt
      itself, or misuse of the API on our side. There is at least one
      misuse (the call to mapFromSource) which is wrong in the old version,
      so this patch improves the situation in either case.
      
      Differential Revision: https://phabricator.kde.org/D13517
      BUG:395039
      291b6899
  11. 05 Jun, 2018 1 commit
  12. 31 May, 2018 1 commit
    • Nate Graham's avatar
      Re-allow running Kate and KWrite as the actual root user (but still not using sudo) · bf6d5b75
      Nate Graham authored
      Summary:
      The original change (9adcebd3) to prevent sudo usage broke the use case of running KWrite or Kate while logged in as the actual `root` user with a GUI session. This is how the Kali distro is set up by default, so the original change amounted to making Kate and KWrite not launch at all on this KDE distro.
      
      This patch re-enables running as the actual root user, but keeps blocking usage via `sudo` or `kdesu`. There are no negative security implications associated with re-allowing usage via the root user, since if you're running a GUI session, you were already exposed to the original security threat and Kate and KWrite do not increase the attack surface.
      
      I have submitted a similar change for Dolphin that has been accepted (D12795), but @elvisangelaccio wants that to go in at the same time as this, to keep them in sync.
      
      BUG: 387973
      FIXED-IN: 18.08.0
      
      Test Plan:
      - Log in as normal user and run `sudo kate` or `sudo kwrite`: you get an error message.
      - Log in as normal user and run `kdesu kate` or `kdesu kwrite`: you get an error message.
      - Log in as the root user and run Kate or KWrite normally: it works.
      
      Reviewers: #kate, dhaumann, cullmann, #ktexteditor
      
      Reviewed By: #kate, dhaumann, #ktexteditor
      
      Subscribers: kwrite-devel, elvisangelaccio
      
      Tags: #kate
      
      Differential Revision: https://phabricator.kde.org/D13138
      bf6d5b75
  13. 11 May, 2018 2 commits
  14. 23 Apr, 2018 1 commit
  15. 08 Apr, 2018 4 commits
  16. 02 Apr, 2018 1 commit
    • Алексей Шилин's avatar
      Don't restart the blocking process on session restore · 0a73e00e
      Алексей Шилин authored
      Summary:
      All blocking Kate processes were restarted on session restore which
      led to launching (possibly) multiple redundant instances.
      
      This change asks the session manager to not restart such processes.
      
      Note: QObject::connect() is used here because the session manager
      can't be accessed directly according to the documentation [1]:
      
          In Qt, session management requests for action are handled by
          the two signals QGuiApplication::commitDataRequest() and
          QGuiApplication::saveStateRequest(). Both provide a reference
          to a QSessionManager object as argument. The session manager
          can only be accessed in slots invoked by these signals.
      
       [1] http://doc.qt.io/qt-5/qsessionmanager.html#details
      
      BUG: 360066
      FIXED-IN: 18.04
      
      Test Plan:
        0. Make sure that Plasma is configured to restore previous session
           on startup.
        1. Open Dolphin and create 'test1' and 'test2' text files.
        2. Open 'test1' in Kate from Dolphin.
        3. Open 'test2' in the already running Kate instance from Dolphin.
        4. Log out and back in. Check that there are no redundant Kate
           instances running.
      
      Reviewers: #kate, dhaumann
      
      Reviewed By: #kate, dhaumann
      
      Subscribers: ngraham, dhaumann
      
      Tags: #kate
      
      Differential Revision: https://phabricator.kde.org/D11818
      0a73e00e
  17. 18 Mar, 2018 1 commit
  18. 13 Mar, 2018 1 commit
  19. 04 Feb, 2018 1 commit
  20. 11 Dec, 2017 1 commit
  21. 04 Dec, 2017 2 commits
  22. 27 Nov, 2017 2 commits
  23. 20 Nov, 2017 1 commit
  24. 16 Nov, 2017 1 commit
    • Christoph Roick's avatar
      Reuse unmodified empty document instead of closing it · e3ece7bd
      Christoph Roick authored
      Summary:
      - In VI-Mode, using :e filename or :tabe filename in the empty
        unmodified initial document makes Kate crash. The caller is
        deleted by closing the document.
      - Reusing the already opened document avoids the problem.
      
      Test Plan: - use :e filename in VI-Mode from a fresh kate instance
      
      Reviewers: #kate, cullmann
      
      Reviewed By: #kate, cullmann
      
      Subscribers: cullmann
      
      Tags: #kate
      
      Differential Revision: https://phabricator.kde.org/D8713
      e3ece7bd
  25. 08 Nov, 2017 1 commit
  26. 27 Oct, 2017 1 commit
  27. 25 Oct, 2017 1 commit
  28. 15 Oct, 2017 1 commit
  29. 06 Oct, 2017 1 commit
  30. 02 Oct, 2017 1 commit
  31. 24 Sep, 2017 1 commit
  32. 15 Sep, 2017 2 commits
  33. 14 Sep, 2017 1 commit