1. 06 Aug, 2018 1 commit
  2. 04 Aug, 2018 1 commit
  3. 01 Aug, 2018 1 commit
    • Heiko Becker's avatar
      Honor BUILD_TESTING · 7a6e7342
      Heiko Becker authored
      Summary:
      Although ecm_optional_add_subdirectory(autotests) allows to skip
      building the autotests with -DBUILD_autotests=FALSE, it doesn't seem
      reasonable to have two options controlling similar behaviour and
      BUILD_TESTING is the de-facto standard for cmake and already used
      when discovering Qt5::Test.
      
      Furthermore it avoids a cmake warning when BUILD_TESTING is set to
      FALSE because Qt5::Test is passed to target_link_libraries but
      isn't a valid target.
      
      Test Plan: Warning disappears and builds successfully
      
      Reviewers: #kate
      
      Subscribers: kwrite-devel
      
      Tags: #kate
      
      Differential Revision: https://phabricator.kde.org/D14538
      7a6e7342
  4. 31 Jul, 2018 1 commit
  5. 30 Jul, 2018 1 commit
  6. 28 Jul, 2018 1 commit
  7. 16 Jul, 2018 2 commits
  8. 14 Jul, 2018 2 commits
  9. 11 Jul, 2018 1 commit
  10. 30 Jun, 2018 1 commit
  11. 23 Jun, 2018 1 commit
  12. 22 Jun, 2018 1 commit
  13. 19 Jun, 2018 1 commit
  14. 18 Jun, 2018 1 commit
  15. 17 Jun, 2018 1 commit
  16. 14 Jun, 2018 3 commits
  17. 13 Jun, 2018 1 commit
    • Sven Brauch's avatar
      Fix QuickOpen with Qt 5.11 · 291b6899
      Sven Brauch authored
      It remains to be investigated whether this is a regression in Qt
      itself, or misuse of the API on our side. There is at least one
      misuse (the call to mapFromSource) which is wrong in the old version,
      so this patch improves the situation in either case.
      
      Differential Revision: https://phabricator.kde.org/D13517
      BUG:395039
      291b6899
  18. 05 Jun, 2018 1 commit
  19. 01 Jun, 2018 1 commit
  20. 31 May, 2018 1 commit
    • Nate Graham's avatar
      Re-allow running Kate and KWrite as the actual root user (but still not using sudo) · bf6d5b75
      Nate Graham authored
      Summary:
      The original change (9adcebd3) to prevent sudo usage broke the use case of running KWrite or Kate while logged in as the actual `root` user with a GUI session. This is how the Kali distro is set up by default, so the original change amounted to making Kate and KWrite not launch at all on this KDE distro.
      
      This patch re-enables running as the actual root user, but keeps blocking usage via `sudo` or `kdesu`. There are no negative security implications associated with re-allowing usage via the root user, since if you're running a GUI session, you were already exposed to the original security threat and Kate and KWrite do not increase the attack surface.
      
      I have submitted a similar change for Dolphin that has been accepted (D12795), but @elvisangelaccio wants that to go in at the same time as this, to keep them in sync.
      
      BUG: 387973
      FIXED-IN: 18.08.0
      
      Test Plan:
      - Log in as normal user and run `sudo kate` or `sudo kwrite`: you get an error message.
      - Log in as normal user and run `kdesu kate` or `kdesu kwrite`: you get an error message.
      - Log in as the root user and run Kate or KWrite normally: it works.
      
      Reviewers: #kate, dhaumann, cullmann, #ktexteditor
      
      Reviewed By: #kate, dhaumann, #ktexteditor
      
      Subscribers: kwrite-devel, elvisangelaccio
      
      Tags: #kate
      
      Differential Revision: https://phabricator.kde.org/D13138
      bf6d5b75
  21. 27 May, 2018 1 commit
  22. 26 May, 2018 1 commit
    • Thomas Surrel's avatar
      Fix CTags dialog error message when adding target · 1418739a
      Thomas Surrel authored
      Summary:
      When trying to add a new index target in the CTags addon (from the view, not from the settings), the dialog message to select the folder is set to point to the current _file_ instead of the current file _directory_. The dialog than complains about it not being a directory.
      
      BUG: 394402
      
      Reviewers: #kate, sars
      
      Reviewed By: #kate, sars
      
      Subscribers: sars, kwrite-devel
      
      Tags: #kate
      
      Differential Revision: https://phabricator.kde.org/D13115
      1418739a
  23. 25 May, 2018 2 commits
  24. 24 May, 2018 3 commits
  25. 23 May, 2018 1 commit
  26. 21 May, 2018 2 commits
  27. 12 May, 2018 2 commits
  28. 11 May, 2018 2 commits
  29. 10 May, 2018 2 commits