1. 14 Jun, 2019 2 commits
  2. 13 Jun, 2019 2 commits
  3. 10 Jun, 2019 2 commits
    • Matthijs Tijink's avatar
      Enable the MPRIS server plugin - allows control of android media players · 0e9dd251
      Matthijs Tijink authored
      The changes allow loading the plugin on older Android versions
      0e9dd251
    • Simon Redman's avatar
      [SMSApp] Support plain-text MMS · 51e957d8
      Simon Redman authored
      ## Summary
      
      Not having support for MMS caused some minor problems, like in https://bugs.kde.org/show_bug.cgi?id=398889 . This patch adds basic MMS support for plain-text MMS, including multi-target messages.
      
      Android companion to kdeconnect-kde!97
      
      Currently there are several rough areas:
        - Multi-target messages do not have the full list of recipients (I am planning to work on this in another patch, because this one is already quite large enough)
        - Parsing MMS is significantly slower than parsing SMS. This makes sense, since we need to make significantly many more content:// calls for MMS. The only solution I can think of here is to add the ability to request a range of messages, which I need to do anyway, but which should not be part of this patch.
        - The desktop app is totally busted with regard to multi-target MMS, but that will also be fixed in another MR
      
      BUG: 398889
      
      ## Test Plan
      
      ### Before:
      Open SMS app on desktop, scroll through conversations, notice:
        - Any single-target message which had the most-recent message as an MMS does not appear
        - Any multi-target MMS conversations do not appear
      
      ### After:
      Open SMS app on desktop, notice:
        - Conversations which have an MMS as their most-recent message appear
        - MMS which consisted of only text are rendered correctly
        - Multi-target conversations are shown (though pretty busted, as said before. Do not attempt to reply to one!)
      51e957d8
  4. 09 Jun, 2019 1 commit
  5. 06 Jun, 2019 1 commit
  6. 04 Jun, 2019 7 commits
  7. 02 Jun, 2019 1 commit
  8. 29 May, 2019 1 commit
  9. 26 May, 2019 1 commit
  10. 24 May, 2019 1 commit
  11. 22 May, 2019 1 commit
  12. 21 May, 2019 4 commits
  13. 20 May, 2019 5 commits
  14. 19 May, 2019 3 commits
  15. 18 May, 2019 1 commit
    • Mitja Cotic's avatar
      [pretty please] allow fetching of cover art in mpris plugin from connected computer · b8d327c2
      Mitja Cotic authored
      Summary:
      So from android 8 onwards it appears that fetching content from "cleartext" urls is disabled by default
      
      https://stackoverflow.com/questions/45940861/android-8-cleartext-http-traffic-not-permitted
      
      I have a mpris service running on my local computer which is connected to the android, that service is also serving cover art for currently playing song. Obviously I can not have a domain set for my computer on a local machine, so cover art urls look like
      `http://<ip>:<port>/<songid>.ext` . Since this restriction was introduced into android 8, kde connect is not able to fetch the art from this url.
      
      This is patch allows connections to raw IPs addresses as well. If there is any security issues regarding this change, I'm prepared to do more work, my suggestion would be to check if IP address in this case matches paired computer's IP address, although this would still be a bit annoying (especially since whatever malicious file can be served from a "cleartext" link as well).
      
      Test Plan:
      - start some sort of server which can serve an image on a paired computer
      - create mpris Player instance on a paired computer and set the `mpris:artUrl` to the served address where this image is available
      - open kde connect android app, select prepared player and see default cover art instead of the served image
      - change artUrl to some image from the web
      - check in kde connect again and see it correctly show a remote image
      
      Reviewers: #kde_connect, nicolasfella, albertvaka
      
      Reviewed By: #kde_connect, nicolasfella, albertvaka
      
      Subscribers: albertvaka, nicolasfella, andyholmes, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D21247
      b8d327c2
  16. 16 May, 2019 1 commit
  17. 13 May, 2019 5 commits
  18. 06 May, 2019 1 commit