Skip to content

[Share Plugin] Open on remote device Android->Desktop and Desktop->Desktop (Task T10563)

Aniket Kumar requested to merge (removed):master into master

Summary

Task T10563

The share plugin allows sending a file to Android and opens it immediately. The same would be useful Android->Desktop

This patch integrates a feature in share plugin on android app which provides the users with two options while sending files on the desktop. Through the UI user can select to either just send the files like earlier or to send and open the files immediately on desktop.

UI

Screenshot_20200216-011824

After tapping on 'Send Files' the Send Files Action appears on the screen giving users with two choices to either send or send and open immediately on desktop as given below in image:

Screenshot_20200216-011830

Description

  • The way it really works is that, on tapping the 'send files' button in MainActivity, it starts the SendFileActivity in Share Plugin.
  • The SendFileActivity UI shows up on the screen which provides users with two option buttons to choose from.
  • When the user taps on the first button it calls the underlying OnSendButtonClicked method which sets open = false and adds it to the corresponding network packet before sending and for the second button it does the same thing but with open set to open = true.
  • On the Desktop end the desktop app checks the value of open and performs the required action depending on whether open is set to true or false for the particular file. I have submitted the merge request of the desktop app as well. Without the desktop app patch, the files will not open on the desktop as right now it doesn't check open variable in received network package. So for this feature to completely work, the desktop patch is also required.Goto Desktop app patch

Test Plan

I have compiled and installed both android and desktop versions on my devices and tested by sending different types of files. There is no issue regarding this feature. The app's speed to transfer data is still the same very quick and snappy.

The UI design is very easy to use and I installed it on my dad's phone and one of my friend's phone and asked them for feedback. They seemed pretty satisfied and felt the UI very comfortable to use with those big buttons and In general, it integrates well with the KDEConnect-android Interface so I left the UI this way.

/label ~feature

Edited by Aniket Kumar

Merge request reports