Commit 9f892851 authored by Albert Vaca Cintora's avatar Albert Vaca Cintora

Don't hide the plasmoid, otherwise the install buttons don't make sense

parent 40b6a9ca
Pipeline #8007 passed with stage
in 8 minutes and 55 seconds
......@@ -32,8 +32,7 @@ Item {
ColumnLayout {
spacing: 5
visible: devicesView.count == 0
width: parent.width
height: parent.height
anchors.fill: parent
PlasmaExtras.Heading {
id: heading
......@@ -49,6 +48,7 @@ Item {
PlasmaComponents.Label {
Layout.fillWidth: true
Layout.bottomMargin: units.largeSpacing
text: i18n("Install KDE Connect on your Android device to integrate it with Plasma!")
horizontalAlignment: Text.AlignHCenter
......@@ -56,15 +56,19 @@ Item {
}
PlasmaComponents.Button {
Layout.leftMargin: units.largeSpacing
Layout.rightMargin: units.largeSpacing
Layout.alignment: Qt.AlignHCenter
Layout.fillWidth: true
text: i18n("Install from Google Play")
onClicked: Qt.openUrlExternally("https://play.google.com/store/apps/details?id=org.kde.kdeconnect_tp")
}
PlasmaComponents.Button {
Layout.leftMargin: units.largeSpacing
Layout.rightMargin: units.largeSpacing
Layout.alignment: Qt.AlignHCenter
Layout.fillWidth: true
text: i18n("Install from F-Droid")
onClicked: Qt.openUrlExternally("https://f-droid.org/en/packages/org.kde.kdeconnect_tp/")
}
......
......@@ -42,7 +42,7 @@ Item
Binding {
target: plasmoid
property: "status"
value: (connectDeviceModel.count > 0) ? PlasmaCore.Types.ActiveStatus : ((pairedDeviceModel.count > 0) ? PlasmaCore.Types.HiddenStatus : PlasmaCore.Types.PassiveStatus)
value: (connectDeviceModel.count > 0) ? PlasmaCore.Types.ActiveStatus : PlasmaCore.Types.PassiveStatus
  • The old behaviour was intentional (see !112 (closed)), slightly modified from !111 (merged). What was the reason for changing this back again?

  • If devicesView.count == 0 the plasmoid was hidden, which meant that the buttons to go to the stores were never visible. Also, since we don't have a first-run "welcome to kdeconnect" thing, hiding the plasmoid makes kdeconnect hard to discover. The use case this was covering was for people who don't use kdeconnect, and those can still hide in in the tray settings, or plain uninstall it.

  • No, it was hidden if you had paired devices (so we could assume the user has installed KDE Connect already, or know how to do it).

  • Ah, it makes more sense now! That's better than what my initial though, but I still would prefer the icon to be visible. It's not a strong opinion, though. What are your thoughts?

  • When my phone is on the other side of the room and for some reason KDE Connect is not connected, I usually look for the refresh button in the plasmoid first. It takes me a second to realize it's not there and go find the settings app. Then I usually need to go get my phone anyway because Android is sleeping too deeply...

Please register or sign in to reply
}
Plasmoid.fullRepresentation: FullRepresentation {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment