1. 24 Jan, 2019 1 commit
    • Nicolas Fella's avatar
      Simplify notification handling · 74e7a90c
      Nicolas Fella authored
      Use QPointer for KNotification
      Use ready signal for signalling updates
      BUG: 400010
      Test Plan: Spawned some notifications
      Reviewers: #kde_connect, broulik, albertvaka
      Reviewed By: #kde_connect, albertvaka
      Subscribers: albertvaka, kdeconnect
      Tags: #kde_connect
      Differential Revision: https://phabricator.kde.org/D18354
  2. 12 Dec, 2018 1 commit
    • Simon Redman's avatar
      [Desktop] Change ThreadID to long · 5cdfb9b0
      Simon Redman authored
      Summary: Change ThreadID to long
      Test Plan:
      Messages should send and receive as before. Additionally, if your device has assigned extremely large ThreadIDs, the SMS plugin should no longer crash.
      This patch corresponds to the Android-side revision D17517
      Reviewers: #kde_connect, nicolasfella
      Reviewed By: #kde_connect, nicolasfella
      Subscribers: nicolasfella, kdeconnect
      Tags: #kde_connect
      Differential Revision: https://phabricator.kde.org/D17516
  3. 26 Nov, 2018 2 commits
  4. 16 Nov, 2018 1 commit
  5. 11 Nov, 2018 1 commit
  6. 07 Nov, 2018 1 commit
    • Nicolas Fella's avatar
      [app] Add system volume control · 2f76d214
      Nicolas Fella authored
      Summary: Add a remote systemvolume plugin.
      Test Plan:
      Change volume via slider -> Volume on target changes
      Change volume on target -> Slider changes
      Mute via button -> Mute on target changes
      Mute on target -> Button changes icon
      Add/remove sink on host -> Sink is add/removed in list
      Reviewers: #kde_connect, apol
      Reviewed By: #kde_connect, apol
      Subscribers: apol, kdeconnect
      Tags: #kde_connect
      Differential Revision: https://phabricator.kde.org/D16667
  7. 31 Oct, 2018 1 commit
  8. 07 Oct, 2018 2 commits
  9. 10 Sep, 2018 1 commit
    • Simon Redman's avatar
      Split SMS and Telephony plugin on desktop · bcc9fb06
      Simon Redman authored
      Telephony and SMS handling are quite distinct so they should be in separate plugins for better maintainability, given that @sredman has big plans with SMS.
      This diff should be fully backwards compatible, but whether we really want to do that is up to discussion
      Test Plan: Only supeficially tested. Receive an SMS (old way), Notification is shown
      Reviewers: #kde_connect, sredman
      Reviewed By: sredman
      Subscribers: albertvaka, apol, sredman, kdeconnect, #kde_connect
      Tags: #kde_connect
      Differential Revision: https://phabricator.kde.org/D13594
  10. 06 Sep, 2018 1 commit
  11. 02 Aug, 2018 1 commit
    • Adam Pigg's avatar
      Build kdeconnect on sailfish and port some simple plugins · 9a8f1b48
      Adam Pigg authored
      Below is a lost of the commits, but, in summary
      Port the build system for Sailfish, which means selectively building only the bits we need/can, and only against the KF5 libs that are available.
      Allow to build on Qt 5.6
      Switch from knotification to nemo notification (not complete!)
      Add a very simple example sailfish app.
      Note, there is still much missing functionality.  Notifications dont work, pairing sort of works but not really, but when it is paired you can send a ping to the desktop client
      Dont build kio for Sailfish
      Port core build system
      Port daemon buld system
      Require CoreAddons on Sailfish
      Port plugins build for sailfish and include the ping plugin for now
      Final build changes for sailfish.
      Disable tests and other not needed parts
      Add includes for QCA
      Fix build errors on sailfish
      Get core/ to build on sailfish
      Get interfaces/ to build on sailfish
      Build daemon on sailfish
      On sailfish, dont install the kcm file
      Start port plugin to sailfish
      Fixup installed files
      Add sfos app
      Hack declarative plugin to give a public interface
      Build sfos app
      Compile declarativeplugin into the sfos app for now
      Redefine qAsConst for qt 5.6
      Packaging fixes
      Use official icon
      Package .desktop
      Reviewers: #kde_connect, apol, nicolasfella, albertvaka
      Reviewed By: #kde_connect, apol, nicolasfella, albertvaka
      Subscribers: kdeconnect, andyholmes, albertvaka, kossebau, mtijink, vonreth, apol, #kde_connect, nicolasfella
      Tags: #kde_connect
      Differential Revision: https://phabricator.kde.org/D10703
  12. 12 Jul, 2018 1 commit
  13. 20 Jun, 2018 1 commit
    • Nicolas Fella's avatar
      Enable running commands from app · 17e1e1ec
      Nicolas Fella authored
      The RemotecommandsPlugin lacks a graphical frontend.
      Inlcudes a Dbus Interface for fetching the commands and a Model exposing them to QML. For this I oriented on the NotificatonsPlugin.
      Test Plan:
      Open command list in app, check available commands, trigger some. Do same for CLI.
      Activate edit action, check KCM opening on remote device, add command, check for new command in list
      Reviewers: #kde_connect, apol
      Reviewed By: #kde_connect, apol
      Subscribers: apol, kdeconnect, #kde_connect
      Tags: #kde_connect
      Differential Revision: https://phabricator.kde.org/D13503
  14. 09 Jun, 2018 1 commit
    • Aleix Pol Gonzalez's avatar
      (WIP) Upgrade Telephony plugin to read SMS history (KDE side) · 31e93ef7
      Aleix Pol Gonzalez authored
      For real usecases of SMS support, we will almost always need access to the message history in some way
      Specifically resolve T8338
      Incidentally resolve T6651 since Telephony shall no longer create a notification
      Test Plan:
      - Build corresponding Android-side diff (D11698)
      - Build this diff
      Step 1: Does anything at all work?
      - Put a breakpoint in the handleBatchMessages method of the telephony plugin, ideally after constructing a Message object
      - Use DBus to poke /modules/kdeconnect/devices/<deviceID>/telephony.requestAllConversations()
      - Verify that the constructed Message is one you sent or received and that it is the most recent in the corresponding conversation
      Step 2: DBus
      - Open the Interface org.kde.kdeconnect.device.conversations of /modules/kdeconnect/devices/<deviceId>
      - Poke activeConversations and verify an empty array is returned
      - Poke requestAllConversationThreads
      - Poke activeConversations and verify that a list of numbers has been returned. These are conversationIds
      - Use a conversationId to call getFirstFromConversation
        - Verify that the returned Message object is one which you recognize
        - Note that if the message is an MMS it will be blank and meaningless. Try a different conversationId. MMS support "coming soon!"
      Step 3: SMS App
      - Use ccmake (or similar) to set SMSAPP_ENABLE to ON
      - Build the project
      - Run ./bin/kdeconnect-sms
      - Verify that the app shows a list of everyone you have an SMS conversation with (MMS messages are stripped out)
        - If you have the Contacts plugin working, verify that most contacts have their name and photo instead of their phone number
      Reviewers: #kde_connect, nicolasfella, apol
      Reviewed By: #kde_connect, nicolasfella, apol
      Subscribers: andyholmes, apol, nicolasfella, #kde_connect
      Tags: #kde_connect
      Maniphest Tasks: T8338, T6651
      Differential Revision: https://phabricator.kde.org/D11854
  15. 27 Apr, 2018 1 commit
    • Nicolas Fella's avatar
      Support multiple players in MprisRemote · 1b622de1
      Nicolas Fella authored
      Summary: Current code only supports one player
      Test Plan: Run two media sessions. Dbus inspection works fine, UI has some issues with values not updated, but out of scope for this diff
      Reviewers: #kde_connect, apol
      Reviewed By: #kde_connect, apol
      Subscribers: apol, #kde_connect
      Tags: #kde_connect
      Differential Revision: https://phabricator.kde.org/D12546
  16. 19 Apr, 2018 1 commit
  17. 25 Mar, 2018 1 commit
    • Aleix Pol Gonzalez's avatar
      Optionally include sms app · c863feef
      Aleix Pol Gonzalez authored
      Creates a tiny messaging app that uses KPeople to query the contacts and
      KDE connect telephony plugins to send plugins.
      To be ready, still needs some work on the contacts sync side and some
      messages history would be nice.
  18. 17 Mar, 2018 1 commit
  19. 05 Mar, 2018 1 commit
  20. 03 Dec, 2017 1 commit
    • Matthijs Tijink's avatar
      Fix "error activiting kdeconnectd" for kdeconnect-cli · 227e2640
      Matthijs Tijink authored
      Kdeconnect-cli always displayed one or more "error activating kdeconnectd: QDBusError("", "")" messages.
      This diff uses the reply of starting the kdeconnect daemon correctly, so this does not happen anymore.
      Test Plan: Kdeconnect-cli and the daemon still work, but kdeconnect-cli does not show the error message anymore. I verified that if, for some reason, the daemon could not start, it does display an error.
      Reviewers: #kde_connect, apol
      Reviewed By: #kde_connect, apol
      Subscribers: apol
      Differential Revision: https://phabricator.kde.org/D9058
  21. 06 Nov, 2017 1 commit
    • Nicolas Fella's avatar
      Fix Notifications in Plasmoid · fbf8852d
      Nicolas Fella authored
      Fixed Issues mentioned in https://phabricator.kde.org/T6729
      This patch also fixes a crash when the filetransfer of the icon fails
      Test Plan:
      Receive a notification with a previously unknown icon -> icon in Plasmoid is displayed correctly
      Receive a notification with an already existing id -> notification in Plasmoid is updated
      Reviewers: #kde_connect, apol
      Reviewed By: #kde_connect, apol
      Subscribers: albertvaka, broulik, apol, #kde_connect
      Tags: #kde_connect
      Differential Revision: https://phabricator.kde.org/D7209
  22. 03 Sep, 2017 1 commit
    • Jean Vincent's avatar
      Make member variable names, & placement and * placement more coherent · 72535ecf
      Jean Vincent authored
      Change all member variables to the form m_fooBar because it is the preferred form in Qt (it was half and half between this and mFooBar, and a minority didn't have anything).
      Place all references and pointers on the side of the type since it is the majority.
       - mFoo -> m_foo
       - foo -> m_foo (if it is a member variable)
       - Type &ref -> Type& ref
       - Type *ptr -> Type* ptr
      Reviewers: #kde_connect, nicolasfella, albertvaka
      Reviewed By: #kde_connect, nicolasfella, albertvaka
      Subscribers: albertvaka, #kde_connect
      Tags: #kde_connect
      Differential Revision: https://phabricator.kde.org/D7312
  23. 22 Aug, 2017 1 commit
  24. 21 Jul, 2017 1 commit
    • Jean Vincent's avatar
      Replace Q_FOREACH with C++11 range-for · c864267f
      Jean Vincent authored
      The use of Q_FOREACH is advised against (https://doc.qt.io/qt-5/qtglobal.html#Q_FOREACH) since Qt 5.7 and will eventually be removed from Qt.
      I replaced all occurrences with the range-for loop introduced in C++11 (except for the one in daemon.cpp in deviceIdByName which might have a bug / typo in it).
      I added const to the container or casted it with qAsConst when appropriate to avoid unnecessary copies.
      (This is my first submission. I did all the unit tests, and they all passed but I don't know how to show it here.)
      Reviewers: #kde_connect, nicolasfella, apol
      Reviewed By: #kde_connect, nicolasfella, apol
      Subscribers: albertvaka, apol, nicolasfella
      Tags: #kde_connect
      Differential Revision: https://phabricator.kde.org/D6724
  25. 09 Jun, 2017 1 commit
  26. 01 Jun, 2017 1 commit
    • Julian Wolff's avatar
      show icon and reply toolbutton in plasmoid · 8aaa1884
      Julian Wolff authored
      Show an icon for each notification which has an icon.
      	Show a toolbutton which can be used to reply to notifications which offer a quick reply.
      Reviewers: #kde_connect, albertvaka
      Reviewed By: #kde_connect, albertvaka
      Subscribers: albertvaka
      Maniphest Tasks: T4674, T4658
      Differential Revision: https://phabricator.kde.org/D6058
  27. 20 Feb, 2017 1 commit
  28. 25 Jan, 2017 1 commit
    • Aleix Pol Gonzalez's avatar
      Debug pairing handlers · 6c77bc5a
      Aleix Pol Gonzalez authored
      Make sure we don't emit if it doesn't actually change
      Make sure if it changed when we react to a pairing
      Pair-programmed with Albert Vaca
  29. 23 Jan, 2017 1 commit
  30. 13 Jan, 2017 2 commits
  31. 11 Jan, 2017 1 commit
  32. 10 Jan, 2017 1 commit
    • Holger Kaelberer's avatar
      kdeconnect-kde: Add remotekeyboard plugin · 040ad735
      Holger Kaelberer authored
      Allow to inject keypress events to remote peers (most notably Android devices)
      Notes / open issues / possible improvements:
      - For the json-payload I used the syntax of the key-events as sent by mousepad-plugin with the addition of a "sendAck"-flag. If "sendAck" is set to true the remote peer should echo a key-event if it could be handled, thus allowing the local client to find out whether the key was accepted. For performance reasons, it's allowed to send multi-char strings in the "key" property (performs much better if you send a whole string via "echo '...' |  kdeconnect-cli ..." e.g.)
      - kdeconnect-cli: For now takes a string and transforms it into single key-events for visible characters only. In a first implementation I used a kbhit() helper that used termios.h to catch and relay keypresses interactively (including some special-events), which was not optimal. A better approch might be to use linux input-api directly. Would this be an option regarding cross-platform compatibility or can I assume to develop for Linux only? Being a command-line guy, I'd really like to have a fully featured kdeconnect-cli interface ;-)
      - Factor out the Qt::Key-to-internal keymap to some core-helper because it corresponds to the mapping in the mousepad-plugin?
      - The plasmoid is not perfect as it is: A single line containing a non-echoing TextField (i.e. it eats all the KeyPress events), and only ack-ed keypress-packets from the peer device are injected if they contain visible keys. Advantage: the user sees whether his key-presses are accepted by the peer device. Disadvantage: The echoed text does not correspond 1:1 to what is shown on the peer's display, user might be confused when typing without success. I played around with different variations each of which with its proper shortcomings:
      1. An echoing Textfield for typing: Has the advantage that the user can directly see what he is typing, which makes interaction in the typing field easier, BUT messes up interaction if the Editor on the peer is changed silently and does not notify the user if his keypresses are not handled by the peer.
      2. A non-echoing TextField for typing PLUS a readonly one for printing visible echoed keys. Disadvantage: same as for the previous one and uses more space on the plasmoid.
      Comments? Ideas?
      REVIEW: 129727
      BUG: 370919
  33. 28 Nov, 2016 1 commit
  34. 26 Nov, 2016 3 commits
  35. 23 Nov, 2016 1 commit