1. 10 Jun, 2019 1 commit
  2. 07 Jun, 2019 1 commit
  3. 02 Jun, 2019 5 commits
  4. 01 Jun, 2019 1 commit
  5. 31 May, 2019 1 commit
  6. 30 May, 2019 1 commit
  7. 08 May, 2019 1 commit
  8. 05 May, 2019 1 commit
  9. 30 Apr, 2019 3 commits
  10. 23 Mar, 2019 1 commit
  11. 18 Mar, 2019 3 commits
  12. 10 Mar, 2019 1 commit
  13. 09 Mar, 2019 2 commits
    • Nicolas Fella's avatar
      Use input field from Kaidan · 906cdfba
      Nicolas Fella authored
      Summary: It looks a bit better
      
      Test Plan: {F6314845}
      
      Reviewers: #kde_connect, albertvaka
      
      Reviewed By: #kde_connect, albertvaka
      
      Subscribers: albertvaka, sredman, mart, hein, apol, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D16071
      906cdfba
    • Nicolas Fella's avatar
      [SMS App] Allow passing a message via args · fd99d84e
      Nicolas Fella authored
      Summary:
      Add --message option to kdeconnect-sms to pass a message. The user only needs to choose a recepient and the message will be sent. Useful for integration with 3rd party
      apps, e.g. via Purpose
      
      Test Plan:
      kdeconnect-sms --message "Hello World", choose chat, message is sent
      Click another chat, no message sent
      kdeconnect-sms without args, no message sent
      
      Reviewers: #kde_connect, sredman
      
      Reviewed By: #kde_connect, sredman
      
      Subscribers: andyholmes, sredman, apol, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D17292
      fd99d84e
  14. 08 Mar, 2019 1 commit
  15. 27 Feb, 2019 1 commit
    • Simon Redman's avatar
      [SMS App] Add highlighting to ConversationList view · 1ec20886
      Simon Redman authored
      Summary: Let the ListView use its default highlighting (did I not notice before?) and keep the currently-selected chat highlighted at all times
      
      Test Plan:
       - Launch app
       - Use mouse or arrow keys to select a conversation. The highlight should follow the selected conversation
      
      Reviewers: #kde_connect, apol
      
      Reviewed By: #kde_connect, apol
      
      Subscribers: apol, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D17612
      1ec20886
  16. 03 Feb, 2019 1 commit
  17. 31 Jan, 2019 1 commit
  18. 25 Jan, 2019 1 commit
  19. 24 Jan, 2019 1 commit
    • Simon Redman's avatar
      Add dependency on kirigami to SMS app · 3b92b0de
      Simon Redman authored
      Summary:
      Resolves Bug 401255
      
      Bonus: Disable some very noisy debugging from the SMS app
      
      Test Plan:
       - Build KDE Connect with or without Kirigami
         - Verify successful build with no complaints about Kirigami
       - Build KDE Connect's Messenger:
         - Without Kirigami: Verify that CMake warns that Kirigami is not found
         - With Kirigami: Verify that app launches successfully
      
      Reviewers: #kde_connect, nicolasfella
      
      Reviewed By: #kde_connect, nicolasfella
      
      Subscribers: apol, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D17572
      3b92b0de
  20. 23 Jan, 2019 1 commit
    • Simon Redman's avatar
      [SMS App] Make sms app not crash when conversation is selected with no devices connected · a14b39d5
      Simon Redman authored
      Summary: This patch fixes T10184 and stops the SMS app from crashing when a conversation is selected but no devices are connected. It also allows the SMS app to access the cached messages in the ConversationsDbusInterface so the app is still slightly useful even when the device is disconnected.
      
      Test Plan:
      - Open sms app
      - Open a few conversations
      - Disconnect phone (Force close app?)
      - Re-open a conversation which was previously opened
        - Verify that the messages appear. It is possible to scroll up to view any older cached messages too!
      - Open a conversation which was not opened previously
        - Verify that a single messages is shown (since this was the only one in cache, from populating the list of all conversations)
        - Verify that attempting to scroll this conversation does nothing, but also does not crash the app
      
      Note: Opening the app with no phone connected will cause it to lose its handle on the deviceId, so it can't spawn a new Dbus interface, so it will remain blank and empty. Solving that is a project for another day.
      
      Reviewers: #kde_connect
      
      Reviewed By: #kde_connect
      
      Subscribers: apol, nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Maniphest Tasks: T10184
      
      Differential Revision: https://phabricator.kde.org/D17634
      a14b39d5
  21. 17 Dec, 2018 1 commit
    • Simon Redman's avatar
      [SMS App] Improve filter · 5b213e61
      Simon Redman authored
      Summary:
      - Allow filter box to handle keystrokes passed to the ListView
       - This is a little cheesy, but fixes T8341
      
      - Pin filter box to always be visible
      
      - Clear filter on Esc
      
      Test Plan:
      - Try typing a contact you would like to search for
       - Before: Every time you type a new letter, the filter box would lose focus and you would have to click it to give it focus again
       - Now: You can type smoothly
      
      - Try scrolling the list
       - Before: The filter box disappeared off the top of the screen
       - Now: The filter box is always visible
      
      - Try pressing escape
       - Before: Nothing
       - Now: Filter clears
      
      - Bonus: When using the arrow keys to navigate, before the filter was manually handling those and the view would not loop. Now, the view loops if you try to select an item past the beginning or end (Easiest to see with highlighting from D17612)
      
      Reviewers: #kde_connect, apol
      
      Reviewed By: #kde_connect, apol
      
      Subscribers: kdeconnect
      
      Tags: #kde_connect
      
      Maniphest Tasks: T8341
      
      Differential Revision: https://phabricator.kde.org/D17614
      5b213e61
  22. 16 Dec, 2018 1 commit
  23. 14 Dec, 2018 1 commit
  24. 13 Dec, 2018 3 commits
    • Simon Redman's avatar
      [SMS App] Allow scrolling up to load and display older messages · 2c35c1af
      Simon Redman authored
      Summary:
      Scroll up to show older messages
      
      Newly received messages will not force the view to the bottom unless the new message is being added "very close" to the visible area
      
      Test Plan:
      Message History:
       - Open conversation
       - Scroll/Drag up to load older messages
      
      New Message:
       - Open conversation
       - Scroll to bottom
       - Verify that a newly-received or newly-sent message is added to the GUI
       - Scroll up
       - Verify that sending/receiving a message does not disturb the view
       - Scroll back to verify that the new message was indeed added to the list
      
      Reviewers: #kde_connect, apol
      
      Reviewed By: #kde_connect, apol
      
      Subscribers: apol, nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Maniphest Tasks: T9556
      
      Differential Revision: https://phabricator.kde.org/D15979
      2c35c1af
    • Simon Redman's avatar
    • Simon Redman's avatar
      [SMS App] Make requestMoreMessages asynchronous, blocking, and caching · 019e8d6a
      Simon Redman authored
      Summary:
      The most serious change from this patch is to move the asynchronous replying to a request from the app for more messages to a newly-spawned, self-destructing thread. Within that thread, we block until the remote device replies with the requested messages.
      
      All gotten messages are cached in the ConversationDbusInterface, so all future requests are fast and don't hit the remote device.
      
      Test Plan: After applying this diff, the messaging app should show 10 messages every time it is opened
      
      Reviewers: #kde_connect, nicolasfella, albertvaka
      
      Reviewed By: #kde_connect, albertvaka
      
      Subscribers: albertvaka, apol, nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D16475
      019e8d6a
  25. 02 Dec, 2018 1 commit
  26. 29 Nov, 2018 1 commit
  27. 26 Nov, 2018 1 commit
  28. 25 Nov, 2018 1 commit
  29. 10 Nov, 2018 1 commit
    • Simon Redman's avatar
      [SMS App] Don't set font size, which causes warnings to be printed · 73191d85
      Simon Redman authored
      Summary:
      Whenever a ConversationMessage was constructed, a warning was printed saying "Both point size and pixel size set. Using pixel size." Stop double-setting the font size and the warnings stop
      
      This may be system-specific because I don't see where we are setting the font's point size. I will test this on a few different systems (I haven't yet) and I hope others will test it on their system!
      
      Note that this is easiest to test when applied on top of D15979 so you can scroll up to cause more messages to be constructed
      
      Test Plan:
      Before patch: Experience many warnings when using the SMS app
      After patch: Experience fewer (0?) warnings when using the SMS app
      
      Reviewers: #kde_connect, apol
      
      Reviewed By: #kde_connect, apol
      
      Subscribers: kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D16769
      73191d85