1. 21 Jul, 2019 2 commits
  2. 19 Jul, 2019 2 commits
    • Simon Redman's avatar
      [SMS App] Handle addresses for multitarget messages · edee0e0e
      Simon Redman authored
      ## Summary
      
      Upgrade the SMS App to handle multitarget addresses in the "addresses" field of a message and drop usage of the "address" field
      
      Also note that this has all the commits from kde/kdeconnect-kde!97, but I will rebase those away once that patch is landed
      
      Bonus: Image composition for multitarget conversations
      
      ## Test Plan
      - Apply Android-side patch kde/kdeconnect-android!80
      - Launch SMS App
      - Notice that you can see all the recipients of multitarget messages. (Replying still not supported, but might get implemented as part of fixing replying to single-target messages)
      edee0e0e
    • Simon Redman's avatar
      [SMS App] Basic plain-text MMS support · ee9547ed
      Simon Redman authored
      ## Summary
      
      Desktop companion to kdeconnect-android!78
      
      Give desktop SMS app a basic understanding of the MMSes coming from Android:
      - Show a fake body if we get an attachment we can't display (for now, any attachment)
      - Display a fake contact header for multi-target messages since Android does not yet export multi-target address information
      - Disable attempting to reply to multi-target messages
      
      BUG: 398889
      
      ## Test Plan
      ### Before:
      MMS messages were silently dropped, meaning:
       - Group MMS conversations were not visible
       - Single-target conversations with the most-recent message an MMS were not visible
      
      ### After:
       - Install kdeconnect-android!78
       - Multi-target conversations are displayed (kind of ugly, since they have no contact information
       - Single-target conversations which end with an MMS are displayed
       - Plain-text MMS is displayed nicely
       - MMS attachments don't show
         - MMS which are only an attachment with no body are displayed with a dummy body
      ee9547ed
  3. 02 Jun, 2019 1 commit
  4. 01 Jun, 2019 1 commit
  5. 31 May, 2019 1 commit
  6. 30 May, 2019 1 commit
  7. 30 Apr, 2019 1 commit
  8. 23 Mar, 2019 1 commit
  9. 27 Feb, 2019 1 commit
    • Simon Redman's avatar
      [SMS App] Add highlighting to ConversationList view · 1ec20886
      Simon Redman authored
      Summary: Let the ListView use its default highlighting (did I not notice before?) and keep the currently-selected chat highlighted at all times
      
      Test Plan:
       - Launch app
       - Use mouse or arrow keys to select a conversation. The highlight should follow the selected conversation
      
      Reviewers: #kde_connect, apol
      
      Reviewed By: #kde_connect, apol
      
      Subscribers: apol, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D17612
      1ec20886
  10. 24 Jan, 2019 1 commit
    • Simon Redman's avatar
      Add dependency on kirigami to SMS app · 3b92b0de
      Simon Redman authored
      Summary:
      Resolves Bug 401255
      
      Bonus: Disable some very noisy debugging from the SMS app
      
      Test Plan:
       - Build KDE Connect with or without Kirigami
         - Verify successful build with no complaints about Kirigami
       - Build KDE Connect's Messenger:
         - Without Kirigami: Verify that CMake warns that Kirigami is not found
         - With Kirigami: Verify that app launches successfully
      
      Reviewers: #kde_connect, nicolasfella
      
      Reviewed By: #kde_connect, nicolasfella
      
      Subscribers: apol, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D17572
      3b92b0de
  11. 23 Jan, 2019 1 commit
    • Simon Redman's avatar
      [SMS App] Make sms app not crash when conversation is selected with no devices connected · a14b39d5
      Simon Redman authored
      Summary: This patch fixes T10184 and stops the SMS app from crashing when a conversation is selected but no devices are connected. It also allows the SMS app to access the cached messages in the ConversationsDbusInterface so the app is still slightly useful even when the device is disconnected.
      
      Test Plan:
      - Open sms app
      - Open a few conversations
      - Disconnect phone (Force close app?)
      - Re-open a conversation which was previously opened
        - Verify that the messages appear. It is possible to scroll up to view any older cached messages too!
      - Open a conversation which was not opened previously
        - Verify that a single messages is shown (since this was the only one in cache, from populating the list of all conversations)
        - Verify that attempting to scroll this conversation does nothing, but also does not crash the app
      
      Note: Opening the app with no phone connected will cause it to lose its handle on the deviceId, so it can't spawn a new Dbus interface, so it will remain blank and empty. Solving that is a project for another day.
      
      Reviewers: #kde_connect
      
      Reviewed By: #kde_connect
      
      Subscribers: apol, nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Maniphest Tasks: T10184
      
      Differential Revision: https://phabricator.kde.org/D17634
      a14b39d5
  12. 11 Oct, 2018 1 commit
  13. 08 Oct, 2018 2 commits
    • Simon Redman's avatar
      [Desktop] Update conversation list when a new message arrives · a7db3ab5
      Simon Redman authored
      Summary:
      When a new message is delivered, the conversation list should update by changing the preview text and re-sorting the conversations
      
      Bonus bug discovered and fixed:  previously, when the conversations list was being populated, it made a request for the first message in every conversation. This would be fine if the conversationdbusinterface pulled from local cache. However, this actually triggers a request to the phone for *every* conversation.
      
      This should be handled differently in conversationdbusinterface's requestConversation as well, but that's a project for a later day (TODO comments added)
      
      Test Plan:
       - Launch SMS app
       - Verify conversations list appears
       - Verify lack of massive stream of debug output indicating lots of messages for the wrong conversation are being received
       - Verify that opening a particular conversation shows the messages after a short delay while the backend fetches the content from the phone
       - Verify that receiving a new message into an existing conversation updates the conversation list
      
      Reviewers: #kde_connect, nicolasfella
      
      Reviewed By: #kde_connect, nicolasfella
      
      Subscribers: nicolasfella, apol, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D15608
      a7db3ab5
    • Simon Redman's avatar
      [SMS App] Improve contact matching · ab33cce5
      Simon Redman authored
      Summary: Improve contact matching by checking if the requested address ends with a candidate phone number, or vice-versa
      
      Test Plan:
      Check that *all* conversations which correspond to a contact are matched
       - All of mine match. If someone finds one which doesn't, I will need the particulars...
      
      Reviewers: #kde_connect, nicolasfella
      
      Reviewed By: #kde_connect, nicolasfella
      
      Subscribers: nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D15992
      ab33cce5
  14. 07 Oct, 2018 2 commits
  15. 09 Jun, 2018 1 commit
    • Aleix Pol Gonzalez's avatar
      (WIP) Upgrade Telephony plugin to read SMS history (KDE side) · 31e93ef7
      Aleix Pol Gonzalez authored
      Summary:
      For real usecases of SMS support, we will almost always need access to the message history in some way
      
      Specifically resolve T8338
      
      Incidentally resolve T6651 since Telephony shall no longer create a notification
      
      Test Plan:
      Setup:
      - Build corresponding Android-side diff (D11698)
      - Build this diff
      
      Step 1: Does anything at all work?
      - Put a breakpoint in the handleBatchMessages method of the telephony plugin, ideally after constructing a Message object
      - Use DBus to poke /modules/kdeconnect/devices/<deviceID>/telephony.requestAllConversations()
      - Verify that the constructed Message is one you sent or received and that it is the most recent in the corresponding conversation
      
      Step 2: DBus
      - Open the Interface org.kde.kdeconnect.device.conversations of /modules/kdeconnect/devices/<deviceId>
      - Poke activeConversations and verify an empty array is returned
      - Poke requestAllConversationThreads
      - Poke activeConversations and verify that a list of numbers has been returned. These are conversationIds
      - Use a conversationId to call getFirstFromConversation
        - Verify that the returned Message object is one which you recognize
        - Note that if the message is an MMS it will be blank and meaningless. Try a different conversationId. MMS support "coming soon!"
      
      Step 3: SMS App
      - Use ccmake (or similar) to set SMSAPP_ENABLE to ON
      - Build the project
      - Run ./bin/kdeconnect-sms
      - Verify that the app shows a list of everyone you have an SMS conversation with (MMS messages are stripped out)
        - If you have the Contacts plugin working, verify that most contacts have their name and photo instead of their phone number
      
      Reviewers: #kde_connect, nicolasfella, apol
      
      Reviewed By: #kde_connect, nicolasfella, apol
      
      Subscribers: andyholmes, apol, nicolasfella, #kde_connect
      
      Tags: #kde_connect
      
      Maniphest Tasks: T8338, T6651
      
      Differential Revision: https://phabricator.kde.org/D11854
      31e93ef7