1. 08 Sep, 2019 1 commit
  2. 14 Aug, 2019 1 commit
  3. 01 Aug, 2019 1 commit
  4. 29 Jul, 2019 1 commit
  5. 20 Jul, 2019 1 commit
  6. 05 Jul, 2019 1 commit
    • Sandro Knauß's avatar
      fix race condition on tests. · f044384c
      Sandro Knauß authored
      The test expects the SSL server socket to be encrypted, but was
      not waiting for it to happen.
      
      Use a QSignalSpy to wait for the signal that ensures us we can go ahead.
      f044384c
  7. 18 Jun, 2019 1 commit
  8. 10 Jun, 2019 1 commit
  9. 07 Jun, 2019 1 commit
  10. 05 Jun, 2019 3 commits
    • Simon Redman's avatar
      Fix LanLinkProviderTest on Windows · c7579eb1
      Simon Redman authored
      ## Summary
      LanLinkProviderTest fails on Windows. This patch fixes that.
      
      I believe the root cause is that we are using a shared UDP socket to listen for identity broadcasts both in the LanLinkProvider and in the test. Apparently this works on Linux, but on Windows the LanLinkProvider picks up its own identity packet and pairs with itself.
      
      This patch gives a parameter to LanLinkProvider to allow it to listen and broadcast on different ports, then uses that ability in the test to make the test pass on Windows.
      
      ## Test Plan
      
      ### Before:
      lanlinkprovider test fails, first because it can't bind its UDP listener socket, and then because Windows seems to handle shared sockets differently than Linux, so the UDP broadcasts were not reaching the test's listener.
      
      ### After:
      lanlinkprovider test seems to pass reliably both in my Windows VM and in the CI
      c7579eb1
    • Simon Redman's avatar
      Refactor testdevice · 9453e640
      Simon Redman authored
      9453e640
    • Simon Redman's avatar
      Make testsslsocketlistener properly timeout · 673c3ced
      Simon Redman authored
      673c3ced
  11. 02 Jun, 2019 2 commits
    • Simon Redman's avatar
      ## Summary · 24ab6d15
      Simon Redman authored
      pluginloadtest and sendfiletest are crashing. This patch fixes that by allowing Daemon::init() to be called from TestDaemon
      
      ## Test Plan
      
      ### Before:
      Both tests are crashing because it is not able to find any devices. It is not able to find any devices because the LanLinkProvider is not being added because Daemon::init() is not being called.
      
      ### After:
      pluginloadtest and sendfiletest pass
      24ab6d15
    • Simon Redman's avatar
      e8a2e814
  12. 31 May, 2019 2 commits
  13. 30 May, 2019 1 commit
  14. 08 May, 2019 1 commit
  15. 05 May, 2019 1 commit
  16. 30 Apr, 2019 1 commit
  17. 23 Mar, 2019 1 commit
  18. 14 Mar, 2019 1 commit
  19. 12 Feb, 2019 7 commits
  20. 30 Nov, 2018 1 commit
    • Erik Duisters's avatar
      Combine multiple upload jobs into a single KCompositeJob so only 1 notification will be shown · b6c15289
      Erik Duisters authored
      Summary:
      Combine multiple upload jobs for files into a single KCompositeJob so only 1 notification will be shown
      Includes changes introduced in D16279
      
      Test Plan:
      1. Share of multiple files is performed using 1 composite job
      
         Setup:
      	- Select multiple (big) files in dolphin and share with an Android device
         Result:
      	- The files will be transferred using 1 CompositeUploadJob and showing only 1 notification
      
      2. Share of file while another share is already running adds job to existing composite job
      
         Setup:
      	- Select multiple (big) files in dolphin and share with an Android device
      	- Share an additional file with the same Android device
         Result:
      	- The files are all transferred using 1 CompositeUploadJob and showing only 1 notification
      	- The notification is updated after adding the last file
      
      3. Other packets are transmitted as usual
      
         Setup:
              - Setup sharing desktop notification with device
      	- Share a big file with an Android device
      	- Generate a desktop notification (eg. sending or receiving an email)
      
         Result:
      	- Notification packet is send immediately
      
      Reviewers: #kde_connect, nicolasfella, albertvaka
      
      Reviewed By: #kde_connect, albertvaka
      
      Subscribers: albertvaka, apol, nicolasfella, broulik, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D17081
      b6c15289
  21. 26 Nov, 2018 1 commit
  22. 07 Oct, 2018 1 commit
  23. 15 Aug, 2018 1 commit
    • Nicolas Fella's avatar
      [WIP] Get rid of DownloadJob · 1d1fdf8e
      Nicolas Fella authored
      Summary:
      It doesn't do much and can be inlined into LanDeviceLink.
      
      TODO: Figure out why sendfiletest fails
      
      Test Plan: Receiving files still works
      
      Reviewers: #kde_connect, albertvaka
      
      Reviewed By: #kde_connect, albertvaka
      
      Subscribers: albertvaka, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D14597
      1d1fdf8e
  24. 03 Aug, 2018 1 commit
  25. 02 Aug, 2018 1 commit
  26. 12 Jul, 2018 1 commit
    • Nicolas Fella's avatar
      Fix crashing devicetest · 48108cd3
      Nicolas Fella authored
      Summary:
      When running the test m_impl will be nullptr leading to a crash. This is because when running as a test no platform is loaded.
      The fancy way to solve this would be to have a TestImpl, but I think this is enough.
      
      Test Plan: Test passes now
      
      Reviewers: #kde_connect, apol
      
      Reviewed By: #kde_connect, apol
      
      Subscribers: kdeconnect, #kde_connect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D13629
      48108cd3
  27. 18 Mar, 2018 1 commit
    • Adam Pigg's avatar
      Add a method for creating simple notifications · ebc316f7
      Adam Pigg authored
      Summary:
      Add a helper function to the daemon interface, which must be subclassed
      by the implementations, which creates a simple notification.
      
      For more complex needs, involving interacting with the notification, it
      will still be nescessary to use KNotification directly, but this allows
      for other future implementations to create a simple notification without
      ifdef'ing the code.
      
      Reviewers: kdeconnect, apol
      
      Reviewed By: apol
      
      Subscribers: kdeconnect
      
      Differential Revision: https://phabricator.kde.org/D11104
      ebc316f7
  28. 17 Mar, 2018 1 commit
    • Friedrich W. H. Kossebau's avatar
      Clean-up requirements: cmake 3.0, qt 5.7, use min versions, deduplicate KF5 · bb3ab8b6
      Friedrich W. H. Kossebau authored
      Summary:
      * cmake 2.8.12 is really outdated, 3.0 is minimum in plasma & kf5
      * cmake_minimum_required should be at begin of toplevel CMakeLists.txt
      * bump qt version to 5.7, matching the min Qt version of kf5 5.42
      * with ecm being part of kf5 since early versions, share ${KF5_MIN_VERSION}
      * use QT_MIN_VERSION & KF5_MIN_VERSION also for separate find_package calls
      * deduplicate all KF5 components searched for in unconditionally included
        subdirs
      
      Test Plan: Still configures and builds with all options OFF & ON
      
      Reviewers: #kde_connect, nicolasfella
      
      Reviewed By: #kde_connect, nicolasfella
      
      Subscribers: nicolasfella
      
      Differential Revision: https://phabricator.kde.org/D11418
      bb3ab8b6
  29. 05 Mar, 2018 1 commit
  30. 03 Sep, 2017 1 commit
    • Jean Vincent's avatar
      Make member variable names, & placement and * placement more coherent · 72535ecf
      Jean Vincent authored
      Summary:
      Change all member variables to the form m_fooBar because it is the preferred form in Qt (it was half and half between this and mFooBar, and a minority didn't have anything).
      Place all references and pointers on the side of the type since it is the majority.
      
      Basically:
       - mFoo -> m_foo
       - foo -> m_foo (if it is a member variable)
       - Type &ref -> Type& ref
       - Type *ptr -> Type* ptr
      
      Reviewers: #kde_connect, nicolasfella, albertvaka
      
      Reviewed By: #kde_connect, nicolasfella, albertvaka
      
      Subscribers: albertvaka, #kde_connect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D7312
      72535ecf