1. 10 Jun, 2019 1 commit
  2. 02 Jun, 2019 1 commit
    • Simon Redman's avatar
      ## Summary · 24ab6d15
      Simon Redman authored
      pluginloadtest and sendfiletest are crashing. This patch fixes that by allowing Daemon::init() to be called from TestDaemon
      
      ## Test Plan
      
      ### Before:
      Both tests are crashing because it is not able to find any devices. It is not able to find any devices because the LanLinkProvider is not being added because Daemon::init() is not being called.
      
      ### After:
      pluginloadtest and sendfiletest pass
      24ab6d15
  3. 23 Mar, 2019 1 commit
  4. 03 Sep, 2017 1 commit
    • Jean Vincent's avatar
      Make member variable names, & placement and * placement more coherent · 72535ecf
      Jean Vincent authored
      Summary:
      Change all member variables to the form m_fooBar because it is the preferred form in Qt (it was half and half between this and mFooBar, and a minority didn't have anything).
      Place all references and pointers on the side of the type since it is the majority.
      
      Basically:
       - mFoo -> m_foo
       - foo -> m_foo (if it is a member variable)
       - Type &ref -> Type& ref
       - Type *ptr -> Type* ptr
      
      Reviewers: #kde_connect, nicolasfella, albertvaka
      
      Reviewed By: #kde_connect, nicolasfella, albertvaka
      
      Subscribers: albertvaka, #kde_connect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D7312
      72535ecf
  5. 21 Jul, 2017 1 commit
    • Jean Vincent's avatar
      Replace Q_FOREACH with C++11 range-for · c864267f
      Jean Vincent authored
      Summary:
      The use of Q_FOREACH is advised against (https://doc.qt.io/qt-5/qtglobal.html#Q_FOREACH) since Qt 5.7 and will eventually be removed from Qt.
      
      I replaced all occurrences with the range-for loop introduced in C++11 (except for the one in daemon.cpp in deviceIdByName which might have a bug / typo in it).
      
      I added const to the container or casted it with qAsConst when appropriate to avoid unnecessary copies.
      
      (This is my first submission. I did all the unit tests, and they all passed but I don't know how to show it here.)
      
      Reviewers: #kde_connect, nicolasfella, apol
      
      Reviewed By: #kde_connect, nicolasfella, apol
      
      Subscribers: albertvaka, apol, nicolasfella
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D6724
      c864267f
  6. 26 Nov, 2016 1 commit
  7. 06 Jul, 2016 1 commit
    • Aleix Pol Gonzalez's avatar
      Make capabilities static · 81634303
      Aleix Pol Gonzalez authored
      As discussed with Albert, move the population of capabilities into the
      identity package, making them static along the execution of the link.
      
      When we receive the identityPackage, we collect the plugins we can use with
      the device and stick to those. This should simplify the implementation and
      remove the possibility to lose packages if packages are received before the
      capabilities are processed in the former approach.
      
      REVIEW: 128386
      81634303
  8. 21 Jun, 2016 1 commit
  9. 05 Jun, 2016 1 commit
    • Aleix Pol Gonzalez's avatar
      Fix tests · 55c60146
      Aleix Pol Gonzalez authored
      In case we need to discover the device (i.e. we're running the test in a
      clean environment) we need to acquire the discovery mode.
      Only initialize the test after setting the test mode enabled, so the
      loopback is enabled.
      55c60146
  10. 05 Dec, 2015 1 commit
  11. 01 Dec, 2015 1 commit
  12. 12 Sep, 2015 1 commit
  13. 09 Sep, 2015 1 commit
  14. 08 Sep, 2015 3 commits
  15. 07 Sep, 2015 1 commit