Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
K
KDiff3
Project overview
Project overview
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
5
Issues
5
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
KDE
KDiff3
Commits
1108b71d
Commit
1108b71d
authored
Sep 22, 2019
by
Michael Reeves
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix clang-tidy/gcc warings
parent
64a06257
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
3 additions
and
3 deletions
+3
-3
kdiff3fileitemactionplugin/kdiff3fileitemaction.h
kdiff3fileitemactionplugin/kdiff3fileitemaction.h
+1
-1
src/SourceData.h
src/SourceData.h
+1
-1
src/diff.h
src/diff.h
+1
-1
No files found.
kdiff3fileitemactionplugin/kdiff3fileitemaction.h
View file @
1108b71d
...
...
@@ -49,7 +49,7 @@ private Q_SLOTS:
private:
QList
<
QUrl
>
m_list
;
QWidget
*
m_pParentWidget
;
QWidget
*
m_pParentWidget
=
nullptr
;
//KFileItemListProperties m_fileItemInfos;
};
#endif
src/SourceData.h
View file @
1108b71d
...
...
@@ -116,7 +116,7 @@ class SourceData
};
FileData
m_normalData
;
FileData
m_lmppData
;
QTextCodec
*
m_pEncoding
;
QTextCodec
*
m_pEncoding
=
nullptr
;
};
#endif // !SOURCEDATA_H
src/diff.h
View file @
1108b71d
...
...
@@ -258,7 +258,7 @@ class Diff3LineList : public std::list<Diff3Line>
//TODO: Add safety guards to prevent list from getting too large. Same problem as with QLinkedList.
int
size
()
const
{
if
(
std
::
list
<
Diff3Line
>::
size
()
>
std
::
numeric_limits
<
int
>::
max
())
if
(
std
::
list
<
Diff3Line
>::
size
()
>
(
size_t
)
std
::
numeric_limits
<
int
>::
max
())
//explicit cast to silence gcc
{
qCDebug
(
kdiffMain
)
<<
"Diff3Line: List too large. size="
<<
std
::
list
<
Diff3Line
>::
size
();
Q_ASSERT
(
false
);
//Unsupported size
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment