Commit 80a33683 authored by Michael Reeves's avatar Michael Reeves

Don't use inline on pure virtual functions

Some compilers are picker then others about this but it really doesn't make
sense. Technically you are declaring a function without defining it do to
inline's new meaning. clang/llvm depending on version warns about or
completely ignores the issue. MSVC throws a link time error.
parent 1835567d
Pipeline #9315 passed with stage
in 8 minutes and 14 seconds
......@@ -118,7 +118,3 @@ void DefaultCommentParser::processLine(const QString &line)
processChar(line, '\n');
}
void DefaultCommentParser::removeComments()
{
}
......@@ -25,11 +25,10 @@
class CommentParser
{
public:
inline virtual void processChar(const QString &line, const QChar &inChar) = 0;
inline virtual void processLine(const QString &line) = 0;
inline virtual bool inComment() const = 0;
inline virtual bool isPureComment() const = 0;
inline virtual void removeComments() = 0;
virtual void processChar(const QString &line, const QChar &inChar) = 0;
virtual void processLine(const QString &line) = 0;
virtual bool inComment() const = 0;
virtual bool isPureComment() const = 0;
virtual ~CommentParser(){};
};
......@@ -44,7 +43,6 @@ class DefaultCommentParser : public CommentParser
inline bool inComment() const override { return mCommentType != none; };
inline bool isPureComment() const override { return mIsPureComment == yes; };
inline void removeComments() override;
protected:
friend class CommentParserTest;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment