Move missplaced comment, remove unneed &'s

Revert broken check for matching starting characters.
Add emergancy back stop in calcDiff  to main loop. We should never reach
this condition. However we must garentee this code never goes into an
infenite loop regardlless of any pontental bug or unexepected input.

BUG: 410007
FIXED-IN:1.8.2

CCBUG:410008

kdiff3 fails to close files properly leading to stability and speed issues.

Reviewers: mreeves

Reviewed By: mreeves

Differential Revision: https://phabricator.kde.org/D22294

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Mouse or key events can be sent before the scrollbars are setup properly.

BUG: 407829
FIXED-IN:1.8.2

Summary:
Fix filter so files can be actually listed and opened from file dialog.
On occasion, make filter translatable.

Test Plan: Run `kdiff3`, click "File…" button, try to select any file in dialog.

Reviewers: mreeves

Reviewed By: mreeves
This issue does not seem to impact my test machine but the change causes no problems.


Differential Revision: https://phabricator.kde.org/D21885

m_pFileAccess is always set to null if no parent is present.

EventLoops are a very expensive use of stack memmory. Additionally
deep nesting as was done in ProgressDialog can cause all sorts fun
problems. Only one loop is needed for the dialog itself to emulate exec.
To reenter it use EventLoop::ProcessEvents not a new event loop. Cancel now works without crashing.

BUG: 405918
FIXED-IN: 1.8.2

ecm_add_app_icon must be in the same scope as the corrisponding add_executable

HOTFIX
BUG: 407562
FIXED-IN:1.8.1

Drop ts.readAll() elimates redundant read of file data.