Window icon changes when tab key is pressed - (patch included)
I noticed that after running konsole for a while, the window icon for konsole was changing to a different one. Debugging narrowed it down to the action of pressing the tab key at the prompt, which triggers the "NOTIFYBELL" state in Session::activityStateSet, which is what causes the icon to change from the terminal icon to "preferences-desktop" (and not "preferences-desktop-notification-bell", which is what SessionController.cpp is supposed to set _bellIcon to). The icon never changes back from that.
I solved it by changing the line in SessionController::updateSessionIcon() where it compares (_session->iconName() == QStringLiteral("utilities-terminal")) and then sets _sessionIconName = QString(). I just changed the == to !=.
But I'm not sure if this is the best approach. I attached a patch of my solution.0001-fix-window-icon-changes-after-pressing-tab-key.patch
The window icon now changes after pressing the tab key (the tab icon does not though), but it changes back to the expected terminal icon after opening a new tab or pressing a different key.
I also noticed that my fix brought the tab icons back, which were not present before (at all).