• Jiří Paleček's avatar
    Fix the fallback code used when restoring session fails · 656f6804
    Jiří Paleček authored
    Summary:
     When restoring session in Konsole fails, the fallback code should
     create a default view and session instead. However, the code omitted
     adding this view to the container, which makes
    
     - the window black (or grey in my case), see
       https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=935031
    
     - konsole crash later, when you add a new tab and close it, because
       code in ViewManager expects TerminalDisplays to be children of
       ViewSplitter, which is not the case
    
     This fix adds the view to activeController(), just like every other
     code that creates TerminalDisplay.
    
    Test Plan:
     1. find a session in your $HOME/.config/session/ from konsole before 19.08
     2. konsole -session xxxx (where xxxx are the numbers in the session file)
        -> there should be a konsole window with usable terminal
     3. add a new tab with C-S-T and close it
        ->there should be no crash
    
    Reviewers: hindenburg, #konsole
    
    Reviewed By: hindenburg, #konsole
    
    Subscribers: tcanabrava, konsole-devel
    
    Tags: #konsole
    
    Differential Revision: https://phabricator.kde.org/D23601
    656f6804
Name
Last commit
Last update
data Loading commit data...
desktop Loading commit data...
doc Loading commit data...
src Loading commit data...
tests Loading commit data...
tools Loading commit data...
.arcconfig Loading commit data...
.editorconfig Loading commit data...
.gitignore Loading commit data...
.krazy Loading commit data...
CMakeLists.txt Loading commit data...
COPYING Loading commit data...
COPYING.DOC Loading commit data...
COPYING.LIB Loading commit data...
Mainpage.dox Loading commit data...
README Loading commit data...
konsole.categories Loading commit data...