Skip to content

Fix pen tilt and rotation for Android

Max Thomas requested to merge shinyquagsire/krita:shinyquagsire/feat-android-pen-tilt-rot into master

Fixed pen tilt and rotation for Android builds. A patch for Qt5 is provided which allows the fix to be patched locally until the change is merged into Qt5 and Krita moves to a version which has the patch commit. The in-progress Qt changes can be seen at https://codereview.qt-project.org/c/qt/qtbase/+/285998.

Test Plan

Changes were tested locally on a Surface Go running Chrome OS R76, via ARC. A video of the changes running can be seen here, tested with a rotation-active marker brush. I'm not certain if there are any unit tests for this, but it's a Qt5 patch so I'm not sure it's relevant here given that Krita handled everything fine on its end.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports