Skip to content

WIP: Fonkle/clonetool 4.2.9 - Needs Review

Fred Fonkle requested to merge fonkle/krita:fonkle/clonetool_4.2.9 into master

I have rebased the implementation of the Clone Stamp Tool to the Krita v4.2.9 tag since master (4.3.0 prealpha) got refactored and some parts were broken. Brush presets are isolated so the Clone Stamp Tool only shows Clone Brush Presets in the 'Edit Brush Settings' and 'Choose brush preset' panels. Also, a separate 'previous brush' is being stored the Clone Stamp Tool so [NUMPAD /] switches between the previous and the current Clone Brush.

I would like to know if the initial implementation could -eventually- be included as a feature in Krita.

Test Plan

I have tested the changes in Kubuntu 19.10. Could also test in Windows or any Virtualbox platform. I am still learning how the unit tests work (sry).

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports