Skip to content
Commit 217074f3 authored by Dmitry Kazakov's avatar Dmitry Kazakov
Browse files

BUG:404975 Fix hard to select color in vector objects

While trying to fix this, I noticed some of the cause of the "color fighting" was because of the large amount of signals that were being emitted and processed with the stroke and fill widgets for vector controls.

I tried to help limit all these signals with a couple compressors on the fill and stroke config widgets.

After adding those compressors, the state of the widgets were not updating right when changing selection. I then spent some time modifying the logic to get the tool options for the stroke and fill to update correctly.

One thing to point out that I changed was how a "None" fill is calculated. Previously "None" was only calculated if a stroke object didn't exist (see the wrapper.type() ).

I also modified the UI to select "none" type if the border size is set to 0. You cannot select a "0" border width if you have a solid border selected on the UI now. It will only go down to 1px now. The UI seemed to get in an odd state if you made a border 0px, then de-selected the object, then re-select it.

BUG:404975
Differential Revision: https://phabricator.kde.org/D20500
See merge request kde/krita!10
parents 2239e955 c2c5fdcc
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment