Skip to content

Fix opacity change showing on brush preview BUG:411989

Scott Petrovic requested to merge (removed):petrovic/brush-preview-opacity into master

Fixes this bug. https://bugs.kde.org/show_bug.cgi?id=411989

The opacity wasn't passed into the preview brush stroke, so it was being ignored. The clone() function doesn't do a very deep clone, so that is probably why it didn't pick it up.

Test Plan

Open the brush editor. Go to the Opacity area. Reduce the strength for the opacity. Watch the brush preview update with the correct opacity.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports