Skip to content

Fix wrong aspect ratio on svg Load

Ivan Yossi requested to merge ivany/krita:407425_svgSize into master

We incorrectly treated the absence of preserveAspectRatio as set to "none". Svg specification states the initial value of this property should be "xMidYMid meet". in case there is no property we now use the initial value instead of ignoring.

Spec page: https://www.w3.org/TR/SVG/coords.html#PreserveAspectRatioAttribute

Updated TestSvgParser cases to use "none" so the resulting shape corresponds to the old behaviour.

BUG:407425

Test Plan

Test units run, test files and other files load correctly.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by Ivan Yossi

Merge request reports