Skip to content

Disable System Monitor Profile on non KisColorManager enabled platforms

Ivan Yossi requested to merge ivany/krita:407224_colorDisplay into master

I did: removed and disabled the checkbox "Use System Monitor Profile" on macOS and windows systems. This was reported to be a problem to correctly set how color is perceived.

On macOS having this checkbox "on" creates color differences between krita and the OS

BUG:407224

Test Plan

I tested on macOS 2 monitors, with the checkbox disabled I was able to pick the color profiles to make apparent color match on both monitors to what the system shows.

From what we discussed on IRC, windows also does not use this checkbox, but can someone confirm this?

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • [NA] I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

This template is so complete, mabe too much for this little change. :]

Merge request reports