Skip to content

416241 blur filter

Ivan Yossi requested to merge ivany/krita:416241_blurFilter into master

This fixed how blur filter uses the values from the interface.

Fixes BUG:416241

In short:

  • Adjusted aspectRatio to give correct height everytime
  • Made the blur direction you get consistent with gaussian blur (consistency)
  • Adjusted max values in spinboxes up to 1000
  • Fixed Strenght spinbox (before the effect was either on or off)

Some explanation:

aspectRatio was reversed, this caused a zero height kernel to be created. fixing this made the vetical and horizontal made the same exact amount of blur (before vertical made the image much more blury than the horizontal spinbox). But the amount was much reduced. To allow the user to get the same effect as previous blur the values in horiz and vertical spinboxes can go up to 1000.

Strength spinbox was broken, it only changed between two states. if 0 it was Off and if value 1 to 100 strength was maxed. Now the spinbox will work as applied strength percentage.

Changes in kis_convolution_worker_spatial.h avoid an underflow when height is equal to 0. (this no longer happens from blur filter)

Merge request reports