Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Krita
Krita
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Merge Requests 27
    • Merge Requests 27
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Jobs
  • Commits
  • KDE
  • KritaKrita
  • Merge Requests
  • !44

Open
Opened Jun 15, 2019 by Boudewijn Rempt@rempt
  • Report abuse
Report abuse

WIP: Save dialog and option widget state in a generic way

This is an attempt to get rid of all the custom code we have everywhere that saves the state of dialogs and tool option widgets to kritarc. It simply iterates over the child widgets of widget and when it encounters one that it knows how to save the state for, it saves it. Restoring works similar, but it's possible to override restore values.

Todo:

  • port all our tools
  • check whether this breaks the math-enabled edit widgets
  • add more widgets we can save the state of
  • make sure that in every place where we use this widget, the widgets we want to save the state of have object names.

See also https://bugs.kde.org/show_bug.cgi?id=408601, for instance

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b "rempt/407381-dialog-state-saver" "origin/rempt/407381-dialog-state-saver"

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "rempt/407381-dialog-state-saver"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 3
  • Commits 7
  • Changes 15
Assignee
Assign to
Krita 4.3
Milestone
Krita 4.3
Assign milestone
Time tracking
1
Labels
Needs Changes
Assign labels
  • View project labels
Reference: kde/krita!44