Commit 147add2e authored by Igor Kushnir's avatar Igor Kushnir

Don't crash after Cancel in Job Already Running dialog

When a user Execute-Launches an application a second time while the
previously launched instance of this application is still running, the
"Job Already Running" dialog appears with 3 buttons. If a user clicks
the Cancel button, a NativeAppJob kills itself Quietly. This
NativeAppJob belongs to an ExecuteCompositeJob, which is not notified
when a subjob is killed Quietly. So the ExecuteCompositeJob keeps
waiting for it to finish. When this waiting ExecuteCompositeJob is
killed (e.g. via "Stop All" button or on KDevelop exit), it attempts to
kill the subjob it believes is still running, but which in fact is long
since destroyed. This usually causes a segmentation fault.

Aleix Pol fixed a similar crash when the "Kill All Instances" button in
the "Job Already Running" dialog is clicked in

BUG: 399511, 416874
FIXED-IN: 5.6.1
parent a3db62a1
Pipeline #35361 failed with stage
in 60 minutes and 14 seconds
......@@ -176,7 +176,7 @@ void NativeAppJob::start()
default: // cancel starting a new job
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment