Commit 5a2ad59c authored by Milian Wolff's avatar Milian Wolff
Browse files

Add FIXME comment about unsafe API in CodeModel::items

The function does mutex locking internally and then returns
a raw pointer which could become invalid without the mutex being
locked. This should be revised eventually.
parent ad22653a
......@@ -353,6 +353,7 @@ void CodeModel::removeItem(const IndexedString& file, const IndexedQualifiedIden
});
}
// FIXME: this API is unsafe, we should return a KDevVarLengthArray of values instead
void CodeModel::items(const IndexedString& file, uint& count, const CodeModelItem*& items) const
{
ifDebug(qCDebug(LANGUAGE) << "items" << file.str(); )
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment