Commit cb9509b5 authored by Milian Wolff's avatar Milian Wolff
Browse files

Use fully qualified signatures to fix old-school signal/slot connect

Fixes warnings and totally broken ProjectSet::trackProjectFiles impl:

```
QObject::connect: No such signal CMakeManager::fileAdded(ProjectFileItem*)
QObject::connect: No such signal CMakeManager::fileRemoved(ProjectFileItem*)
QObject::connect: No such signal CMakeManager::fileRenamed(Path,ProjectFileItem*)
```
parent c22cd775
Pipeline #95866 canceled with stage
......@@ -312,12 +312,12 @@ void ProjectSet::trackProjectFiles(const IProject* project)
auto* fileManager = dynamic_cast<QObject*>(project->projectFileManager());
if (fileManager) {
// can't use new signal/slot syntax here, IProjectFileManager is no a QObject
connect(fileManager, SIGNAL(fileAdded(ProjectFileItem*)),
this, SLOT(fileAdded(ProjectFileItem*)));
connect(fileManager, SIGNAL(fileRemoved(ProjectFileItem*)),
this, SLOT(fileRemoved(ProjectFileItem*)));
connect(fileManager, SIGNAL(fileRenamed(Path,ProjectFileItem*)),
this, SLOT(fileRenamed(Path,ProjectFileItem*)));
connect(fileManager, SIGNAL(fileAdded(KDevelop::ProjectFileItem*)), this,
SLOT(fileAdded(KDevelop::ProjectFileItem*)));
connect(fileManager, SIGNAL(fileRemoved(KDevelop::ProjectFileItem*)), this,
SLOT(fileRemoved(KDevelop::ProjectFileItem*)));
connect(fileManager, SIGNAL(fileRenamed(KDevelop::Path, KDevelop::ProjectFileItem*)), this,
SLOT(fileRenamed(KDevelop::Path, KDevelop::ProjectFileItem*)));
}
}
}
......
......@@ -93,9 +93,9 @@ protected:
void trackProjectFiles(const IProject* project);
protected Q_SLOTS:
void fileAdded(ProjectFileItem*);
void fileRemoved(ProjectFileItem* file);
void fileRenamed(const Path& oldFile, ProjectFileItem* newFile);
void fileAdded(KDevelop::ProjectFileItem*);
void fileRemoved(KDevelop::ProjectFileItem* file);
void fileRenamed(const KDevelop::Path& oldFile, KDevelop::ProjectFileItem* newFile);
protected:
virtual bool include(const IndexedString& /*url*/) const { return true; }
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment