Commit cf4d309c authored by Igor Kushnir's avatar Igor Kushnir Committed by Nicolás Alvarez
Browse files

Don't warn about "recursive variable expansion"

An environment profile variable often refers to a system environment
variable of the same name. For example, each variable definition in
KDevelop's own generated build/prefix.sh does that. System environment
variables, such as $QT_PLUGIN_PATH and $QML2_IMPORT_PATH, are often
unset. This warning is a false positive most of the time.
parent 86af2d43
...@@ -231,7 +231,8 @@ static QString expandVariable(const QString &key, const QString &value, ...@@ -231,7 +231,8 @@ static QString expandVariable(const QString &key, const QString &value,
if (environment.contains(variable)) { if (environment.contains(variable)) {
return environment.value(variable); return environment.value(variable);
} else if (variable == key) { } else if (variable == key) {
qCWarning(UTIL) << "recursive variable expansion" << variable; // This must be a reference to a system environment variable of the
// same name, which happens to be unset. Treat it as empty.
return QString(); return QString();
} else if (input.contains(variable)) { } else if (input.contains(variable)) {
return expandVariable(variable, input.value(variable), output, input, environment); return expandVariable(variable, input.value(variable), output, input, environment);
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment