1. 22 Sep, 2020 1 commit
    • Igor Kushnir's avatar
      Don't crash after Cancel in Job Already Running dialog · 147add2e
      Igor Kushnir authored
      When a user Execute-Launches an application a second time while the
      previously launched instance of this application is still running, the
      "Job Already Running" dialog appears with 3 buttons. If a user clicks
      the Cancel button, a NativeAppJob kills itself Quietly. This
      NativeAppJob belongs to an ExecuteCompositeJob, which is not notified
      when a subjob is killed Quietly. So the ExecuteCompositeJob keeps
      waiting for it to finish. When this waiting ExecuteCompositeJob is
      killed (e.g. via "Stop All" button or on KDevelop exit), it attempts to
      kill the subjob it believes is still running, but which in fact is long
      since destroyed. This usually causes a segmentation fault.
      
      Aleix Pol fixed a similar crash when the "Kill All Instances" button in
      the "Job Already Running" dialog is clicked in
      8430d305.
      
      BUG: 399511, 416874
      FIXED-IN: 5.6.1
      147add2e
  2. 18 Jul, 2020 1 commit
  3. 14 Jun, 2020 1 commit
    • Aleix Pol Gonzalez's avatar
      execute: remember the option to kill a process that is already running · 9279c8e9
      Aleix Pol Gonzalez authored
      We have the feature to kill the currently executed process as we run it.
      This patch allows to remember the selection as I've seen myself doing
      the same over and over again for different projects.
      
      It leaves the same default behaviour and also adds an option in the
      configuration dialog in case we need to change it back for some reason.
      9279c8e9
  4. 25 Oct, 2018 1 commit
  5. 24 Aug, 2018 1 commit
  6. 20 Aug, 2018 1 commit
  7. 27 Feb, 2018 1 commit
    • Aleix Pol Gonzalez's avatar
      Make sure we don't crash when stopping all jobs · 8430d305
      Aleix Pol Gonzalez authored
      Summary:
      If we don't emit result, the ExecuteCompositeJob doesn't relise that
      it's failing and keeps the dangling object. Calling stop all processes
      would result in a crash then.
      
      Test Plan:
      * run app
      * run app again
      * choose to kill the first instance
      * stop all processes
      
      Reviewers: #kdevelop, mwolff
      
      Reviewed By: #kdevelop, mwolff
      
      Subscribers: mwolff, kdevelop-devel
      
      Differential Revision: https://phabricator.kde.org/D10874
      8430d305
  8. 18 Oct, 2017 1 commit
    • Christoph Roick's avatar
      Allow abortion of starting another NativeAppJob · d896e748
      Christoph Roick authored
      Summary:
      - offers to cancel an accidental startup of an already running job
      - kill all running instances instead of one by one
      - fix: do not ask again if "No" was already selected
      
      Test Plan:
      - start second instance of an already running job
      - select
          * Kill All Instances (No) (kills all running instances)
          * Start Another (Yes) (just starts a new instance)
          * Cancel (closes the dialog and drops the new job)
      
      Reviewers: #kdevelop, mwolff
      
      Reviewed By: #kdevelop, mwolff
      
      Subscribers: kfunk, mwolff, kdevelop-devel
      
      Differential Revision: https://phabricator.kde.org/D8199
      d896e748
  9. 13 Sep, 2017 1 commit