GitLab

GIT_SILENT

Among other things this ensures that we don't load plugins that
we don't need in some of our tests, as we no longer check the
user's configuration for which plugin is enabled.

Reverts bd8a49a1 for Qt < 5.12

GIT_SILENT

Having the macro's definition of the operator| in the namespace of the
flags argument improves/unbreaks things for the argument-dependent
lookup of unqualified function names, e.g. when flags are combined in
calls of other methods, but there is some other operator| defined in the
namespace of the current code.

Given Q_DECLARE_OPERATORS_FOR_FLAGS creates inlined functions, this
should be a source and binary compatible change.

Qt did similar for Qt 5.12 in
https://codereview.qt-project.org/c/qt/qtbase/+/225348

GIT_SILENT

GIT_SILENT

GIT_SILENT

GIT_SILENT

(cherry picked from commit 193c9cc9)

GIT_SILENT

GIT_SILENT

GIT_SILENT

GIT_SILENT

GIT_SILENT

GIT_SILENT

GIT_SILENT

Fixup to 2b9608e1

GIT_SILENT

Also drop:
* unneeded <includes>
* inconsistently used location="global" attributes with <header>

Summary:
The porposal is to utilize QSortFilterProxyModel for sorting and filtering.

When working with on a bigger project with multiple branches some means to find a desired branch for switching or creating a new branch may be considered helpful.
So I added a line edit and a QSortFilterProxyModel to do that for me.

Additionally: new branches are currently appended. Though this makes them easy to find, I think it's counter intuitive and a tad ugly. While the sort mechanism of the Proxy does not help initially, it does upon adding branches.

Drawback: the line edit for filtering may be associated with the "New" button by users. This could make the workflow for that less intuitive.

Test Plan:
Fire up Git->Branches on a git project.

Make sure all branches are there.
Type in the line edit to filter. Only branches that match should be included.
Clearing the line edit should result in all elements to become visible again.
Create New branch, that should be added to list in alphabetical order.

Reviewers: apol

Reviewed By: apol

Subscribers: kfunk, apol, kdevelop-devel

Tags: #vdg, #kdevelop

Differential Revision: https://phabricator.kde.org/D20142

Summary:
Uses upcoming KTextEditor::AbstractAnnotationItemDelegate

While staying in the boundaries of line-based rendering,
the delegate takes advantage of knowledge about grouped
lines for the same annotation, and does not repeat the main
info, but writes a secondary info on a second line (taking into
account visibility) and keeps further ones blank.

It also applies an ActiveToolTip for the tooltip on the annotation,
to allow copying data and in the future clicking links in the shown
commit message.

Reviewers: kfunk

Subscribers: croick, kfunk, brauch, apol, kdevelop-devel

Differential Revision: https://phabricator.kde.org/D8709

Reviewers: #kdevelop, kfunk

Reviewed By: #kdevelop, kfunk

Subscribers: kfunk, kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D16426

Summary:
Adds two wrapping variants of the macros
declare_qt_logging_category() & install_qt_logging_categories()
which have an argument TYPE to control specific behaviour that
otherwise is generalized in the wrapping macros to not have to repeat
any things with every macro call and to ensure consistency, e.g. in
the used description texts.

The wrapper macros also handle linking things by the matching EXPORT ids,
so the caller does not have to care for this.

No perfect solution yet, but at least a first working approach to automatic
generation of the kdebugsettings files.

Test Plan:
Generated categories files contain same ids with same descriptions as
before.

Reviewers: #kdevelop, kfunk

Reviewed By: #kdevelop, kfunk

Subscribers: kfunk, apol, kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D16032

Summary:
Done only for kdevplatform to showcase the idea. Would extend also for
plugins & app once okayed.

Things could be even more simplified by adding another wrapper macro which
avoid repeating all the patterns.

Test Plan:
Generated file matches the old manually one (except comments) and is
installed to same location.
Build works as before.

Reviewers: #kdevelop, kfunk

Reviewed By: #kdevelop, kfunk

Subscribers: kfunk, kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D15977

Summary:
With -Wimplicit-fallthrough the compiler warns about unannotated
fallthroughs in switch statements. Since it is supported by both GCC and
Clang, and can easily be fixed by adding Q_FALLTHROUGH() we enable it as
error.

As a consequence, we don't need to add redundant break statements as
safety measure. So we also warn about that, but not as error, especially
since it's only supported on Clang. (As far as I know.)

Reviewers: #kdevelop, kossebau, kfunk

Reviewed By: #kdevelop, kfunk

Subscribers: mwolff, apol, kfunk, rjvbb, brauch, mssola, kossebau, kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D15694