Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • KDevelop KDevelop
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 4
    • Issues 4
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 59
    • Merge requests 59
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • KDevelop
  • KDevelopKDevelop
  • Merge requests
  • !141

Merged
Created Jun 20, 2020 by Tristan Porteries@tristanpContributor

Fix document switcher plugin with multiple splitted view.

  • Overview 6
  • Commits 2
  • Pipelines 4
  • Changes 5

Summary: In differential D20548 an issue with document switcher plugin and split views is described. The solution is to open/activate document instead of activating view (aka Sublime::View) as view are linked to area (aka Sublime::Area) and will show again in same area instead of current active area.

But the differential solution was trying to retrieve the document from activated view which is not the perfect way as it must handle Sublime::UrlDocument to have an URL for openDocument function.

This patch use the document controller (aka IDocumentController) instead of sublime components.

The plugin tracks a list of document (aka IDocument) and enables signals for open/activate/close actions. Every document is placed in list model via DocumentSwitcherItem class responsible of extracting text and icon from a document passed in its constructor.

Without dependency to sublime, the plugin structure is simplified by not taking care about active main window, active area, and views. Only documents are tracking independently of the way they are displayed in UI.

Differential Revision: https://phabricator.kde.org/D24428

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: switch_doc_2