Skip to content

Remove slow deleteGroupRecursive(KConfigGroup)

Igor Kushnir requested to merge igorkushnir/kdevelop:optimize-closing-multiple-documents into master

The documentation for KConfigGroup::deleteGroup() says:

"Delete all entries in the entire group."

So deleting all subgroups and entries recursively should be unnecessary.

bfc60d8b introduced this function, but the explanation in the commit message is brief: "make working-sets work better with split-views". Perhaps there was some KConfigGroup bug in 2009, which has been fixed long ago. I briefly tested closing documents in split views at this commit and haven't noticed any issues.

Before this commit KDevelop freezes for 45 seconds after triggering Close All action in document tab context menu while 332 documents (syntax-highlighting/data/syntax/*.xml) are open. At this commit KDevelop freezes for 14 seconds in this case.

Merge request reports