Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • KDevelop KDevelop
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 4
    • Issues 4
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 54
    • Merge requests 54
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • KDevelop
  • KDevelopKDevelop
  • Merge requests
  • !88

Clang: partial workaround for parsing default arg values skipping macros

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Friedrich W. H. Kossebau requested to merge kossebau/kdevelop:workaroundfordefaultargvalueparsing into master Jan 18, 2020
  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 1

See https://bugs.kde.org/show_bug.cgi?id=369546

No clue about the clang API and thus how to properly fix things myself. So this patch fixes at least for now any wrong mapping of default argument values to arguments due to skipped entries for unparsed macros, by adding some placeholder. "KDEV TODO" is my try to have something short which signals that this is some internal issue and known. Surely there will still be bugs reported about seeing this string, but no better idea.

@kfunk @mwolff Would you have any idea how to improve CXChildVisitResult paramVisitor(CXCursor cursor, CXCursor /*parent*/, CXClientData data)? clang_getCursorExtent as currently relied on seems to stop at the macro border by what my debug output told me.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: workaroundfordefaultargvalueparsing