Commit f94e6d29 authored by Milian Wolff's avatar Milian Wolff

Skip clang-provided override items from code completion

This removes the duplicate items from the code completion list
and unbreaks TestCodeCompletion::testOverrideExecute when running
against clang 9.

Finally no more failing tests in the clang plugin :)
Still ton's of things to do though :(
parent 7be3e8b5
Pipeline #11790 passed with stage
in 57 minutes
......@@ -1169,6 +1169,11 @@ QList<CompletionTreeItemPointer> ClangCodeCompletionContext::completionItems(boo
// we have our own implementation of an override helper
// TODO: use the clang-provided one, if available
if (typed.endsWith(QLatin1String(" override")))
// TODO: No closing paren if default parameters present
if (isOverloadCandidate && !arguments.endsWith(QLatin1Char(')'))) {
arguments += QLatin1Char(')');
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment