context.cpp 50.2 KB
Newer Older
1 2 3
/*
 * This file is part of KDevelop
 * Copyright 2014 Milian Wolff <mail@milianw.de>
Sergey Kalinichev's avatar
Sergey Kalinichev committed
4
 * Copyright 2015 Sergey Kalinichev <kalinichev.so.0@gmail.com>
5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License as
 * published by the Free Software Foundation; either version 2 of
 * the License or (at your option) version 3 or any later version
 * accepted by the membership of KDE e.V. (or its successor approved
 * by the membership of KDE e.V.), which shall act as a proxy
 * defined in Section 14 of version 3 of the license.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */

#include "context.h"

25
#include <QRegularExpression>
26
#include <QStandardPaths>
27

28 29
#include <interfaces/icore.h>
#include <interfaces/idocumentcontroller.h>
30 31
#include <interfaces/iprojectcontroller.h>
#include <interfaces/iproject.h>
32

33 34 35
#include <language/duchain/duchainlock.h>
#include <language/duchain/ducontext.h>
#include <language/duchain/topducontext.h>
36
#include <language/duchain/declaration.h>
37
#include <language/duchain/classmemberdeclaration.h>
38
#include <language/duchain/classdeclaration.h>
39
#include <language/duchain/duchainutils.h>
40
#include <language/duchain/persistentsymboltable.h>
41
#include <language/duchain/types/integraltype.h>
42
#include <language/duchain/types/functiontype.h>
43
#include <language/duchain/types/pointertype.h>
44
#include <language/duchain/types/typealiastype.h>
45
#include <language/duchain/types/typeutils.h>
46
#include <language/duchain/stringhelpers.h>
47
#include <language/codecompletion/codecompletionmodel.h>
48
#include <language/codecompletion/normaldeclarationcompletionitem.h>
49
#include <util/foregroundlock.h>
50 51
#include <custom-definesandincludes/idefinesandincludesmanager.h>
#include <project/projectmodel.h>
52

Olivier JG's avatar
Olivier JG committed
53
#include "../util/clangdebug.h"
54
#include "../util/clangtypes.h"
55
#include "../util/clangutils.h"
56
#include "../duchain/clangdiagnosticevaluator.h"
Olivier JG's avatar
Olivier JG committed
57
#include "../duchain/parsesession.h"
58
#include "../duchain/duchainutils.h"
59
#include "../duchain/navigationwidget.h"
60
#include "../clangsettings/clangsettingsmanager.h"
61

62
#include <algorithm>
Kevin Funk's avatar
Kevin Funk committed
63
#include <functional>
64
#include <memory>
Kevin Funk's avatar
Kevin Funk committed
65

66
#include <KTextEditor/Document>
67
#include <KTextEditor/View>
68 69 70 71

using namespace KDevelop;

namespace {
Kevin Funk's avatar
Kevin Funk committed
72 73
/// Maximum return-type string length in completion items
const int MAX_RETURN_TYPE_STRING_LENGTH = 20;
74

75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112
/// Priority of code-completion results. NOTE: Keep in sync with Clang code base.
enum CodeCompletionPriority {
  /// Priority for the next initialization in a constructor initializer list.
  CCP_NextInitializer = 7,
  /// Priority for an enumeration constant inside a switch whose condition is of the enumeration type.
  CCP_EnumInCase = 7,

  CCP_LocalDeclarationMatch = 8,

  CCP_DeclarationMatch = 12,

  CCP_LocalDeclarationSimiliar = 17,
  /// Priority for a send-to-super completion.
  CCP_SuperCompletion = 20,

  CCP_DeclarationSimiliar = 25,
  /// Priority for a declaration that is in the local scope.
  CCP_LocalDeclaration = 34,
  /// Priority for a member declaration found from the current method or member function.
  CCP_MemberDeclaration = 35,
  /// Priority for a language keyword (that isn't any of the other categories).
  CCP_Keyword = 40,
  /// Priority for a code pattern.
  CCP_CodePattern = 40,
  /// Priority for a non-type declaration.
  CCP_Declaration = 50,
  /// Priority for a type.
  CCP_Type = CCP_Declaration,
  /// Priority for a constant value (e.g., enumerator).
  CCP_Constant = 65,
  /// Priority for a preprocessor macro.
  CCP_Macro = 70,
  /// Priority for a nested-name-specifier.
  CCP_NestedNameSpecifier = 75,
  /// Priority for a result that isn't likely to be what the user wants, but is included for completeness.
  CCP_Unlikely = 80
};

113 114 115 116 117
/**
 * Common base class for Clang code completion items.
 */
template<class Base>
class CompletionItem : public Base
118 119
{
public:
120
    CompletionItem(const QString& display, const QString& prefix)
121 122 123
        : Base()
        , m_display(display)
        , m_prefix(prefix)
124
        , m_unimportant(false)
125 126
    {
    }
127

128
    ~CompletionItem() override = default;
129

130 131 132 133 134 135 136 137
    QVariant data(const QModelIndex& index, int role, const CodeCompletionModel* /*model*/) const override
    {
        if (role == Qt::DisplayRole) {
            if (index.column() == CodeCompletionModel::Prefix) {
                return m_prefix;
            } else if (index.column() == CodeCompletionModel::Name) {
                return m_display;
            }
138
        }
139
        return {};
140
    }
141

142 143 144 145 146
    void markAsUnimportant()
    {
        m_unimportant = true;
    }

147
protected:
148 149
    QString m_display;
    QString m_prefix;
150
    bool m_unimportant;
151 152
};

153 154 155
class OverrideItem : public CompletionItem<CompletionTreeItem>
{
public:
Kevin Funk's avatar
Kevin Funk committed
156
    OverrideItem(const QString& nameAndParams, const QString& returnType)
157
        : CompletionItem<CompletionTreeItem>(
158
              nameAndParams,
159
              i18n("Override %1", returnType)
160
          )
161
        , m_returnType(returnType)
162 163 164 165 166 167 168
    {
    }

    QVariant data(const QModelIndex& index, int role, const CodeCompletionModel* model) const override
    {
        if (role == Qt::DecorationRole) {
            if (index.column() == KTextEditor::CodeCompletionModel::Icon) {
169
                static const QIcon icon = QIcon::fromTheme(QStringLiteral("CTparents"));
170 171 172 173 174
                return icon;
            }
        }
        return CompletionItem<CompletionTreeItem>::data(index, role, model);
    }
175 176 177

    void execute(KTextEditor::View* view, const KTextEditor::Range& word) override
    {
178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200
        QString replacement = m_returnType + QLatin1Char(' ') + m_display.replace(QRegularExpression(QStringLiteral("\\s*=\\s*0")), QString());

        bool appendSpecifer = true;
        if (const auto* project =
            KDevelop::ICore::self()->projectController()->findProjectForUrl(view->document()->url())) {
            const auto arguments = KDevelop::IDefinesAndIncludesManager::manager()->parserArguments(
                project->filesForPath(IndexedString(view->document()->url().path())).first());
            const auto match = QRegularExpression(QStringLiteral(R"(-std=c\+\+(\w+))")).match(arguments);

            appendSpecifer = match.hasMatch(); // assume non-modern if no standard is specified
            if (appendSpecifer) {
                const auto standard = match.captured(1);
                appendSpecifer = (standard != QLatin1String("98") && standard != QLatin1String("03"));
            }
        }

        if (appendSpecifer) {
            replacement.append(QLatin1String(" override;"));
        } else {
            replacement.append(QLatin1Char(';'));
        }

        view->document()->replaceText(word, replacement);
201 202 203 204
    }

private:
    QString m_returnType;
205 206
};

207 208 209 210
/**
 * Specialized completion item class for items which are represented by a Declaration
 */
class DeclarationItem : public CompletionItem<NormalDeclarationCompletionItem>
211
{
212 213
public:
    DeclarationItem(Declaration* dec, const QString& display, const QString& prefix, const QString& replacement)
214 215
        : CompletionItem<NormalDeclarationCompletionItem>(display, prefix)
        , m_replacement(replacement)
216 217
    {
        m_declaration = dec;
218
    }
219 220 221

    QVariant data(const QModelIndex& index, int role, const CodeCompletionModel* model) const override
    {
Kevin Funk's avatar
Kevin Funk committed
222 223
        if (role == CodeCompletionModel::MatchQuality && m_matchQuality) {
            return m_matchQuality;
224 225
        }

226 227 228 229 230
        auto ret = CompletionItem<NormalDeclarationCompletionItem>::data(index, role, model);
        if (ret.isValid()) {
            return ret;
        }
        return NormalDeclarationCompletionItem::data(index, role, model);
231
    }
232

Kevin Funk's avatar
Kevin Funk committed
233
    void execute(KTextEditor::View* view, const KTextEditor::Range& word) override
234 235 236 237 238 239 240 241 242
    {
        QString repl = m_replacement;
        DUChainReadLocker lock;

        if(!m_declaration){
            return;
        }

        if(m_declaration->isFunctionDeclaration()) {
243 244 245 246 247 248 249
            const auto functionType = m_declaration->type<FunctionType>();

            // protect against buggy code that created the m_declaration,
            // to mark it as a function but not assign a function type
            if (!functionType)
                return;

250
            auto doc = view->document();
251 252 253 254 255 256 257 258 259 260 261 262 263

            // Function pointer?
            bool funcptr = false;
            const auto line = doc->line(word.start().line());
            auto pos = word.end().column() - 1;
            while ( pos > 0 && (line.at(pos).isLetterOrNumber() || line.at(pos) == QLatin1Char(':')) ) {
                pos--;
                if ( line.at(pos) == QLatin1Char('&') ) {
                    funcptr = true;
                    break;
                }
            }

264 265
            auto restEmpty = doc->characterAt(word.end() + KTextEditor::Cursor{0, 1}) == QChar();

266
            bool didAddParentheses = false;
267
            if ( !funcptr && doc->characterAt(word.end()) != QLatin1Char('(') ) {
268
                repl += QLatin1String("()");
269
                didAddParentheses = true;
270
            }
Kevin Funk's avatar
Kevin Funk committed
271
            view->document()->replaceText(word, repl);
272
            if (functionType->indexedArgumentsSize() && didAddParentheses) {
Kevin Funk's avatar
Kevin Funk committed
273
                view->setCursorPosition(word.start() + KTextEditor::Cursor(0, repl.size() - 1));
274
            }
275
            auto returnTypeIntegral = functionType->returnType().cast<IntegralType>();
276 277
            if ( restEmpty && !funcptr && returnTypeIntegral && returnTypeIntegral->dataType() == IntegralType::TypeVoid ) {
                // function returns void and rest of line is empty -- nothing can be done with the result
278
                if (functionType->indexedArgumentsSize() ) {
279 280 281 282 283 284 285 286 287
                    // we placed the cursor inside the ()
                    view->document()->insertText(view->cursorPosition() + KTextEditor::Cursor(0, 1), QStringLiteral(";"));
                }
                else {
                    // we placed the cursor after the ()
                    view->document()->insertText(view->cursorPosition(), QStringLiteral(";"));
                    view->setCursorPosition(view->cursorPosition() + KTextEditor::Cursor{0, 1});
                }
            }
288
        } else {
Kevin Funk's avatar
Kevin Funk committed
289
            view->document()->replaceText(word, repl);
290 291 292
        }
    }

293 294 295 296 297 298 299
    bool createsExpandingWidget() const override
    {
        return true;
    }

    QWidget* createExpandingWidget(const CodeCompletionModel* /*model*/) const override
    {
300
        return new ClangNavigationWidget(m_declaration, AbstractNavigationWidget::EmbeddableWidget);
301
    }
302

Kevin Funk's avatar
Kevin Funk committed
303 304 305 306 307
    int matchQuality() const
    {
        return m_matchQuality;
    }

308
    ///Sets match quality from 0 to 10. 10 is the best fit.
Kevin Funk's avatar
Kevin Funk committed
309
    void setMatchQuality(int value)
310
    {
Kevin Funk's avatar
Kevin Funk committed
311
        m_matchQuality = value;
312 313
    }

314 315 316 317 318
    void setInheritanceDepth(int depth)
    {
        m_inheritanceDepth = depth;
    }

319 320 321 322 323 324 325 326 327 328
    int argumentHintDepth() const override
    {
        return m_depth;
    }

    void setArgumentHintDepth(int depth)
    {
        m_depth = depth;
    }

329
protected:
Kevin Funk's avatar
Kevin Funk committed
330
    int m_matchQuality = 0;
331
    int m_depth = 0;
332
    QString m_replacement;
333
};
334

335 336 337 338 339 340 341 342 343 344 345 346 347
class ImplementsItem : public DeclarationItem
{
public:
    static QString replacement(const FuncImplementInfo& info)
    {
        QString replacement = info.templatePrefix;
        if (!info.isDestructor && !info.isConstructor) {
            replacement += info.returnType + QLatin1Char(' ');
        }
        replacement += info.prototype + QLatin1String("\n{\n}\n");
        return replacement;
    }

348
    explicit ImplementsItem(const FuncImplementInfo& item)
349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367
        : DeclarationItem(item.declaration.data(), item.prototype,
            i18n("Implement %1", item.isConstructor ? QStringLiteral("<constructor>") :
                                   item.isDestructor ? QStringLiteral("<destructor>") : item.returnType),
            replacement(item)
          )
    {
    }

    QVariant data(const QModelIndex& index, int role, const CodeCompletionModel* model) const override
    {
        if (index.column() == CodeCompletionModel::Arguments) {
            // our display string already contains the arguments
            return {};
        }
        return DeclarationItem::data(index, role, model);
    }

    void execute(KTextEditor::View* view, const KTextEditor::Range& word) override
    {
368 369 370 371 372 373 374 375 376 377 378 379 380 381
        auto* const document = view->document();

        // try and replace leading typed text that match the proposed implementation
        const QString leading = document->line(word.end().line()).left(word.end().column());
        const QString leadingNoSpace = removeWhitespace(leading);
        if (!leadingNoSpace.isEmpty() && (removeWhitespace(m_display).startsWith(leadingNoSpace)
            || removeWhitespace(m_replacement).startsWith(leadingNoSpace))) {
            const int removeSize = leading.end() - std::find_if_not(leading.begin(), leading.end(),
                                        [](QChar c){ return c.isSpace(); });
            const KTextEditor::Cursor newStart = {word.end().line(), word.end().column() - removeSize};
            document->replaceText({newStart, word.end()}, m_replacement);
        } else {
            document->replaceText(word, m_replacement);
        }
382 383 384

        // place cursor after the opening brace
        view->setCursorPosition(view->cursorPosition() + KTextEditor::Cursor{-2, 1});
385 386
    }
};
387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402

class ArgumentHintItem : public DeclarationItem
{
public:
    struct CurrentArgumentRange
    {
        int start;
        int end;
    };

    ArgumentHintItem(Declaration* decl,  const QString& prefix, const QString& name, const QString& arguments, const CurrentArgumentRange& range)
        : DeclarationItem(decl, name, prefix, {})
        , m_range(range)
        , m_arguments(arguments)
    {}

Milian Wolff's avatar
Milian Wolff committed
403
    QVariant data(const QModelIndex& index, int role, const CodeCompletionModel* model) const override
404 405 406 407
    {
        if (role == CodeCompletionModel::CustomHighlight && index.column() == CodeCompletionModel::Arguments && argumentHintDepth()) {
            QTextCharFormat boldFormat;
            boldFormat.setFontWeight(QFont::Bold);
408 409 410 411 412
            const QList<QVariant> highlighting {
                QVariant(m_range.start),
                QVariant(m_range.end),
                boldFormat,
            };
413 414 415 416 417 418 419
            return highlighting;
        }

        if (role == CodeCompletionModel::HighlightingMethod && index.column() == CodeCompletionModel::Arguments && argumentHintDepth()) {
            return QVariant(CodeCompletionModel::CustomHighlighting);
        }

420
        if (index.column() == CodeCompletionModel::Arguments) {
421 422 423 424 425 426 427 428 429 430 431
            return m_arguments;
        }

        return DeclarationItem::data(index, role, model);
    }

private:
    CurrentArgumentRange m_range;
    QString m_arguments;
};

432 433 434
/**
 * A minimalistic completion item for macros and such
 */
435 436 437
class SimpleItem : public CompletionItem<CompletionTreeItem>
{
public:
438
    SimpleItem(const QString& display, const QString& prefix, const QString& replacement, const QIcon& icon = QIcon())
439 440
        : CompletionItem<CompletionTreeItem>(display, prefix)
        , m_replacement(replacement)
441
        , m_icon(icon)
442 443 444 445 446 447 448 449
    {
    }

    void execute(KTextEditor::View* view, const KTextEditor::Range& word) override
    {
        view->document()->replaceText(word, m_replacement);
    }

450 451 452 453 454
    QVariant data(const QModelIndex& index, int role, const CodeCompletionModel* model) const override
    {
        if (role == Qt::DecorationRole && index.column() == KTextEditor::CodeCompletionModel::Icon) {
            return m_icon;
        }
455
        if (role == CodeCompletionModel::UnimportantItemRole) {
456 457
            return m_unimportant;
        }
458 459 460
        return CompletionItem<CompletionTreeItem>::data(index, role, model);
    }

461 462
private:
    QString m_replacement;
463
    QIcon m_icon;
464
};
465

466 467 468
/**
 * Return true in case position @p position represents a cursor inside a comment
 */
Kevin Funk's avatar
Kevin Funk committed
469
bool isInsideComment(CXTranslationUnit unit, CXFile file, const KTextEditor::Cursor& position)
470 471 472 473 474 475 476
{
    if (!position.isValid()) {
        return false;
    }

    // TODO: This may get very slow for a large TU, investigate if we can improve this function
    auto begin = clang_getLocation(unit, file, 1, 1);
Kevin Funk's avatar
Kevin Funk committed
477
    auto end = clang_getLocation(unit, file, position.line() + 1, position.column() + 1);
478 479 480 481
    CXSourceRange range = clang_getRange(begin, end);

    // tokenize the whole range from the start until 'position'
    // if we detect a comment token at this position, return true
482 483
    const ClangTokens tokens(unit, range);
    for (CXToken token : tokens) {
484 485 486 487 488 489
        CXTokenKind tokenKind = clang_getTokenKind(token);
        if (tokenKind != CXToken_Comment) {
            continue;
        }

        auto range = ClangRange(clang_getTokenExtent(unit, token));
Kevin Funk's avatar
Kevin Funk committed
490
        if (range.toRange().contains(position)) {
491 492 493 494 495 496
            return true;
        }
    }
    return false;
}

Kevin Funk's avatar
Kevin Funk committed
497 498 499
QString& elideStringRight(QString& str, int length)
{
    if (str.size() > length + 3) {
500
        return str.replace(length, str.size() - length, QStringLiteral("..."));
Kevin Funk's avatar
Kevin Funk committed
501 502 503 504
    }
    return str;
}

Kevin Funk's avatar
Kevin Funk committed
505
/**
506
 * @return Value suited for @ref CodeCompletionModel::MatchQuality in the range [0.0, 10.0] (the higher the better)
Kevin Funk's avatar
Kevin Funk committed
507 508 509 510 511 512
 *
 * See http://clang.llvm.org/doxygen/CodeCompleteConsumer_8h_source.html for list of priorities
 * They (currently) have a range from [-3, 80] (the lower, the better)
 */
int codeCompletionPriorityToMatchQuality(unsigned int completionPriority)
{
513
    return 10u - qBound(0u, completionPriority, 80u) / 8;
Kevin Funk's avatar
Kevin Funk committed
514 515
}

516
int adjustPriorityForType(const AbstractType::Ptr& type, int completionPriority)
517
{
518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534
    const auto modifier = 4;
    if (type) {
        const auto whichType = type->whichType();
        if (whichType == AbstractType::TypePointer || whichType == AbstractType::TypeReference) {
            // Clang considers all pointers as similar, this is not what we want.
            completionPriority += modifier;
        } else if (whichType == AbstractType::TypeStructure) {
            // Clang considers all classes as similar too...
            completionPriority += modifier;
        } else if (whichType == AbstractType::TypeDelayed) {
            completionPriority += modifier;
        } else if (whichType == AbstractType::TypeAlias) {
            auto aliasedType = type.cast<TypeAliasType>();
            return adjustPriorityForType(aliasedType ? aliasedType->type() : AbstractType::Ptr(), completionPriority);
        } else if (whichType == AbstractType::TypeFunction) {
            auto functionType = type.cast<FunctionType>();
            return adjustPriorityForType(functionType ? functionType->returnType() : AbstractType::Ptr(), completionPriority);
535
        }
536 537
    } else {
        completionPriority += modifier;
538 539 540 541 542
    }

    return completionPriority;
}

543 544 545 546 547 548 549 550 551 552
/// Adjusts priority for the @p decl
int adjustPriorityForDeclaration(Declaration* decl, unsigned int completionPriority)
{
    if(completionPriority < CCP_LocalDeclarationSimiliar || completionPriority > CCP_SuperCompletion){
        return completionPriority;
    }

    return adjustPriorityForType(decl->abstractType(), completionPriority);
}

553 554 555
/**
 * @return Whether the declaration represented by identifier @p identifier qualifies as completion result
 *
Kevin Funk's avatar
Kevin Funk committed
556 557
 * For example, we don't want to offer SomeClass::SomeClass as completion item to the user
 * (otherwise we'd end up generating code such as 's.SomeClass();')
558 559 560 561 562 563 564 565 566 567 568 569 570 571
 */
bool isValidCompletionIdentifier(const QualifiedIdentifier& identifier)
{
    const int count = identifier.count();
    if (identifier.count() < 2) {
        return true;
    }

    const Identifier scope = identifier.at(count-2);
    const Identifier id = identifier.last();
    if (scope == id) {
        return false; // is constructor
    }
    const QString idString = id.toString();
572
    if (idString.startsWith(QLatin1Char('~')) && scope.toString() == idString.midRef(1)) {
573 574 575 576 577
        return false; // is destructor
    }
    return true;
}

578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593
/**
 * @return Whether the declaration represented by identifier @p identifier qualifies as "special" completion result
 *
 * "Special" completion results are items that are likely not regularly used.
 *
 * Examples:
 * - 'SomeClass::operator=(const SomeClass&)'
 */
bool isValidSpecialCompletionIdentifier(const QualifiedIdentifier& identifier)
{
    if (identifier.count() < 2) {
        return false;
    }

    const Identifier id = identifier.last();
    const QString idString = id.toString();
594
    if (idString.startsWith(QLatin1String("operator="))) {
595 596 597 598 599
        return true; // is assignment operator
    }
    return false;
}

600
Declaration* findDeclaration(const QualifiedIdentifier& qid, const DUContextPointer& ctx, const CursorInRevision& position, QSet<Declaration*>& handled)
601
{
602
    PersistentSymbolTable::Declarations decl = PersistentSymbolTable::self().declarations(qid);
603

604 605 606
    const auto top = ctx->topContext();
    const auto& importedContexts = top->importedParentContexts();

607
    for (auto it = decl.iterator(); it; ++it) {
608 609 610 611 612 613 614 615 616 617 618 619
        // if the context is not included, then this match is not correct for our consideration
        // this fixes issues where we used to include matches from files that did not have
        // anything to do with the current TU, e.g. the main from a different file or stuff like that
        // it also reduces the chance of us picking up a function of the same name from somewhere else
        // also, this makes sure the context has the correct language and we don't get confused by stuff
        // from other language plugins
        if (std::none_of(importedContexts.begin(), importedContexts.end(), [it] (const DUContext::Import& import) {
            return import.topContextIndex() == it->indexedTopContext().index();
        })) {
            continue;
        }

620
        auto declaration = it->declaration();
621 622 623 624 625 626 627
        if (!declaration) {
            // Mitigate problems such as: Cannot load a top-context from file "/home/kfunk/.cache/kdevduchain/kdevelop-{foo}/topcontexts/6085"
            //  - the required language-support for handling ID 55 is probably not loaded
            qCWarning(KDEV_CLANG) << "Detected an invalid declaration for" << qid;
            continue;
        }

628
        if (declaration->kind() == Declaration::Instance && !declaration->isFunctionDeclaration()) {
629 630
            break;
        }
631 632
        if (!handled.contains(declaration)) {
            handled.insert(declaration);
633
            return declaration;
634 635 636 637 638 639 640
        }
    }

    const auto foundDeclarations = ctx->findDeclarations(qid, position);
    for (auto dec : foundDeclarations) {
        if (!handled.contains(dec)) {
            handled.insert(dec);
641
            return dec;
642 643 644
        }
    }

645
    return nullptr;
646 647
}

648
/// If any parent of this context is a class, the closest class declaration is returned, nullptr otherwise
649
Declaration* classDeclarationForContext(const DUContextPointer& context, const CursorInRevision& position)
650 651 652 653 654 655
{
    auto parent = context;
    while (parent) {
        if (parent->type() == DUContext::Class) {
            break;
        }
656 657 658 659 660 661 662 663

        if (auto owner = parent->owner()) {
            // Work-around for out-of-line methods. They have Helper context instead of Class context
            if (owner->context() && owner->context()->type() == DUContext::Helper) {
                auto qid = owner->qualifiedIdentifier();
                qid.pop();

                QSet<Declaration*> tmp;
664
                auto decl = findDeclaration(qid, context, position, tmp);
665 666 667 668 669 670 671

                if (decl && decl->internalContext() && decl->internalContext()->type() == DUContext::Class) {
                    parent = decl->internalContext();
                    break;
                }
            }
        }
672 673 674 675 676 677
        parent = parent->parentContext();
    }

    return parent ? parent->owner() : nullptr;
}

678 679 680
class LookAheadItemMatcher
{
public:
681
    explicit LookAheadItemMatcher(const TopDUContextPointer& ctx)
682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716
        : m_topContext(ctx)
        , m_enabled(ClangSettingsManager::self()->codeCompletionSettings().lookAhead)
    {}

    /// Adds all local declarations for @p declaration into possible look-ahead items.
    void addDeclarations(Declaration* declaration)
    {
        if (!m_enabled) {
            return;
        }

        if (declaration->kind() != Declaration::Instance) {
            return;
        }

        auto type = typeForDeclaration(declaration);
        auto identifiedType = dynamic_cast<const IdentifiedType*>(type.data());
        if (!identifiedType) {
            return;
        }

        addDeclarationsForType(identifiedType, declaration);
    }

    /// Add type for matching. This type'll be used for filtering look-ahead items
    /// Only items with @p type will be returned through @sa matchedItems
    void addMatchedType(const IndexedType& type)
    {
        matchedTypes.insert(type);
    }

    /// @return look-ahead items that math given types. @sa addMatchedType
    QList<CompletionTreeItemPointer> matchedItems()
    {
        QList<CompletionTreeItemPointer> lookAheadItems;
717
        for (const auto& pair: qAsConst(possibleLookAheadDeclarations)) {
718
            auto decl = pair.first;
719
            if (matchedTypes.contains(decl->indexedType())) {
720 721 722 723
                auto parent = pair.second;
                const QString access = parent->abstractType()->whichType() == AbstractType::TypePointer
                                 ? QStringLiteral("->") : QStringLiteral(".");
                const QString text = parent->identifier().toString() + access + decl->identifier().toString();
724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746
                auto item = new DeclarationItem(decl, text, {}, text);
                item->setMatchQuality(8);
                lookAheadItems.append(CompletionTreeItemPointer(item));
            }
        }

        return lookAheadItems;
    }

private:
    AbstractType::Ptr typeForDeclaration(const Declaration* decl)
    {
        return TypeUtils::targetType(decl->abstractType(), m_topContext.data());
    }

    void addDeclarationsForType(const IdentifiedType* identifiedType, Declaration* declaration)
    {
        if (auto typeDecl = identifiedType->declaration(m_topContext.data())) {
            if (dynamic_cast<ClassDeclaration*>(typeDecl->logicalDeclaration(m_topContext.data()))) {
                if (!typeDecl->internalContext()) {
                    return;
                }

747 748
                const auto& localDeclarations = typeDecl->internalContext()->localDeclarations();
                for (auto localDecl : localDeclarations) {
749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771
                    if(localDecl->identifier().isEmpty()){
                        continue;
                    }

                    if(auto classMember = dynamic_cast<ClassMemberDeclaration*>(localDecl)){
                        // TODO: Also add protected/private members if completion is inside this class context.
                        if(classMember->accessPolicy() != Declaration::Public){
                            continue;
                        }
                    }

                    if(!declaration->abstractType()){
                        continue;
                    }

                    if (declaration->abstractType()->whichType() == AbstractType::TypeIntegral) {
                        if (auto integralType = declaration->abstractType().cast<IntegralType>()) {
                            if (integralType->dataType() == IntegralType::TypeVoid) {
                                continue;
                            }
                        }
                    }

772
                    possibleLookAheadDeclarations.insert({localDecl, declaration});
773 774 775 776 777 778
                }
            }
        }
    }

    // Declaration and it's context
779
    using DeclarationContext = QPair<Declaration*, Declaration*>;
780 781 782 783 784

    /// Types of declarations that look-ahead completion items can have
    QSet<IndexedType> matchedTypes;

    // List of declarations that can be added to the Look Ahead group
785 786
    // Second declaration represents context
    QSet<DeclarationContext> possibleLookAheadDeclarations;
787 788 789 790 791 792

    TopDUContextPointer m_topContext;

    bool m_enabled;
};

793 794 795 796 797 798 799 800 801 802 803
struct MemberAccessReplacer : public QObject
{
    Q_OBJECT

public:
    enum Type {
        None,
        DotToArrow,
        ArrowToDot
    };

804
public Q_SLOTS:
805 806 807 808 809 810 811 812 813 814 815 816
    void replaceCurrentAccess(MemberAccessReplacer::Type type)
    {
        if (auto document = ICore::self()->documentController()->activeDocument()) {
            if (auto textDocument = document->textDocument()) {
                auto activeView = document->activeTextView();
                if (!activeView) {
                    return;
                }

                auto cursor = activeView->cursorPosition();

                QString oldAccess, newAccess;
817
                if (type == ArrowToDot) {
818 819 820 821 822 823 824 825
                    oldAccess = QStringLiteral("->");
                    newAccess = QStringLiteral(".");
                } else {
                    oldAccess = QStringLiteral(".");
                    newAccess = QStringLiteral("->");
                }

                auto oldRange = KTextEditor::Range(cursor - KTextEditor::Cursor(0, oldAccess.length()), cursor);
826 827 828 829 830 831 832 833

                // This code needed for testReplaceMemberAccess test
                // Maybe we should do a similar thing for '->' to '.' direction, but this is not so important
                while (textDocument->text(oldRange) == QLatin1String(" ") && oldRange.start().column() >= 0) {
                    oldRange = KTextEditor::Range({oldRange.start().line(), oldRange.start().column() - 1},
                                                  {oldRange.end().line(), oldRange.end().column() - 1});
                }

834 835 836 837 838 839 840 841 842
                if (oldRange.start().column() >= 0 && textDocument->text(oldRange) == oldAccess) {
                    textDocument->replaceText(oldRange, newAccess);
                }
            }
        }
    }
};
static MemberAccessReplacer s_memberAccessReplacer;

843 844
}

845 846
Q_DECLARE_METATYPE(MemberAccessReplacer::Type)

847
ClangCodeCompletionContext::ClangCodeCompletionContext(const DUContextPointer& context,
Kevin Funk's avatar
Kevin Funk committed
848
                                                       const ParseSessionData::Ptr& sessionData,
849
                                                       const QUrl& url,
Kevin Funk's avatar
Kevin Funk committed
850
                                                       const KTextEditor::Cursor& position,
851 852
                                                       const QString& text,
                                                       const QString& followingText
853
                                                      )
854
    : CodeCompletionContext(context, text + followingText, CursorInRevision::castFromSimpleCursor(position), 0)
855
    , m_results(nullptr, clang_disposeCodeCompleteResults)
Kevin Funk's avatar
Kevin Funk committed
856
    , m_parseSessionData(sessionData)
857
{
858
    qRegisterMetaType<MemberAccessReplacer::Type>();
859 860
    const QByteArray file = url.toLocalFile().toUtf8();
    ParseSession session(m_parseSessionData);
861 862 863 864 865 866 867 868

    QVector<UnsavedFile> otherUnsavedFiles;
    {
        ForegroundLock lock;
        otherUnsavedFiles = ClangUtils::unsavedFiles();
    }
    QVector<CXUnsavedFile> allUnsaved;

Kevin Funk's avatar
Kevin Funk committed
869 870 871
    {
        const unsigned int completeOptions = clang_defaultCodeCompleteOptions();

872 873 874 875
        CXUnsavedFile unsaved;
        unsaved.Filename = file.constData();
        const QByteArray content = m_text.toUtf8();
        unsaved.Contents = content.constData();
876 877
        unsaved.Length = content.size();

878
        allUnsaved.reserve(otherUnsavedFiles.size() + 1);
879
        for (const auto& f : qAsConst(otherUnsavedFiles)) {
880 881 882
            allUnsaved.append(f.toClangApi());
        }
        allUnsaved.append(unsaved);
883

884 885
        m_results.reset(clang_codeCompleteAt(session.unit(), file.constData(),
                        position.line() + 1, position.column() + 1,
886
                        allUnsaved.data(), allUnsaved.size(),
887
                        completeOptions));
Kevin Funk's avatar
Kevin Funk committed
888 889

        if (!m_results) {
890
            qCWarning(KDEV_CLANG) << "Something went wrong during 'clang_codeCompleteAt' for file" << file;
891
            return;
Kevin Funk's avatar
Kevin Funk committed
892
        }
893

894 895 896 897 898 899 900 901 902
        auto numDiagnostics = clang_codeCompleteGetNumDiagnostics(m_results.get());
        for (uint i = 0; i < numDiagnostics; i++) {
            auto diagnostic = clang_codeCompleteGetDiagnostic(m_results.get(), i);
            auto diagnosticType = ClangDiagnosticEvaluator::diagnosticType(diagnostic);
            clang_disposeDiagnostic(diagnostic);
            if (diagnosticType == ClangDiagnosticEvaluator::ReplaceWithArrowProblem || diagnosticType == ClangDiagnosticEvaluator::ReplaceWithDotProblem) {
                MemberAccessReplacer::Type replacementType;
                if (diagnosticType == ClangDiagnosticEvaluator::ReplaceWithDotProblem) {
                    replacementType = MemberAccessReplacer::ArrowToDot;
903 904
                } else {
                    replacementType = MemberAccessReplacer::DotToArrow;
905 906 907 908 909 910 911 912 913 914
                }

                QMetaObject::invokeMethod(&s_memberAccessReplacer, "replaceCurrentAccess", Qt::QueuedConnection,
                                          Q_ARG(MemberAccessReplacer::Type, replacementType));

                m_valid = false;
                return;
            }
        }

915 916 917 918
        auto addMacros = ClangSettingsManager::self()->codeCompletionSettings().macros;
        if (!addMacros) {
            m_filters |= NoMacros;
        }
919
    }
920

921 922 923 924 925
    if (!m_results->NumResults) {
        const auto trimmedText = text.trimmed();
        if (trimmedText.endsWith(QLatin1Char('.'))) {
            // TODO: This shouldn't be needed if Clang provided diagnostic.
            // But it doesn't always do it, so let's try to manually determine whether '.' is used instead of '->'
926
            m_text = trimmedText.leftRef(trimmedText.size() - 1) + QStringLiteral("->");
927 928 929 930 931

            CXUnsavedFile unsaved;
            unsaved.Filename = file.constData();
            const QByteArray content = m_text.toUtf8();
            unsaved.Contents = content.constData();
932 933
            unsaved.Length = content.size();
            allUnsaved[allUnsaved.size() - 1] = unsaved;
934 935

            m_results.reset(clang_codeCompleteAt(session.unit(), file.constData(),
936
                                                 position.line() + 1, position.column() + 1 + 1,
937
                                                 allUnsaved.data(), allUnsaved.size(),
938 939 940 941 942 943 944 945 946 947 948 949
                                                 clang_defaultCodeCompleteOptions()));

            if (m_results && m_results->NumResults) {
                QMetaObject::invokeMethod(&s_memberAccessReplacer, "replaceCurrentAccess", Qt::QueuedConnection,
                                          Q_ARG(MemberAccessReplacer::Type, MemberAccessReplacer::DotToArrow));
            }

            m_valid = false;
            return;
        }
    }

950
    // check 'isValidPosition' after parsing the new content
951 952
    auto clangFile = session.file(file);
    if (!isValidPosition(session.unit(), clangFile)) {
953 954 955
        m_valid = false;
        return;
    }
956

957
    m_completionHelper.computeCompletions(session, clangFile, position);
958 959 960 961 962
}

ClangCodeCompletionContext::~ClangCodeCompletionContext()
{
}
963

964
bool ClangCodeCompletionContext::isValidPosition(CXTranslationUnit unit, CXFile file) const
965
{
966
    if (isInsideComment(unit, file, m_position.castToSimpleCursor())) {
Olivier JG's avatar
Olivier JG committed
967
        clangDebug() << "Invalid completion context: Inside comment";
968 969 970
        return false;
    }
    return true;
971 972
}

973
QList<CompletionTreeItemPointer> ClangCodeCompletionContext::completionItems(bool& abort, bool /*fullCompletion*/)
974
{
975 976 977 978
    if (!m_valid || !m_duContext || !m_results) {
        return {};
    }

979 980
    const auto ctx = DUContextPointer(m_duContext->findContextAt(m_position));

Kevin Funk's avatar
Kevin Funk committed
981
    /// Normal completion items, such as 'void Foo::foo()'
982
    QList<CompletionTreeItemPointer> items;
Kevin Funk's avatar
Kevin Funk committed
983 984 985
    /// Stuff like 'Foo& Foo::operator=(const Foo&)', etc. Not regularly used by our users.
    QList<CompletionTreeItemPointer> specialItems;
    /// Macros from the current context
986
    QList<CompletionTreeItemPointer> macros;
Kevin Funk's avatar
Kevin Funk committed
987
    /// Builtins reported by Clang
988
    QList<CompletionTreeItemPointer> builtin;
989

990 991
    // two sets of handled declarations to prevent duplicates and make sure we show
    // all available overloads
992
    QSet<Declaration*> handled;
993 994
    // this is only used for the CXCursor_OverloadCandidate completion items
    QSet<Declaration*> overloadsHandled;
995

996 997
    LookAheadItemMatcher lookAheadMatcher(TopDUContextPointer(ctx->topContext()));

998 999 1000
    // If ctx is/inside the Class context, this represents that context.
    const auto currentClassContext = classDeclarationForContext(ctx, m_position);

Olivier JG's avatar
Olivier JG committed
1001
    clangDebug() << "Clang found" << m_results->NumResults << "completion results";
1002

1003
    for (uint i = 0; i < m_results->NumResults; ++i) {
1004 1005 1006 1007
        if (abort) {
            return {};
        }

1008
        auto result = m_results->Results[i];
1009 1010 1011 1012 1013
        #if CINDEX_VERSION_MINOR >= 30
        const bool isOverloadCandidate = result.CursorKind == CXCursor_OverloadCandidate;
        #else
        const bool isOverloadCandidate = false;
        #endif
1014 1015

        const auto availability = clang_getCompletionAvailability(result.CompletionString);
1016
        if (availability == CXAvailability_NotAvailable) {
1017 1018 1019
            continue;
        }

Kevin Funk's avatar
Kevin Funk committed
1020 1021 1022 1023 1024
        const bool isMacroDefinition = result.CursorKind == CXCursor_MacroDefinition;
        if (isMacroDefinition && m_filters & NoMacros) {
            continue;
        }

1025 1026 1027 1028 1029 1030 1031 1032 1033 1034
        const bool isBuiltin = (result.CursorKind == CXCursor_NotImplemented);
        if (isBuiltin && m_filters & NoBuiltins) {
            continue;
        }

        const bool isDeclaration = !isMacroDefinition && !isBuiltin;
        if (isDeclaration && m_filters & NoDeclarations) {
            continue;
        }

1035
        if (availability == CXAvailability_NotAccessible && (!isDeclaration || !currentClassContext)) {
1036 1037 1038
            continue;
        }

1039
        // the string that would be needed to type, usually the identifier of something. Also we use it as name for code completion declaration items.
1040
        QString typed;
Milian Wolff's avatar
Milian Wolff committed
1041
        // the return type of a function e.g.
1042
        QString resultType;
Milian Wolff's avatar
Milian Wolff committed
1043
        // the replacement text when an item gets executed
1044
        QString replacement;
1045 1046 1047 1048

        QString arguments;

        ArgumentHintItem::CurrentArgumentRange argumentRange;
Milian Wolff's avatar
Milian Wolff committed
1049 1050
        //BEGIN function signature parsing
        // nesting depth of parentheses
1051 1052
        int parenDepth = 0;
        enum FunctionSignatureState {
Milian Wolff's avatar
Milian Wolff committed
1053
            // not yet inside the function signature
1054
            Before,
Milian Wolff's avatar
Milian Wolff committed
1055
            // any token is part of the function signature now
1056
            Inside,
Milian Wolff's avatar
Milian Wolff committed
1057
            // finished parsing the function signature
1058 1059
            After
        };
Milian Wolff's avatar
Milian Wolff committed
1060
        // current state
1061
        FunctionSignatureState signatureState = Before;
Milian Wolff's avatar
Milian Wolff committed
1062
        //END function signature parsing
Kevin Funk's avatar
Kevin Funk committed
1063

Sergey Kalinichev's avatar
Sergey Kalinichev committed
1064 1065 1066 1067 1068 1069 1070 1071 1072 1073
        std::function<void (CXCompletionString)> processChunks = [&] (CXCompletionString completionString) {
            const uint chunks = clang_getNumCompletionChunks(completionString);
            for (uint j = 0; j < chunks; ++j) {
                const auto kind = clang_getCompletionChunkKind(completionString, j);
                if (kind == CXCompletionChunk_Optional) {
                    completionString = clang_getCompletionChunkCompletionString(completionString, j);
                    if (completionString) {
                        processChunks(completionString);
                    }
                    continue;
1074
                }
Sergey Kalinichev's avatar
Sergey Kalinichev committed
1075 1076 1077 1078

                // We don't need function signature for declaration items, we can get it directly from the declaration. Also adding the function signature to the "display" would break the "Detailed completion" option.
                if (isDeclaration && !typed.isEmpty()) {
                    // TODO: When parent context for CXCursor_OverloadCandidate is fixed remove this check
1079
                    if (!isOverloadCandidate) {
Sergey Kalinichev's avatar
Sergey Kalinichev committed
1080 1081 1082
                        break;
                    }
                }
1083

Sergey Kalinichev's avatar
Sergey Kalinichev committed
1084
                const QString string = ClangString(clang_getCompletionChunkText(completionString, j)).toString();
1085

Sergey Kalinichev's avatar
Sergey Kalinichev committed
1086
                switch (kind) {
1087 1088
                case CXCompletionChunk_TypedText:
                    typed = string;
1089
                    replacement += string;
1090 1091 1092 1093 1094
                    break;
                case CXCompletionChunk_ResultType:
                    resultType = string;
                    continue;
                case CXCompletionChunk_Placeholder:
1095
                    if (signatureState == Inside) {
1096
                        arguments += string;
1097
                    }
1098
                    continue;
1099 1100 1101 1102 1103 1104 1105 1106 1107
                case CXCompletionChunk_LeftParen:
                    if (signatureState == Before && !parenDepth) {
                        signatureState = Inside;
                    }
                    parenDepth++;
                    break;
                case CXCompletionChunk_RightParen:
                    --parenDepth;
                    if (signatureState == Inside && !parenDepth) {
1108
                        arguments += QLatin1Char(')');
1109 1110 1111
                        signatureState = After;
                    }
                    break;
1112
                case CXCompletionChunk_Text:
1113
                    if (isOverloadCandidate) {
1114 1115
                        typed += string;
                    }
1116 1117 1118
                    else if (result.CursorKind == CXCursor_EnumConstantDecl) {
                        replacement += string;
                    }
1119 1120 1121
                    else if (result.CursorKind == CXCursor_EnumConstantDecl) {
                        replacement += string;
                    }
1122
                    break;
1123 1124 1125 1126
                case CXCompletionChunk_CurrentParameter:
                    argumentRange.start = arguments.size();
                    argumentRange.end = string.size();
                    break;
1127 1128
                default:
                    break;
Sergey Kalinichev's avatar
Sergey Kalinichev committed
1129 1130 1131 1132
                }
                if (signatureState == Inside) {
                    arguments += string;
                }
1133
            }
Sergey Kalinichev's avatar
Sergey Kalinichev committed
1134 1135 1136
        };

        processChunks(result.CompletionString);
1137

Sergey Kalinichev's avatar
Sergey Kalinichev committed
1138
        // TODO: No closing paren if default parameters present
1139
        if (isOverloadCandidate && !arguments.endsWith(QLatin1Char(')'))) {
Sergey Kalinichev's avatar
Sergey Kalinichev committed
1140 1141
            arguments += QLatin1Char(')');
        }
Kevin Funk's avatar
Kevin Funk committed
1142 1143
        // ellide text to the right for overly long result types (templates especially)
        elideStringRight(resultType, MAX_RETURN_TYPE_STRING_LENGTH);
1144

1145 1146 1147
        static const auto noIcon = QIcon(QStandardPaths::locate(QStandardPaths::GenericDataLocation,
                                                                QStringLiteral("kdevelop/pics/namespace.png")));

Kevin Funk's avatar
Kevin Funk committed
1148
        if (isDeclaration) {
1149 1150 1151 1152 1153 1154 1155 1156
            const Identifier id(typed);
            QualifiedIdentifier qid;
            ClangString parent(clang_getCompletionParent(result.CompletionString, nullptr));
            if (parent.c_str() != nullptr) {
                qid = QualifiedIdentifier(parent.toString());
            }
            qid.push(id);

1157 1158 1159 1160
            if (!isValidCompletionIdentifier(qid)) {
                continue;
            }

1161 1162 1163 1164 1165 1166
            if (isOverloadCandidate && resultType.isEmpty() && parent.isEmpty()) {
                // workaround: find constructor calls for non-namespaced classes
                // TODO: return the namespaced class as parent in libclang
                qid.push(id);
            }

1167
            auto found = findDeclaration(qid, ctx, m_position, isOverloadCandidate ? overloadsHandled : handled);
1168

1169
            CompletionTreeItemPointer item;
1170
            if (found) {
1171 1172 1173 1174 1175 1176 1177
                // TODO: Bug in Clang: protected members from base classes not accessible in derived classes.
                if (availability == CXAvailability_NotAccessible) {
                    if (auto cl = dynamic_cast<ClassMemberDeclaration*>(found)) {
                        if (cl->accessPolicy() != Declaration::Protected) {
                            continue;
                        }

1178
                        auto declarationClassContext = classDeclarationForContext(DUContextPointer(found->context()), m_position);
1179 1180

                        uint steps = 10;
1181
                        auto inheriters = DUChainUtils::inheriters(declarationClassContext, steps);
1182 1183 1184 1185 1186 1187 1188 1189
                        if(!inheriters.contains(currentClassContext)){
                            continue;
                        }
                    } else {
                        continue;
                    }
                }

1190 1191 1192 1193 1194 1195 1196
                DeclarationItem* declarationItem = nullptr;
                if (isOverloadCandidate) {
                    declarationItem = new ArgumentHintItem(found, resultType, typed, arguments, argumentRange);
                    declarationItem->setArgumentHintDepth(1);
                } else {
                    declarationItem = new DeclarationItem(found, typed, resultType, replacement);
                }
1197

1198 1199
                const unsigned int completionPriority = adjustPriorityForDeclaration(found, clang_getCompletionPriority(result.CompletionString));
                const bool bestMatch = completionPriority <= CCP_SuperCompletion;
1200 1201

                //don't set best match property for internal identifiers, also prefer declarations from current file
1202 1203
                const auto isInternal = found->indexedIdentifier().identifier().toString().startsWith(QLatin1String("__"));
                if (bestMatch && !isInternal ) {
Kevin Funk's avatar
Kevin Funk committed
1204
                    const int matchQuality = codeCompletionPriorityToMatchQuality(completionPriority);
1205
                    declarationItem->setMatchQuality(matchQuality);
1206 1207 1208

                    // TODO: LibClang missing API to determine expected code completion type.
                    lookAheadMatcher.addMatchedType(found->indexedType());
1209 1210
                } else {
                    declarationItem->setInheritanceDepth(completionPriority);
1211

1212 1213
                    lookAheadMatcher.addDeclarations(found);
                }
1214 1215 1216
                if ( isInternal ) {
                    declarationItem->markAsUnimportant();
                }
1217

1218
                item = declarationItem;
1219
            } else {
1220
                if (isOverloadCandidate) {
1221
                    // TODO: No parent context for CXCursor_OverloadCandidate items, hence qid is broken -> no declaration found
1222 1223 1224
                    auto ahi = new ArgumentHintItem({}, resultType, typed, arguments, argumentRange);
                    ahi->setArgumentHintDepth(1);
                    item = ahi;