Commit 3bce40c4 authored by Sven Brauch's avatar Sven Brauch

cpp: mark completion items where we don't have much information as unimportant

parent 934c62df
...@@ -363,6 +363,7 @@ public: ...@@ -363,6 +363,7 @@ public:
: CompletionItem<CompletionTreeItem>(display, prefix) : CompletionItem<CompletionTreeItem>(display, prefix)
, m_replacement(replacement) , m_replacement(replacement)
, m_icon(icon) , m_icon(icon)
, m_unimportant(false)
{ {
} }
...@@ -376,12 +377,21 @@ public: ...@@ -376,12 +377,21 @@ public:
if (role == Qt::DecorationRole && index.column() == KTextEditor::CodeCompletionModel::Icon) { if (role == Qt::DecorationRole && index.column() == KTextEditor::CodeCompletionModel::Icon) {
return m_icon; return m_icon;
} }
if (role == KDevelop::CodeCompletionModel::UnimportantItemRole) {
return m_unimportant;
}
return CompletionItem<CompletionTreeItem>::data(index, role, model); return CompletionItem<CompletionTreeItem>::data(index, role, model);
} }
void markAsUnimportant()
{
m_unimportant = true;
}
private: private:
QString m_replacement; QString m_replacement;
QIcon m_icon; QIcon m_icon;
bool m_unimportant;
}; };
/** /**
...@@ -1126,7 +1136,9 @@ QList<CompletionTreeItemPointer> ClangCodeCompletionContext::completionItems(boo ...@@ -1126,7 +1136,9 @@ QList<CompletionTreeItemPointer> ClangCodeCompletionContext::completionItems(boo
#endif #endif
// still, let's trust that Clang found something useful and put it into the completion result list // still, let's trust that Clang found something useful and put it into the completion result list
clangDebug() << "Could not find declaration for" << qid; clangDebug() << "Could not find declaration for" << qid;
item = CompletionTreeItemPointer(new SimpleItem(typed + arguments, resultType, replacement)); auto instance = new SimpleItem(typed + arguments, resultType, replacement);
instance->markAsUnimportant();
item = CompletionTreeItemPointer(instance);
#if CINDEX_VERSION_MINOR >= 30 #if CINDEX_VERSION_MINOR >= 30
} }
#endif #endif
...@@ -1150,7 +1162,9 @@ QList<CompletionTreeItemPointer> ClangCodeCompletionContext::completionItems(boo ...@@ -1150,7 +1162,9 @@ QList<CompletionTreeItemPointer> ClangCodeCompletionContext::completionItems(boo
auto item = CompletionTreeItemPointer(new SimpleItem(typed + arguments, resultType, replacement, icon)); auto item = CompletionTreeItemPointer(new SimpleItem(typed + arguments, resultType, replacement, icon));
macros.append(item); macros.append(item);
} else if (result.CursorKind == CXCursor_NotImplemented) { } else if (result.CursorKind == CXCursor_NotImplemented) {
auto item = CompletionTreeItemPointer(new SimpleItem(typed, resultType, replacement)); auto instance = new SimpleItem(typed, resultType, replacement);
instance->markAsUnimportant();
auto item = CompletionTreeItemPointer(instance);
builtin.append(item); builtin.append(item);
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment