1. 26 Aug, 2019 2 commits
  2. 03 Jul, 2019 1 commit
  3. 26 Jun, 2019 1 commit
  4. 21 Jun, 2019 1 commit
  5. 18 Jun, 2019 1 commit
  6. 16 Jun, 2019 1 commit
  7. 29 Dec, 2018 1 commit
  8. 28 Dec, 2018 1 commit
  9. 11 Dec, 2018 1 commit
  10. 26 Nov, 2018 1 commit
    • Morten Volden's avatar
      Make the filteringstrategy test work on Windows as well. · d46ed701
      Morten Volden authored
      Summary: This requires some changes to some of the regexes used in CompilerFilterStrategy to get to work. Also the test itself is now somewhat more specific about what path type to test on which platform.
      
      Test Plan: Compile the changes on Windows and verify that the test now passes (In Debug mode). Compile the changes on Linux and verify that all tests pass (as before). Verify that the bench number still look reasonable
      
      Reviewers: #kdevelop, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D17098
      
      (cherry picked from commit 35026c08)
      d46ed701
  11. 22 Nov, 2018 1 commit
    • Morten Volden's avatar
      Make the filteringstrategy test work on Windows as well. · 35026c08
      Morten Volden authored
      Summary: This requires some changes to some of the regexes used in CompilerFilterStrategy to get to work. Also the test itself is now somewhat more specific about what path type to test on which platform.
      
      Test Plan: Compile the changes on Windows and verify that the test now passes (In Debug mode). Compile the changes on Linux and verify that all tests pass (as before). Verify that the bench number still look reasonable
      
      Reviewers: #kdevelop, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D17098
      35026c08
  12. 21 Nov, 2018 1 commit
    • Morten Volden's avatar
      Make test outputmodel pass on windows. · 3dae4914
      Morten Volden authored
      Summary: When doing the benchmark test on windows. Make sure that we use windows paths. Otherwise the test will fail (in debug builds) in an assert in util/path.cpp
      
      Test Plan: Run the test in a Windows debug build environment. Before patch it fails. After patch is applied it succeeds. Run test on Linux and see that test stil completes
      
      Reviewers: #kdevelop, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D17077
      3dae4914
  13. 20 Nov, 2018 1 commit
  14. 19 Nov, 2018 1 commit
  15. 25 Oct, 2018 1 commit
  16. 23 Oct, 2018 1 commit
    • Friedrich W. H. Kossebau's avatar
      Generate all kdebugsettings .categories files automatically · 774429d0
      Friedrich W. H. Kossebau authored
      Summary:
      Adds two wrapping variants of the macros
      declare_qt_logging_category() & install_qt_logging_categories()
      which have an argument TYPE to control specific behaviour that
      otherwise is generalized in the wrapping macros to not have to repeat
      any things with every macro call and to ensure consistency, e.g. in
      the used description texts.
      
      The wrapper macros also handle linking things by the matching EXPORT ids,
      so the caller does not have to care for this.
      
      No perfect solution yet, but at least a first working approach to automatic
      generation of the kdebugsettings files.
      
      Test Plan:
      Generated categories files contain same ids with same descriptions as
      before.
      
      Reviewers: #kdevelop, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: kfunk, apol, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D16032
      774429d0
  17. 07 Oct, 2018 1 commit
    • Friedrich W. H. Kossebau's avatar
      Generate kdebugsettings .categories file automatically · b2b1d083
      Friedrich W. H. Kossebau authored
      Summary:
      Done only for kdevplatform to showcase the idea. Would extend also for
      plugins & app once okayed.
      
      Things could be even more simplified by adding another wrapper macro which
      avoid repeating all the patterns.
      
      Test Plan:
      Generated file matches the old manually one (except comments) and is
      installed to same location.
      Build works as before.
      
      Reviewers: #kdevelop, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: kfunk, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D15977
      b2b1d083
  18. 02 Oct, 2018 1 commit
    • Aaron Puchert's avatar
      Make implicit fallthroughs a compiler error, remove unneeded breaks · 3a2f9a9d
      Aaron Puchert authored
      Summary:
      With -Wimplicit-fallthrough the compiler warns about unannotated
      fallthroughs in switch statements. Since it is supported by both GCC and
      Clang, and can easily be fixed by adding Q_FALLTHROUGH() we enable it as
      error.
      
      As a consequence, we don't need to add redundant break statements as
      safety measure. So we also warn about that, but not as error, especially
      since it's only supported on Clang. (As far as I know.)
      
      Reviewers: #kdevelop, kossebau, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: mwolff, apol, kfunk, rjvbb, brauch, mssola, kossebau, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D15694
      3a2f9a9d
  19. 30 Aug, 2018 1 commit
  20. 21 Aug, 2018 1 commit
  21. 17 Aug, 2018 1 commit
  22. 15 Aug, 2018 2 commits
  23. 30 Jul, 2018 1 commit
  24. 18 Jul, 2018 2 commits
  25. 07 Jul, 2018 1 commit
  26. 17 May, 2018 1 commit
  27. 04 Apr, 2018 1 commit
  28. 21 Feb, 2018 1 commit
  29. 19 Dec, 2017 1 commit
    • Aaron Puchert's avatar
      Add -Werror=switch and -Wcovered-switch-default · 2162de4b
      Aaron Puchert authored
      Summary:
      The former ensures that switch statements are adapted when an
      enumeration is changed. The latter encourages to remove the default
      label in fully covered switch statements, making the former more
      effective. (It is silenced by default labels.)
      
      Reviewers: #kdevelop, mwolff
      
      Reviewed By: #kdevelop, mwolff
      
      Subscribers: mwolff, apol, kdevelop-devel
      
      Differential Revision: https://phabricator.kde.org/D9042
      2162de4b
  30. 30 Oct, 2017 1 commit
  31. 29 Sep, 2017 1 commit
  32. 20 Sep, 2017 1 commit
    • Morten Volden's avatar
      Fix for Outoutview CmakeMultiline expression accidentally hits on CMake Error. · ba37d996
      Morten Volden authored
      Summary:
      The expression intended for catching CMakeMultiline errors e.g.:
      
        CMake Error: Error in cmake code at
        /some/path with spaces/to/a/project/CMakeLists.txt:10:
      
      Where the regex would hit on the second line.
      
      Now it also hits on lines such as this:
      
      CMake Error at SecondSubDir/CMakeLists.txt:1:
      
      Which means that the filename is extracted wrong and the user will be sent to a new file instead of the file with the error.
      
      Changed the regex in question and added a unittest that catches this scenario.
      
      Reviewed By: kfunk
      
      Subscribers: volden, kfunk, kdevelop-devel
      
      Differential Revision: https://phabricator.kde.org/D7554
      ba37d996
  33. 06 Sep, 2017 1 commit
    • Axel Kellermann's avatar
      OutputFilteringStrategies: make parsing of cmake output for project directory work on Windows · f31923b6
      Axel Kellermann authored
      Summary:
      This is a follow-up to https://phabricator.kde.org/D7040 and adds support for parsing the cmake project directory on Windows.
      Also relates to https://bugs.kde.org/show_bug.cgi?id=321982.
      
      Changes:
      
      extended regex to filter output as produced on Windows systems
      cmake binary has extension .exe or .bat (in craft environment)
      project paths start with [A-Za-z]: instead of /
      added creation of different styles of Windows paths to testlinebuilderfunctions.h
      modified TestFilteringStrategy::testCompilerFilterstrategyUrlFromAction_data() to also test with Windows paths
      NOTE: it doesn't make sense to test Windows paths on Linux and vice versa, as class Path, that is used to store paths, is not platform agnostic and handles paths differently depending on the system it is compiled for
      instead system specific paths are used during testing, depending on the platform the tests are compiled for
      
      Reviewed By: volden
      
      Subscribers: volden, kdevelop-devel
      
      Differential Revision: https://phabricator.kde.org/D7615
      f31923b6
  34. 28 Aug, 2017 1 commit
    • Morten Volden's avatar
      Fix for Outoutview CmakeMultiline expression accidentally hits on CMake Error. · f5ef5b37
      Morten Volden authored
      Summary:
      The expression intended for catching CMakeMultiline errors e.g.:
      
        CMake Error: Error in cmake code at
        /some/path with spaces/to/a/project/CMakeLists.txt:10:
      
      Where the regex would hit on the second line.
      
      Now it also hits on lines such as this:
      
      CMake Error at SecondSubDir/CMakeLists.txt:1:
      
      Which means that the filename is extracted wrong and the user will be sent to a new file instead of the file with the error.
      
      Changed the regex in question and added a unittest that catches this scenario.
      
      Reviewed By: kfunk
      
      Subscribers: volden, kfunk, kdevelop-devel
      
      Differential Revision: https://phabricator.kde.org/D7554
      f5ef5b37
  35. 23 Aug, 2017 1 commit
    • Axel Kellermann's avatar
      Parse cmake output for project directory and use it in OutputView · 4019dd0e
      Axel Kellermann authored
      Summary:
      Currently OutputFilteringStrategies makes the assumption that the cmake build directory is always one level underneath the project directory. If that assumption isn't met, clicking on a cmake error line does not open the corresponding file (see bug https://bugs.kde.org/show_bug.cgi?id=321982).
      
      This patch adds another filter that reads the absolute path to the project directory from the cmake output. The filter uses application type cd to behave like the other filters that change the build directory.
      
      Reviewers: kfunk, volden
      
      Reviewed By: volden
      
      Subscribers: volden, kfunk, kdevelop-devel
      
      Differential Revision: https://phabricator.kde.org/D7040
      
      BUG: 321982
      4019dd0e