1. 07 Oct, 2018 1 commit
    • Bernd Buschinski's avatar
      Fix discovery of clang builtin directory with clang svn versions · 6da2caac
      Bernd Buschinski authored
      Summary:
      The CLANG_VERSION for svn clang versions have a svn suffix "8.0.0svn" and all the libraries have a svn suffix.
      But not the in builtin include dir. It still points to
      "/usr/lib/clang/8.0.0/include/cpuid.h"
      without the suffix.
      
      Extend the PATH_SUFFIXES to also looks a version without svn suffix.
      
      BUG: 399439
      
      Test Plan:
      - install clang-svn
      - execute cmake .. (for kdevelop)
      -> it will fail
      
      Reviewers: #kdevelop, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D15998
      6da2caac
  2. 06 Oct, 2018 2 commits
  3. 05 Oct, 2018 3 commits
  4. 04 Oct, 2018 5 commits
    • Kevin Funk's avatar
      Move clangBuiltinIncludePath() to different ns · feba4b8a
      Kevin Funk authored
      ClangHelpers seems to be the better fit (it's DUChain agnostic)
      feba4b8a
    • Friedrich W. H. Kossebau's avatar
      Fix calling qdbus by using qt5-current name qdbus-qt5 · f9309d65
      Friedrich W. H. Kossebau authored
      Summary:
      Due to Qt not providing OOTB support for parallel installation of different
      base versions (like Qt4 and Qt5), Linux distributions have separated into
      different approaches how to name the Qt tools like qmake and qdbus.
      Many use -qt4 and -qt5 suffixes and link the normal name to a variant, e.g.
      controlled by a custom tool qtchooser. Others kept the Qt4 versions to stay
      with the names, and only added a suffix -qt5 to the new ones.
      
      Test Plan:
      There is no longer a warning about missing qtdbus in the embedded konsole on
      opening. The commands like search! & Co. work again.
      
      Reviewers: #kdevelop, lbeltrame, fvogt, jriddell, kfunk
      
      Subscribers: kfunk, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D15606
      f9309d65
    • Kevin Funk's avatar
      Minor: Fix stale TODO comment · 300b910e
      Kevin Funk authored
      300b910e
    • Kevin Funk's avatar
      7aa4bfa1
    • Bernd Buschinski's avatar
      Use CLANG_INCLUDE_DIRS for clang include dir · 716372ae
      Bernd Buschinski authored
      Summary:
      Use CLANG_INCLUDE_DIRS for clang include dir instead of manually building it.
      
      This fixes the error:
      kdevplatform.shell: Could not load plugin "kdevclangsupport" , it reported the error: "The clang builtin include path \"/usr/lib64/llvm/7/lib64/clang/7.0.0/include\" is invalid (missing cpuid.h header).\nTry setting the KDEV_CLANG_BUILTIN_DIR environment variable manually to fix this.\nSee also: https://bugs.kde.org/show_bug.cgi?id=393779" Disabling the plugin now.
      
      As CMake with CLANG_INCLUDE_DIRS already tests if this folder is present, it should work across all distros.
      
      CCBUG: 393779
      
      Reviewers: #kdevelop, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: mwolff, aaronpuchert, brauch, kossebau, kfunk, arrowd, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D15895
      716372ae
  5. 03 Oct, 2018 3 commits
    • Friedrich W. H. Kossebau's avatar
      cmake: Avoid rst2html warnings in on-the-fly generated html documentation · beae0686
      Friedrich W. H. Kossebau authored
      Summary:
      rst2html reports warnings about the rst syntax into the generated html,
      unless told to switch to another report level, like with --quiet.
      As the user cannot (or does not want to) do anything about the cmake docs
      when just using them, hide any warnings from them.
      
      Test Plan:
      CMake docs are still shown, now without any rst syntax warnings (e.g. for
      CMake's "project".
      
      Reviewers: #kdevelop, apol, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D15919
      beae0686
    • Aaron Puchert's avatar
      Add missing break in QmlJs code completion · 6652fa0a
      Aaron Puchert authored and Friedrich W. H. Kossebau's avatar Friedrich W. H. Kossebau committed
      The values operator{Start,End} are used in functionCallTips to find the
      m_typeToMatch. The idea is that if we write a + then we want something
      of the same type as a to add to it.
      
      With the fallthrough we apply this for commas as well, so we try to
      match the type before the comma. But function arguments generally do not
      have the same type.
      
      This change was separated from the changes in D15694.
      
      (cherry picked from commit 6b891267)
      6652fa0a
    • Friedrich W. H. Kossebau's avatar
      cmake: fix detecting ids with digits inside on a cursor position · a46bd1c9
      Friedrich W. H. Kossebau authored
      Summary:
      CMakeManager::specialLanguageObjectNavigationWidget() implementation was
      only checking for letters and _, thus not properly detecting ids with digits
      inside, e.g. the CMPxxxx policy ids.
      
      Test Plan:
      Hovering over "CMP0071" in a CMakeLists.txt or presseing Alt now triggers
      the navigation widget with the respective documentation.
      Doing the same for CMake functions and variables still works as before
      
      Reviewers: #kdevelop, apol
      
      Reviewed By: #kdevelop, apol
      
      Subscribers: kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D15911
      a46bd1c9
  6. 01 Oct, 2018 1 commit
    • Kevin Funk's avatar
      cmake: Detect Clang 7 and 8 · 4dba8251
      Kevin Funk authored
      Note: Looks like like recent versions of llvm-config no longer have a minor
      version suffix. Examples:
      - llvm-config-8
      - llvm-config-7
      - llvm-config-6.0
      - ...
      4dba8251
  7. 30 Sep, 2018 1 commit
  8. 28 Sep, 2018 1 commit
    • Amish Naidu's avatar
      Fix removal of external scripts · cef29611
      Amish Naidu authored
      Summary:
      Previously, deleting a script which is in the middle of the config would invalidate indices
      of the scripts that come after it in the config, this would mean deleting
      anything later deletes the wrong script.
      
      The config labels are now stored in the model itself and is no longer based on just the index,
      but on the name of the script. Thus, deleting/updating one script does not interfere with the
      other scripts.
      
      BUG: 385298
      
      Test Plan:
      * Before applying the patch:
       - Delete "Google Selection"
       - Restart
       - Delete "Quick Compile"
       - Restart and check list of external scripts
      
      * Apply the patch and repeat.
      
      Reviewers: #kdevelop, flherne
      
      Reviewed By: #kdevelop, flherne
      
      Subscribers: flherne, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D15743
      cef29611
  9. 27 Sep, 2018 3 commits
  10. 26 Sep, 2018 2 commits
  11. 25 Sep, 2018 2 commits
  12. 22 Sep, 2018 2 commits
  13. 21 Sep, 2018 1 commit
  14. 20 Sep, 2018 11 commits
  15. 19 Sep, 2018 2 commits