GitLab

Clang 3.4 complains:

.../parsesession.cpp:169:36: error: default
initialization of an object of const type 'const
ClangDiagnosticEvaluator' requires a user-provided default constructor
    const ClangDiagnosticEvaluator evaluator;

REVIEW: 117352

1-based row and column numbers.

REVIEW: 117340

Let ClangProblem take care of initializing itself with a CXDiagnostic
instance
=> Better encapsulation of diagnostic-related logic.

Let UnknownDeclarationProblem inherit from ClangProblem
=> UnknownDeclarationProblem can use the fixits provided by clang +
amend own fixits by doing adding items for missing includes.

Add ClangDiagnosticEvaluator, which constructs either a
UnknownDeclarationProblem or a pure ClangProblem for a given diagnostic
-- currently based solely on the diagnostic spelling (whether it
contains some specific strings).

This reduced the number of errors reported for a single issue to a
minimum (e.g. there are no more instances of both
UnknownDeclarationProblem and ClangProblem for a given issue)

Integrate the missing-include assistant in ClangProblem itself,
introduce MissingIncludeProblemResolver class.

Jørgen Kvalsvik authored Apr 06, 2014 and Kevin Funk committed Apr 06, 2014

REVIEW: 117098

Implements the old #include/forward decl support from cpplanguage with
kdev-clang as the base framework.

libclang does not actually enumerate various semantic errors, so the solution
is based on parsing the error message from clang. While it works for some
configurations it is subject to break on languages and on internal clang
changes. Hopefully this situation will change in the future.

See the cfe-dev list for my suggestion to add this feature to libclang:
http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-March/036036.html

Jørgen Kvalsvik authored Apr 06, 2014 and Kevin Funk committed Apr 06, 2014

Trivial, but required patch as latest master broke compilation for me. Raises required libclang version to 3.4 because some functions (such as clang_CXXisPureVirtual) are introduced.

Some functions relies on features from >= 3.4

REVIEW: 117402

Saves us installing another shared library which isn't useful on its
own.

Milian, milian :)

BUG: 333087

REVIEW: 116842

If set to 1, it will enable clang's internal display handling of
diagnostics to stderr.

The default include paths as well as the user defined include paths
can be queried in the background thread. static and C++11 leads to
proper synchonization here for the default include paths.

REVIEW: 115722

Better error reporting, trim whitespaces, etc.

Overwriting the to-be-used llvm-config is now as easy as:
$ export LLVM_ROOT=/usr/lib/llvm-3.4
$ cmake ...

Relate to the parent commit: We want to display the feature log even if
we did not find libclang, hence do a find_package(Clang ...) without the REQUIRED attribute,
and make sure we don't do any "message(FATAL_ERROR ...)" in the find
scripts in that case.

These find scripts are finally getting into shape...

Show that we actually need 'libclang'

REVIEW: 116581

REVIEW: 115992

We don't depend on 'recent-enough' CMake anyway.

David Stevens authored Feb 24, 2014 and Kevin Funk committed Feb 24, 2014

Some variables defined in FindClang.cmake use the wrong names in CMakeLists.txt.

REVIEW: 115860

Much nicer imo...