1. 11 Nov, 2019 1 commit
    • Stefan Brüns's avatar
      Remove flawed noLinks handling for originUrls · 0dacef04
      Stefan Brüns authored
      Summary:
      The original use of noLinks was to provide links to "kfileitem#"
      targets, i.e. internal links only reachable when file indexing was
      enabled (at Nepomuk times).
      
      originUrls on the other hand are web/ftp server URLs, i.e.
      independent from any local indexing.
      
      Test Plan:
        #  Add a originURL to a file:
      
      ```
          $> setfattr -n user.xdg.origin.url -v "http://some.domain/"  test.txt
      
      ```
        # Make file readonly
      
      With the change, the value label shown for originUrl ("Downloaded
      from") stays the same
      
      Reviewers: #baloo, ngraham, astippich
      
      Reviewed By: #baloo, ngraham
      
      Tags: #baloo
      
      Differential Revision: https://phabricator.kde.org/D25238
      0dacef04
  2. 10 Nov, 2019 1 commit
  3. 09 Nov, 2019 1 commit
  4. 08 Nov, 2019 1 commit
  5. 05 Nov, 2019 1 commit
  6. 03 Nov, 2019 1 commit
    • Ismael Asensio's avatar
      [baloo-widgets] Apply condensed date to file metadata properties · 407c537c
      Ismael Asensio authored
      Summary:
      In the dolphin information panel, the condensed date format was not being applied to metadata file properties (i.e EXIF), only to those related to file itself (modified/accessed/..)
      
      BEFORE:
      {F7283072}
      AFTER:
      {F7283073}
      
      BUG: 406832
      
      Test Plan:
      - Open dolphin information panel and hover an image with EXIF info
      - Condensed date option works on all the properties
      
      Reviewers: #dolphin, elvisangelaccio, bruns, meven, ngraham
      
      Reviewed By: #dolphin, meven, ngraham
      
      Subscribers: meven, ngraham, bruns, #baloo
      
      Tags: #baloo, #dolphin
      
      Differential Revision: https://phabricator.kde.org/D23475
      407c537c
  7. 20 Oct, 2019 1 commit
  8. 11 Oct, 2019 3 commits
  9. 09 Oct, 2019 1 commit
    • Méven Car's avatar
      Don't count hidden files in folder item count · e72b3d7e
      Méven Car authored
      Summary:
      Add a field "Hidden items" to display the number of hidden items, allowing the user to show or hide it.
      
      FIXED-IN: 19.12
      BUG: 412396
      
      Reviewers: ngraham, bruns, elvisangelaccio
      
      Reviewed By: ngraham, elvisangelaccio
      
      Subscribers: alexde, elvisangelaccio, cfeck, #baloo
      
      Tags: #baloo
      
      Differential Revision: https://phabricator.kde.org/D24362
      e72b3d7e
  10. 06 Oct, 2019 1 commit
  11. 21 Sep, 2019 1 commit
  12. 14 Sep, 2019 2 commits
  13. 01 Sep, 2019 1 commit
  14. 24 Aug, 2019 1 commit
  15. 09 Aug, 2019 1 commit
  16. 31 Jul, 2019 2 commits
  17. 29 Jul, 2019 1 commit
  18. 28 Jul, 2019 1 commit
    • Méven Car's avatar
      Do not display a buggy filesize for non local files · 1ad5a37b
      Méven Car authored
      Summary:
      When displaying a virtual folder or remote drive the folder size in the information panel is wrong.
      The subDirectoriesCount function supports only local files.
      It creates a bug where when a url such as recentdocuments:/ is displayed in dolphin, the count reflected in the size field is in fact the count of its path meaning the number of files in the root folder /.
      
      Test Plan: Manual
      
      Reviewers: #dolphin, ngraham, elvisangelaccio
      
      Reviewed By: #dolphin, elvisangelaccio
      
      Subscribers: #baloo
      
      Tags: #baloo
      
      Differential Revision: https://phabricator.kde.org/D22529
      1ad5a37b
  19. 15 Jul, 2019 2 commits
  20. 07 Jul, 2019 1 commit
  21. 05 Jul, 2019 1 commit
  22. 01 Jul, 2019 1 commit
  23. 29 Jun, 2019 1 commit
  24. 23 Jun, 2019 1 commit
    • Alexander Stippich's avatar
      Rework sorting of properties · b9fcf84f
      Alexander Stippich authored
      Summary:
      Rework sorting of properties in the file
      information panel and tooltips.
      Rename "audio" and "music" sorting key to "media" as
      they are also used for videos and images.
      
      Final piece for
      
      BUG: 343273
      
      Reviewers: ngraham, bruns
      
      Reviewed By: ngraham
      
      Subscribers: #baloo
      
      Tags: #baloo
      
      Differential Revision: https://phabricator.kde.org/D22024
      b9fcf84f
  25. 16 Jun, 2019 1 commit
  26. 11 Jun, 2019 1 commit
  27. 10 Jun, 2019 1 commit
  28. 05 Jun, 2019 1 commit
  29. 30 May, 2019 2 commits
    • Alexander Stippich's avatar
      Cleanup default filters for baloo-widgets · 3983d807
      Alexander Stippich authored
      Summary:
      The property names do not match any names defined in KFileMetaData.
      While the intention of the previous filters clearly was to hide most of the EXIF information,
      users seem to use the provided information (see bug report), so show most of it.
      Hide photo metering mode, photo sharpness and white balance, as they seem to be quite useless.
      
      CCBUG: 343273
      
      Reviewers: ngraham, bruns
      
      Reviewed By: bruns
      
      Subscribers: #baloo
      
      Tags: #baloo
      
      Differential Revision: https://phabricator.kde.org/D21413
      3983d807
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · c1b1555a
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      c1b1555a
  30. 27 May, 2019 1 commit
  31. 22 May, 2019 1 commit
  32. 05 May, 2019 2 commits
    • Stefan Brüns's avatar
      [FileMetaDataProvider] Actually check if the file can be modified · 9bb30370
      Stefan Brüns authored
      Summary:
      Adding tags etc. requires the file to be writable, so disallow editing
      for readonly files.
      
      Depends on D20980
      
      Test Plan:
      1. Add a tag to some file
      2. Remove write permissions
      3. The tag is still shown, but can no longer be edited
      
      Reviewers: #baloo, astippich, ngraham
      
      Reviewed By: #baloo, ngraham
      
      Tags: #baloo
      
      Differential Revision: https://phabricator.kde.org/D20981
      9bb30370
    • Stefan Brüns's avatar
      [FileMetaDataProvider] Move readOnly check into the fetch jobs · 6f8d9d1c
      Stefan Brüns authored
      Summary:
      UserMetaData::isSupported() is blocking, so it should be done
      asynchronously. Also, the jobs already instantiate a UserMetaData for
      each file, so doing it twice is wasteful.
      
      Instead of doing the check in the widget class and pushing it to the
      provider, let the provider determine if the file attributes can be
      modified and forward the result to the widget factory after the provider
      has finished.
      
      Do not check if the file is local twice, once in the provider is
      sufficient.
      
      Remove one bogus test case.
      
      Depends on D20979
      
      Test Plan: ctest
      
      Reviewers: #baloo, astippich, ngraham
      
      Reviewed By: astippich
      
      Tags: #baloo
      
      Differential Revision: https://phabricator.kde.org/D20980
      6f8d9d1c
  33. 04 May, 2019 1 commit