1. 03 Dec, 2019 1 commit
  2. 13 Nov, 2019 4 commits
    • Stefan Brüns's avatar
      Remove no longer used IndexedDataRetriever · a735a5ae
      Stefan Brüns authored
      Summary:
      There are no users left, remove it.
      
      Depends on D25250
      
      Reviewers: #baloo, ngraham, astippich
      
      Reviewed By: #baloo, ngraham, astippich
      
      Tags: #baloo
      
      Differential Revision: https://phabricator.kde.org/D25251
      a735a5ae
    • Stefan Brüns's avatar
      Use realtime indexing as fallback when DB has no property data · d202cc38
      Stefan Brüns authored
      Summary:
      In case the DB provides no data, try to fetch the properties directly
      from the file using the new OnDemandIndexer class.
      
      If required, start the extractor in the background, fetch UserMetaData
      and wait for the extractor, then unite the results.
      
      BUG: 410114
      Depends on D25248
      
      Test Plan:
        # suspend baloo (`balooctl suspend`)
        # copy a file with properties (e.g. PNG) to a included location
          `cp ~/foo.png ~/foo_2.png`
        # `balooshow ~/foo.png ~/foo_2.png` should only display "Cached properties"
           for the original file
        # dolphin displays properties for both files (in the side panel)
      
      Reviewers: #baloo, ngraham, astippich
      
      Reviewed By: #baloo, ngraham, astippich
      
      Tags: #baloo
      
      Differential Revision: https://phabricator.kde.org/D25250
      d202cc38
    • Stefan Brüns's avatar
      Split handling of on-demand extractor process from IndexedDataRetriever · 064f4f2b
      Stefan Brüns authored
      Summary:
      To allow a unification of the IndexedDataRetriever job and FileFetchJob,
      move the process handling into a separate class and only keep
      the UserMetaData handling.
      
      As a small optimization, interleave the forking of the external process,
      UserMetaData retrieval and joining of the external process. Also reuse
      the QFileInfo in the constructor to determine if the file is writable and
      thus has editable metadata.
      
      Beyond the optimization, no user visible changes.
      
      Depends on D25247
      
      Test Plan:
      When using a location not indexed by baloo, metadata is
      still shown as before
      
      Reviewers: #baloo, ngraham, astippich
      
      Reviewed By: #baloo, ngraham, astippich
      
      Tags: #baloo
      
      Differential Revision: https://phabricator.kde.org/D25248
      064f4f2b
    • Stefan Brüns's avatar
      Add categorized logging for baloo-widgets · bb533b2d
      Stefan Brüns authored
      Summary: Add logging category "org.kde.baloo.widgets".
      
      Reviewers: #baloo, astippich, ngraham
      
      Reviewed By: #baloo, astippich, ngraham
      
      Tags: #baloo
      
      Differential Revision: https://phabricator.kde.org/D25247
      bb533b2d
  3. 11 Nov, 2019 4 commits
    • Stefan Brüns's avatar
      Fix value label mouse/keyboard interaction · c20dc3cb
      Stefan Brüns authored
      Summary:
      After commit e5cc92b8 ("Make text from Dolphin's information panel
      copyable") links were no longer activatable, and the full URL is not
      retrievable in case the target was partially ellided. Set
      TextBrowserInteraction for links. This implicitly creates a "Copy Link
      Location" entry in the Context Menu.
      
      Also remove the TextSelectableByKeyboard flag - this implicitly creates
      a cursor "|" symbol whenever one of the labels is clicked, and the cursor
      can not be removed again (only by selecting a different file). The text is
      still selectable using the mouse.
      
      Depends on D25240
      
      Reviewers: #baloo, ngraham, astippich
      
      Reviewed By: #baloo, ngraham
      
      Tags: #baloo
      
      Differential Revision: https://phabricator.kde.org/D25241
      c20dc3cb
    • Stefan Brüns's avatar
      Prevent HTML injection in labels from unchecked sources · 4cb94129
      Stefan Brüns authored
      Summary:
      Properties from arbitrary sources may contain any character, also
      valid Qt richtext (HTML subset) sequences. In best case, this only
      causes parsing and display issues, but may also inject malicious links:
      <a href="http://malicous.domain/">unconspicious</a>.
      
      The originUrl value is not affected, as QUrl percent-encodes '<' and '>',
      thus can not contain any HTML tags. Explicitly cast the originUrl
      QVariant to QUrl, which is always valid for values coming from KFileMetadata.
      
      This affects all versions prior to 19.08.00. D21470 accidentally disabled
      interactive links in the labels, thus malicious links are disabled.
      
      Depends on D25239
      
      Test Plan:
      # Create a document with e.g. a title resembling HTML tags
      # Text should be rendered verbatirm
      
      Reviewers: #baloo, ngraham, astippich
      
      Reviewed By: #baloo, ngraham
      
      Tags: #baloo
      
      Differential Revision: https://phabricator.kde.org/D25240
      4cb94129
    • Stefan Brüns's avatar
      Do not mangle angle brackets in value widgets · 84a0d9b2
      Stefan Brüns authored
      Summary:
      When some value contains a opening angle bracket "<", any enclosed
      text up to the closing ">" is removed from the value.
      
      The mangling only happened for files which are readonly, making the
      behavior even more awkward.
      
      As any text properties a always plain text, remove the stripping
      also for readonly files.
      
      Depends on D25238
      
      The stripping in the ValueWidget sizeHint is broken as well,
      in case the value is PlainText, it would strip regular text from
      the size calculation (creating a too narrow widget), for RichText
      the sizeHint without stripping is too wide, but the layout
      engine wraps the content correctly (it's a hint, after all).
      
      As there are no users for the plainText function left, remove it.
      
      Test Plan:
      To expose the broken behavior:
      # Create a document (.odt, html) with a '<' in e.g. the Title
      # Make the file readonly -> everything after '<' vanishes
      
      With the fix, the content is fully kept.
      
      Reviewers: #baloo, ngraham, astippich
      
      Reviewed By: #baloo, ngraham
      
      Tags: #baloo
      
      Differential Revision: https://phabricator.kde.org/D25239
      84a0d9b2
    • Stefan Brüns's avatar
      Remove flawed noLinks handling for originUrls · 0dacef04
      Stefan Brüns authored
      Summary:
      The original use of noLinks was to provide links to "kfileitem#"
      targets, i.e. internal links only reachable when file indexing was
      enabled (at Nepomuk times).
      
      originUrls on the other hand are web/ftp server URLs, i.e.
      independent from any local indexing.
      
      Test Plan:
        #  Add a originURL to a file:
      
      ```
          $> setfattr -n user.xdg.origin.url -v "http://some.domain/"  test.txt
      
      ```
        # Make file readonly
      
      With the change, the value label shown for originUrl ("Downloaded
      from") stays the same
      
      Reviewers: #baloo, ngraham, astippich
      
      Reviewed By: #baloo, ngraham
      
      Tags: #baloo
      
      Differential Revision: https://phabricator.kde.org/D25238
      0dacef04
  4. 10 Nov, 2019 1 commit
  5. 09 Nov, 2019 1 commit
  6. 08 Nov, 2019 1 commit
  7. 05 Nov, 2019 1 commit
  8. 03 Nov, 2019 1 commit
    • Ismael Asensio's avatar
      [baloo-widgets] Apply condensed date to file metadata properties · 407c537c
      Ismael Asensio authored
      Summary:
      In the dolphin information panel, the condensed date format was not being applied to metadata file properties (i.e EXIF), only to those related to file itself (modified/accessed/..)
      
      BEFORE:
      {F7283072}
      AFTER:
      {F7283073}
      
      BUG: 406832
      
      Test Plan:
      - Open dolphin information panel and hover an image with EXIF info
      - Condensed date option works on all the properties
      
      Reviewers: #dolphin, elvisangelaccio, bruns, meven, ngraham
      
      Reviewed By: #dolphin, meven, ngraham
      
      Subscribers: meven, ngraham, bruns, #baloo
      
      Tags: #baloo, #dolphin
      
      Differential Revision: https://phabricator.kde.org/D23475
      407c537c
  9. 20 Oct, 2019 1 commit
  10. 11 Oct, 2019 3 commits
  11. 09 Oct, 2019 1 commit
    • Méven Car's avatar
      Don't count hidden files in folder item count · e72b3d7e
      Méven Car authored
      Summary:
      Add a field "Hidden items" to display the number of hidden items, allowing the user to show or hide it.
      
      FIXED-IN: 19.12
      BUG: 412396
      
      Reviewers: ngraham, bruns, elvisangelaccio
      
      Reviewed By: ngraham, elvisangelaccio
      
      Subscribers: alexde, elvisangelaccio, cfeck, #baloo
      
      Tags: #baloo
      
      Differential Revision: https://phabricator.kde.org/D24362
      e72b3d7e
  12. 06 Oct, 2019 1 commit
  13. 21 Sep, 2019 1 commit
  14. 14 Sep, 2019 2 commits
  15. 01 Sep, 2019 1 commit
  16. 24 Aug, 2019 1 commit
  17. 09 Aug, 2019 1 commit
  18. 31 Jul, 2019 2 commits
  19. 29 Jul, 2019 1 commit
  20. 28 Jul, 2019 1 commit
    • Méven Car's avatar
      Do not display a buggy filesize for non local files · 1ad5a37b
      Méven Car authored
      Summary:
      When displaying a virtual folder or remote drive the folder size in the information panel is wrong.
      The subDirectoriesCount function supports only local files.
      It creates a bug where when a url such as recentdocuments:/ is displayed in dolphin, the count reflected in the size field is in fact the count of its path meaning the number of files in the root folder /.
      
      Test Plan: Manual
      
      Reviewers: #dolphin, ngraham, elvisangelaccio
      
      Reviewed By: #dolphin, elvisangelaccio
      
      Subscribers: #baloo
      
      Tags: #baloo
      
      Differential Revision: https://phabricator.kde.org/D22529
      1ad5a37b
  21. 15 Jul, 2019 2 commits
  22. 07 Jul, 2019 1 commit
  23. 05 Jul, 2019 1 commit
  24. 01 Jul, 2019 1 commit
  25. 29 Jun, 2019 1 commit
  26. 23 Jun, 2019 1 commit
    • Alexander Stippich's avatar
      Rework sorting of properties · b9fcf84f
      Alexander Stippich authored
      Summary:
      Rework sorting of properties in the file
      information panel and tooltips.
      Rename "audio" and "music" sorting key to "media" as
      they are also used for videos and images.
      
      Final piece for
      
      BUG: 343273
      
      Reviewers: ngraham, bruns
      
      Reviewed By: ngraham
      
      Subscribers: #baloo
      
      Tags: #baloo
      
      Differential Revision: https://phabricator.kde.org/D22024
      b9fcf84f
  27. 16 Jun, 2019 1 commit
  28. 11 Jun, 2019 1 commit
  29. 10 Jun, 2019 1 commit