1. 07 Apr, 2019 1 commit
    • Nicolas Fella's avatar
      [tagsaction] Don't crash on multiple files · 96505aed
      Nicolas Fella authored
      Summary:
      Tagging multiple files is not supported and thus we never create m_metadata for it. However, we start the tags listing  and as soon as tags are found m_metadata is accesses which results in a crash.
      
      This patch delays the tags listing until m_metadata has been initialized
      
      BUG: 401733
      
      Test Plan: Select multiple files in Dolphin, right click -> no crash
      
      Reviewers: elvisangelaccio
      
      Reviewed By: elvisangelaccio
      
      Subscribers: #baloo
      
      Tags: #baloo
      
      Differential Revision: https://phabricator.kde.org/D20361
      96505aed
  2. 31 Mar, 2019 1 commit
  3. 24 Mar, 2019 1 commit
  4. 22 Mar, 2019 1 commit
  5. 16 Mar, 2019 1 commit
  6. 01 Mar, 2019 1 commit
  7. 27 Feb, 2019 1 commit
  8. 24 Feb, 2019 2 commits
  9. 30 Jan, 2019 1 commit
  10. 23 Jan, 2019 1 commit
  11. 20 Jan, 2019 1 commit
  12. 14 Jan, 2019 1 commit
  13. 13 Jan, 2019 1 commit
  14. 05 Jan, 2019 1 commit
  15. 28 Dec, 2018 1 commit
  16. 27 Dec, 2018 2 commits
  17. 26 Dec, 2018 1 commit
  18. 21 Dec, 2018 1 commit
  19. 12 Dec, 2018 1 commit
  20. 10 Dec, 2018 1 commit
  21. 07 Dec, 2018 1 commit
    • Kai Uwe Broulik's avatar
      Initialize m_metaData · 3695e0b0
      Kai Uwe Broulik authored
      A new KFileMetaData::UserMetaData is only created when a single file is selected.
      If more files are selected, we will call delete on garbage memory in the destructor and crash.
      Calling delete on a nullptr is safe.
      
      BUG: 401733
      
      Differential Revision: https://phabricator.kde.org/D17348
      3695e0b0
  22. 05 Dec, 2018 2 commits
  23. 04 Dec, 2018 1 commit
  24. 03 Dec, 2018 1 commit
  25. 02 Dec, 2018 2 commits
  26. 01 Dec, 2018 1 commit
  27. 29 Nov, 2018 1 commit
  28. 26 Nov, 2018 1 commit
  29. 23 Nov, 2018 1 commit
  30. 21 Nov, 2018 1 commit
  31. 20 Nov, 2018 1 commit
  32. 19 Nov, 2018 1 commit
  33. 18 Nov, 2018 2 commits
  34. 17 Nov, 2018 1 commit
  35. 16 Nov, 2018 1 commit