1. 09 Oct, 2019 1 commit
    • Méven Car's avatar
      Don't count hidden files in folder item count · e72b3d7e
      Méven Car authored
      Summary:
      Add a field "Hidden items" to display the number of hidden items, allowing the user to show or hide it.
      
      FIXED-IN: 19.12
      BUG: 412396
      
      Reviewers: ngraham, bruns, elvisangelaccio
      
      Reviewed By: ngraham, elvisangelaccio
      
      Subscribers: alexde, elvisangelaccio, cfeck, #baloo
      
      Tags: #baloo
      
      Differential Revision: https://phabricator.kde.org/D24362
      e72b3d7e
  2. 21 Sep, 2019 1 commit
  3. 14 Sep, 2019 2 commits
  4. 24 Aug, 2019 1 commit
  5. 31 Jul, 2019 1 commit
  6. 28 Jul, 2019 1 commit
    • Méven Car's avatar
      Do not display a buggy filesize for non local files · 1ad5a37b
      Méven Car authored
      Summary:
      When displaying a virtual folder or remote drive the folder size in the information panel is wrong.
      The subDirectoriesCount function supports only local files.
      It creates a bug where when a url such as recentdocuments:/ is displayed in dolphin, the count reflected in the size field is in fact the count of its path meaning the number of files in the root folder /.
      
      Test Plan: Manual
      
      Reviewers: #dolphin, ngraham, elvisangelaccio
      
      Reviewed By: #dolphin, elvisangelaccio
      
      Subscribers: #baloo
      
      Tags: #baloo
      
      Differential Revision: https://phabricator.kde.org/D22529
      1ad5a37b
  7. 15 Jul, 2019 1 commit
  8. 07 Jul, 2019 1 commit
  9. 05 Jul, 2019 1 commit
  10. 01 Jul, 2019 1 commit
  11. 29 Jun, 2019 1 commit
  12. 23 Jun, 2019 1 commit
    • Alexander Stippich's avatar
      Rework sorting of properties · b9fcf84f
      Alexander Stippich authored
      Summary:
      Rework sorting of properties in the file
      information panel and tooltips.
      Rename "audio" and "music" sorting key to "media" as
      they are also used for videos and images.
      
      Final piece for
      
      BUG: 343273
      
      Reviewers: ngraham, bruns
      
      Reviewed By: ngraham
      
      Subscribers: #baloo
      
      Tags: #baloo
      
      Differential Revision: https://phabricator.kde.org/D22024
      b9fcf84f
  13. 16 Jun, 2019 1 commit
  14. 11 Jun, 2019 1 commit
  15. 10 Jun, 2019 1 commit
  16. 05 Jun, 2019 1 commit
  17. 30 May, 2019 2 commits
    • Alexander Stippich's avatar
      Cleanup default filters for baloo-widgets · 3983d807
      Alexander Stippich authored
      Summary:
      The property names do not match any names defined in KFileMetaData.
      While the intention of the previous filters clearly was to hide most of the EXIF information,
      users seem to use the provided information (see bug report), so show most of it.
      Hide photo metering mode, photo sharpness and white balance, as they seem to be quite useless.
      
      CCBUG: 343273
      
      Reviewers: ngraham, bruns
      
      Reviewed By: bruns
      
      Subscribers: #baloo
      
      Tags: #baloo
      
      Differential Revision: https://phabricator.kde.org/D21413
      3983d807
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · c1b1555a
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      c1b1555a
  18. 27 May, 2019 1 commit
  19. 22 May, 2019 1 commit
  20. 05 May, 2019 2 commits
    • Stefan Brüns's avatar
      [FileMetaDataProvider] Actually check if the file can be modified · 9bb30370
      Stefan Brüns authored
      Summary:
      Adding tags etc. requires the file to be writable, so disallow editing
      for readonly files.
      
      Depends on D20980
      
      Test Plan:
      1. Add a tag to some file
      2. Remove write permissions
      3. The tag is still shown, but can no longer be edited
      
      Reviewers: #baloo, astippich, ngraham
      
      Reviewed By: #baloo, ngraham
      
      Tags: #baloo
      
      Differential Revision: https://phabricator.kde.org/D20981
      9bb30370
    • Stefan Brüns's avatar
      [FileMetaDataProvider] Move readOnly check into the fetch jobs · 6f8d9d1c
      Stefan Brüns authored
      Summary:
      UserMetaData::isSupported() is blocking, so it should be done
      asynchronously. Also, the jobs already instantiate a UserMetaData for
      each file, so doing it twice is wasteful.
      
      Instead of doing the check in the widget class and pushing it to the
      provider, let the provider determine if the file attributes can be
      modified and forward the result to the widget factory after the provider
      has finished.
      
      Do not check if the file is local twice, once in the provider is
      sufficient.
      
      Remove one bogus test case.
      
      Depends on D20979
      
      Test Plan: ctest
      
      Reviewers: #baloo, astippich, ngraham
      
      Reviewed By: astippich
      
      Tags: #baloo
      
      Differential Revision: https://phabricator.kde.org/D20980
      6f8d9d1c
  21. 04 May, 2019 1 commit
  22. 03 May, 2019 8 commits
  23. 02 May, 2019 2 commits
    • Stefan Brüns's avatar
      [UserMetaData] Consolidate UserMetaData conversion to common implementation · 96828a40
      Stefan Brüns authored
      Summary:
      The conversion from UserMetaData tags/rating etc. was implemented in both
      the standalone temporary extractor and for the baloo DB cached code path,
      although the standalone implementation lacked support for the originUrl
      entry.
      
      Consolidate the implementations to a common helper, and move the call
      from the standalone extractor process to its calling job. This avoids
      the need to serialize the data, doing it from the job context avoids
      blocking the UI.
      
      Test Plan: ctest
      
      Reviewers: #baloo, astippich, ngraham
      
      Reviewed By: astippich
      
      Tags: #baloo
      
      Differential Revision: https://phabricator.kde.org/D20956
      96828a40
    • Stefan Brüns's avatar
      [Extractor] Show file URL when temporary extractor crashes · bd88018e
      Stefan Brüns authored
      Summary:
      KCrash only tells if the indexer has crashed, but it may be completely
      non-obvious which file caused the crash. Issue a warning in this case.
      
      Test Plan:
      1. move a known bad file to a non-indexed location
      2. select the file in dolphin
      
      Reviewers: #baloo, astippich, ngraham
      
      Reviewed By: #baloo, ngraham
      
      Tags: #baloo
      
      Differential Revision: https://phabricator.kde.org/D20954
      bd88018e
  24. 30 Apr, 2019 3 commits
  25. 29 Apr, 2019 2 commits
  26. 28 Apr, 2019 1 commit