Commit 4b929f16 authored by Michael Heidelbach's avatar Michael Heidelbach

Remove dataavailable signal

Summary: The dataavailable signal is not needed

Reviewers: elvisangelaccio, #dolphin, #baloo

Reviewed By: elvisangelaccio

Tags: #baloo

Differential Revision: https://phabricator.kde.org/D10833
parent ef8e7ad2
......@@ -319,7 +319,6 @@ void FileMetaDataProvider::setFileItem()
insertBasicData();
insertEditableData();
emit dataAvailable();
IndexedDataRetriever *ret = new IndexedDataRetriever(filePath, this);
connect(ret, SIGNAL(finished(KJob*)), this, SLOT(slotLoadingFinished(KJob*)));
......@@ -350,7 +349,6 @@ void FileMetaDataProvider::setFileItems()
if (!urls.isEmpty()) {
insertBasicData();
emit dataAvailable();
FileFetchJob* job = new FileFetchJob(urls, this);
connect(job, SIGNAL(finished(KJob*)), this, SLOT(slotFileFetchFinished(KJob*)));
......
......@@ -109,11 +109,6 @@ Q_SIGNALS:
* after data loading is finished.
*/
void loadingFinished();
/**
* Indicates data changes.
* Can be emitted zero or more times
*/
void dataAvailable();
private Q_SLOTS:
void slotLoadingFinished(KJob* job);
......
......@@ -63,7 +63,6 @@ public:
void deleteRows();
void slotLoadingFinished();
void slotDataAvailable();
void slotLinkActivated(const QString& link);
void slotDataChangeStarted();
void slotDataChangeFinished();
......@@ -95,7 +94,6 @@ FileMetaDataWidget::Private::Private(FileMetaDataWidget* parent)
// TODO: If KFileMetaDataProvider might get a public class in future KDE releases,
// the following code should be moved into KFileMetaDataWidget::setModel():
m_provider = new FileMetaDataProvider(q);
connect(m_provider, SIGNAL(dataAvailable()), q, SLOT(slotDataAvailable()));
connect(m_provider, SIGNAL(loadingFinished()), q, SLOT(slotLoadingFinished()));
}
......@@ -114,12 +112,6 @@ void FileMetaDataWidget::Private::deleteRows()
}
void FileMetaDataWidget::Private::slotLoadingFinished()
{
slotDataAvailable();
emit q->metaDataRequestFinished(m_provider->items());
}
void FileMetaDataWidget::Private::slotDataAvailable()
{
deleteRows();
......@@ -169,6 +161,7 @@ void FileMetaDataWidget::Private::slotDataAvailable()
}
q->updateGeometry();
emit q->metaDataRequestFinished(m_provider->items());
}
......
......@@ -80,7 +80,6 @@ private:
Private* d;
Q_PRIVATE_SLOT(d, void slotLoadingFinished())
Q_PRIVATE_SLOT(d, void slotDataAvailable())
Q_PRIVATE_SLOT(d, void slotLinkActivated(QString))
Q_PRIVATE_SLOT(d, void slotDataChangeStarted())
Q_PRIVATE_SLOT(d, void slotDataChangeFinished())
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment