Members of the KDE Community are recommended to subscribe to the kde-community mailing list at https://mail.kde.org/mailman/listinfo/kde-community to allow them to participate in important discussions and receive other important announcements

Commit a81ceaea authored by Michael Heidelbach's avatar Michael Heidelbach

baloo-widgets: Refactor filemetadataprovider for better readability

Summary:
Prepare fixing bug 388583
Make signal emission more obvious
Make it easier to distinguish synchronous and asynchronous parts

CCBUG: 388583

Test Plan:
Visual inspection
Make test

Reviewers: elvisangelaccio, ngraham, vhanda, smithjd, #dolphin, #frameworks

Reviewed By: elvisangelaccio

Differential Revision: https://phabricator.kde.org/D10105
parent 059d2ce9
This diff is collapsed.
......@@ -116,10 +116,29 @@ private Q_SLOTS:
void slotLoadingFinished(KJob* job);
void slotFileFetchFinished(KJob* job);
private:
void insertBasicData();
void insertEditableData();
void setFileItem();
void setFileItems();
/**
* Insert intersection of common data of \p files
*/
void insertCommonData(const QList<QVariantMap>& files);
private:
/**
* Insert basic data of a single file
*/
void insertSingleFileBasicData();
/**
* Insert basic data of a list of files
*/
void insertFilesListBasicData();
/**
* Checks for the existance of \p uri in \p allProperties, and accordingly
* inserts the total integer value of that property in m_data. On completion
......@@ -127,7 +146,7 @@ private:
*/
void totalPropertyAndInsert(const QString& prop, const QList<QVariantMap>& resources,
QSet<QString>& allProperties);
/*
* @return The number of subdirectories for the directory \a path.
*/
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment