1. 05 Apr, 2021 2 commits
  2. 21 Mar, 2021 2 commits
  3. 20 Mar, 2021 3 commits
    • David Faure's avatar
      The recent commit "generalize to comma" was about a simplification. · cf53d9f8
      David Faure authored
      => move that feature to simplifiedExpression. No reason to generate
      errors due to "Mo 12:00-15:00, Mo 18:00-24:00".
      But we can simplify this when we get a chance to modify it.
      cf53d9f8
    • David Faure's avatar
      Add simplifiedExpression() · 16292639
      David Faure authored
      This simplifies the expression if possible:
      - Mo 08:00-13:00; Tu 08:00-13:00
      + Mo,Tu 08:00-13:00
      
      Doing this inside normalizedExpression() would create many more Osmose
      errors than necessary. Better differenciate normalization (which helps
      detecting invalid input) and simplification (which is more about setting
      the best possible expression if we're modifying it anyway).
      
      This comes from the fact that I got comments on changesets where
      I was setting a non-simplified expression. It's all the same to
      computers, but humans find the simplified version more readable/logical.
      16292639
    • David Faure's avatar
      b96e0800
  4. 17 Mar, 2021 2 commits
    • David Faure's avatar
      363cd007
    • David Faure's avatar
      autocorrect wrong use of ';' where ',' was expected · 26569483
      David Faure authored
      We can detect the common case of
      - Mo-Sa 12:00-15:00; 18:00-24:00
      + Mo-Sa 12:00-15:00,18:00-24:00
      based on the fact that the second rule has no time selector.
      
      The JS evaluation_tool doesn't do this autocorrect though, and
      adds the two time ranges (as if "Mo-Sa 12:00-15:00, Mo-Su 18:00-24:00")
      rather than overwriting the first rule with the second as I thought would happen.
      
      It's still very unlikely that this is what the author meant though...
      
      Do the same in case of identical weekdays (and no other selector):
      - Mo-Sa 12:00-15:00; Mo-Sa 18:00-24:00
      + Mo-Sa 12:00-15:00,18:00-24:00
      26569483
  5. 14 Mar, 2021 1 commit
    • Volker Krause's avatar
      Don't do error recovery between two wrongly ordered wide range selectors · e98ae54b
      Volker Krause authored
      We end up in this path e.g. for wrong date formats, and since all parts
      are technically valid, error recovery tried to piece something together
      out of those. The current check for things being in the right order is
      far from complete, but we can extend that as needed, we aren't accepting
      more input than before due to this.
      e98ae54b
  6. 13 Mar, 2021 1 commit
  7. 07 Mar, 2021 1 commit
  8. 22 Feb, 2021 1 commit
  9. 21 Feb, 2021 4 commits
  10. 20 Feb, 2021 1 commit
    • David Faure's avatar
      Add abbreviated French days · 4f54362b
      David Faure authored
      This adds
      Ma, Me, Je, Ve
      (but not Mar because of March)
      
      AFAICS they don't conflict with other languages,
      and Me+Ve also work for italian.
      4f54362b
  11. 14 Feb, 2021 1 commit
  12. 13 Feb, 2021 2 commits
  13. 25 Jan, 2021 1 commit
  14. 24 Jan, 2021 1 commit
  15. 23 Jan, 2021 1 commit
  16. 20 Jan, 2021 1 commit
  17. 19 Jan, 2021 1 commit
  18. 17 Jan, 2021 1 commit
    • David Faure's avatar
      Add two more unittests just to make sure. · c60b6edc
      David Faure authored
      They pass, but somehow osmose says we removed 'off' and 'closed'
      from those strings. Maybe an earlier version of KOpeningHours...
      Or something weird's happening.
      c60b6edc
  19. 15 Jan, 2021 1 commit
  20. 14 Jan, 2021 2 commits
  21. 13 Jan, 2021 1 commit
  22. 11 Jan, 2021 1 commit
  23. 09 Jan, 2021 1 commit
    • David Faure's avatar
      Generalize the weekday autocorrect · 94b631dc
      David Faure authored
      Sep 16-Jun 15: Tu-Fr, Sa, Su [1,3] 09:00-14:00
      was normalized as
      Sep 16-Jun 15: Tu-Fr, Sa,Su[1,3] 09:00-14:00
      with a missing weekday autocorrects: the space before the first "Sa".
      This is because the monthday selector was preventing the first two rules
      from being collapsed together.
      
      This commit generalizes the weekday autocorrect to accept any additional
      selector in the first rule, except of course a time selector.
      It adds made-up testcases for the other cases of selectors in the first
      rule (a year range, a week range).
      I also grouped together all testcases that are mostly about the weekday
      autocorrect.
      94b631dc
  24. 08 Jan, 2021 1 commit
  25. 07 Jan, 2021 3 commits
  26. 06 Jan, 2021 1 commit
  27. 04 Jan, 2021 1 commit
  28. 03 Jan, 2021 1 commit