Skip to content

Fix 695 compiler warnings.

Michael Pyne requested to merge work/fix-warnings into master

kdesrc-build tells me that the pace of compiler and library advancement has brought phonon-gstreamer to 696 compiler warnings. This was even a slight underestimate, as the breakout I get from the build was:

      7 [-Wcpp]
      9 [-Wdeprecated-declarations]
    683 [-Wsuggest-override]
      2 [-Wswitch]
      1 [-Wvla]

The -Wcpp warnings (i.e. from #warning in the source) seemed to need some level of thought, but the remaining 695 looked managable.

The vast bulk of warnings here are for suggestions to add virtual override keywords (some of which drove nearly a dozen warnings per build just from a single missing override).

I broke up the warning fixes into separate commits to make review easier if desired. This isn't all automated, there were entries where a little bit of thought had to go into it and I may have thought wrong. Each commit log should point those out.

I've been testing by listening to my JuK playlists on a system with Phonon, Phonon Gstreamer, and no PulseAudio.

Please take a look. :)

Edited by Michael Pyne

Merge request reports